From: Dario Binacchi <dariobin@libero.it> To: linux-kernel@vger.kernel.org Cc: Gianluca Falavigna <gianluca.falavigna@inwind.it>, Dario Binacchi <dariobin@libero.it>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Marc Kleine-Budde <mkl@pengutronix.de>, Oliver Hartkopp <socketcan@hartkopp.net>, Vincent Mailhol <mailhol.vincent@wanadoo.fr>, Wolfgang Grandegger <wg@grandegger.com>, linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [RESEND PATCH 2/4] can: c_can: exit c_can_do_tx() early if no frames have been sent Date: Sun, 25 Jul 2021 18:11:48 +0200 [thread overview] Message-ID: <20210725161150.11801-3-dariobin@libero.it> (raw) In-Reply-To: <20210725161150.11801-1-dariobin@libero.it> The c_can_poll() handles RX/TX events unconditionally. It may therefore happen that c_can_do_tx() is called unnecessarily because the interrupt was triggered by the reception of a frame. In these cases, we avoid to execute unnecessary statements and exit immediately. Signed-off-by: Dario Binacchi <dariobin@libero.it> --- drivers/net/can/c_can/c_can_main.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/can/c_can/c_can_main.c b/drivers/net/can/c_can/c_can_main.c index 7588f70ca0fe..fec0e3416970 100644 --- a/drivers/net/can/c_can/c_can_main.c +++ b/drivers/net/can/c_can/c_can_main.c @@ -720,17 +720,18 @@ static void c_can_do_tx(struct net_device *dev) pkts++; } + if (!pkts) + return; + /* Clear the bits in the tx_active mask */ atomic_sub(clr, &priv->tx_active); if (clr & BIT(priv->msg_obj_tx_num - 1)) netif_wake_queue(dev); - if (pkts) { - stats->tx_bytes += bytes; - stats->tx_packets += pkts; - can_led_event(dev, CAN_LED_EVENT_TX); - } + stats->tx_bytes += bytes; + stats->tx_packets += pkts; + can_led_event(dev, CAN_LED_EVENT_TX); } /* If we have a gap in the pending bits, that means we either -- 2.17.1
next prev parent reply other threads:[~2021-07-25 16:12 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-25 16:11 [RESEND PATCH 0/4] can: c_can: cache frames to operate as a true FIFO Dario Binacchi 2021-07-25 16:11 ` [RESEND PATCH 1/4] can: c_can: remove struct c_can_priv::priv field Dario Binacchi 2021-07-25 16:11 ` Dario Binacchi [this message] 2021-07-25 16:11 ` [RESEND PATCH 3/4] can: c_can: support tx ring algorithm Dario Binacchi 2021-08-04 9:37 ` Marc Kleine-Budde 2021-07-25 16:11 ` [RESEND PATCH 4/4] can: c_can: cache frames to operate as a true FIFO Dario Binacchi 2021-08-04 9:34 ` Marc Kleine-Budde 2021-08-05 20:12 ` Dario Binacchi 2021-08-06 7:52 ` Marc Kleine-Budde 2021-08-04 9:45 ` Marc Kleine-Budde 2021-08-05 20:16 ` Dario Binacchi 2021-08-06 9:25 ` Marc Kleine-Budde 2021-08-07 12:36 ` Dario Binacchi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210725161150.11801-3-dariobin@libero.it \ --to=dariobin@libero.it \ --cc=davem@davemloft.net \ --cc=gianluca.falavigna@inwind.it \ --cc=kuba@kernel.org \ --cc=linux-can@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mailhol.vincent@wanadoo.fr \ --cc=mkl@pengutronix.de \ --cc=netdev@vger.kernel.org \ --cc=socketcan@hartkopp.net \ --cc=wg@grandegger.com \ --subject='Re: [RESEND PATCH 2/4] can: c_can: exit c_can_do_tx() early if no frames have been sent' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).