From: Marc Kleine-Budde <mkl@pengutronix.de> To: Dario Binacchi <dariobin@libero.it> Cc: linux-kernel@vger.kernel.org, Gianluca Falavigna <gianluca.falavigna@inwind.it>, Andrew Lunn <andrew@lunn.ch>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Oliver Hartkopp <socketcan@hartkopp.net>, Vincent Mailhol <mailhol.vincent@wanadoo.fr>, Wolfgang Grandegger <wg@grandegger.com>, linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RESEND PATCH 4/4] can: c_can: cache frames to operate as a true FIFO Date: Fri, 6 Aug 2021 09:52:20 +0200 [thread overview] Message-ID: <20210806075220.2psgtigcy3quyzrw@pengutronix.de> (raw) In-Reply-To: <1172393027.218339.1628194339000@mail1.libero.it> [-- Attachment #1: Type: text/plain, Size: 2149 bytes --] On 05.08.2021 22:12:18, Dario Binacchi wrote: > > > diff --git a/drivers/net/can/c_can/c_can.h b/drivers/net/can/c_can/c_can.h > > > index 8fe7e2138620..fc499a70b797 100644 > > > --- a/drivers/net/can/c_can/c_can.h > > > +++ b/drivers/net/can/c_can/c_can.h > > > +static inline u8 c_can_get_tx_free(const struct c_can_tx_ring *ring) > > > +{ > > > + return ring->obj_num - (ring->head - ring->tail); > > > +} > > > + > > > #endif /* C_CAN_H */ > > > diff --git a/drivers/net/can/c_can/c_can_main.c b/drivers/net/can/c_can/c_can_main.c > > > index 451ac9a9586a..4c061fef002c 100644 > > > --- a/drivers/net/can/c_can/c_can_main.c > > > +++ b/drivers/net/can/c_can/c_can_main.c > > > @@ -427,20 +427,6 @@ static void c_can_setup_receive_object(struct net_device *dev, int iface, > > > c_can_object_put(dev, iface, obj, IF_COMM_RCV_SETUP); > > > } > > > > > > -static u8 c_can_get_tx_free(const struct c_can_tx_ring *ring) > > > -{ > > > - u8 head = c_can_get_tx_head(ring); > > > - u8 tail = c_can_get_tx_tail(ring); > > > - > > > - /* This is not a FIFO. C/D_CAN sends out the buffers > > > - * prioritized. The lowest buffer number wins. > > > - */ > > > - if (head < tail) > > > - return 0; > > > - > > > - return ring->obj_num - head; > > > -} > > > - > > > > Can you move that change into patch 3? > > Patch 3 adds the ring transmission algorithm without compromising the > message transmission order. This is not a FIFO. Right, thanks! > C/D_CAN controller sends out the buffers prioritized. The lowest > buffer number wins, so moving the change into patch 3 may not > guarantee the transmission order. In patch 3, however, I will move > c_can_get_tx_free() from c_can_main.c to c_can.h, so that in patch 4 > it will be clearer how the routine has changed. The updated patch looks much nicer now, thanks! Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-08-06 7:52 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-25 16:11 [RESEND PATCH 0/4] " Dario Binacchi 2021-07-25 16:11 ` [RESEND PATCH 1/4] can: c_can: remove struct c_can_priv::priv field Dario Binacchi 2021-07-25 16:11 ` [RESEND PATCH 2/4] can: c_can: exit c_can_do_tx() early if no frames have been sent Dario Binacchi 2021-07-25 16:11 ` [RESEND PATCH 3/4] can: c_can: support tx ring algorithm Dario Binacchi 2021-08-04 9:37 ` Marc Kleine-Budde 2021-07-25 16:11 ` [RESEND PATCH 4/4] can: c_can: cache frames to operate as a true FIFO Dario Binacchi 2021-08-04 9:34 ` Marc Kleine-Budde 2021-08-05 20:12 ` Dario Binacchi 2021-08-06 7:52 ` Marc Kleine-Budde [this message] 2021-08-04 9:45 ` Marc Kleine-Budde 2021-08-05 20:16 ` Dario Binacchi 2021-08-06 9:25 ` Marc Kleine-Budde 2021-08-07 12:36 ` Dario Binacchi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210806075220.2psgtigcy3quyzrw@pengutronix.de \ --to=mkl@pengutronix.de \ --cc=andrew@lunn.ch \ --cc=dariobin@libero.it \ --cc=davem@davemloft.net \ --cc=gianluca.falavigna@inwind.it \ --cc=kuba@kernel.org \ --cc=linux-can@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mailhol.vincent@wanadoo.fr \ --cc=netdev@vger.kernel.org \ --cc=socketcan@hartkopp.net \ --cc=wg@grandegger.com \ --subject='Re: [RESEND PATCH 4/4] can: c_can: cache frames to operate as a true FIFO' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).