From: Kefeng Wang <wangkefeng.wang@huawei.com> To: <arnd@arndb.de>, <linux-arch@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>, <rostedt@goodmis.org>, <mingo@redhat.com>, <davem@davemloft.net>, <ast@kernel.org>, <ryabinin.a.a@gmail.com> Cc: <mpe@ellerman.id.au>, <benh@kernel.crashing.org>, <paulus@samba.org>, Kefeng Wang <wangkefeng.wang@huawei.com>, Daniel Borkmann <daniel@iogearbox.net>, Sami Tolvanen <samitolvanen@google.com>, "Nathan Chancellor" <nathan@kernel.org>, <bpf@vger.kernel.org> Subject: [PATCH v2 5/7] kallsyms: Rename is_kernel() and is_kernel_text() Date: Wed, 28 Jul 2021 16:13:18 +0800 [thread overview] Message-ID: <20210728081320.20394-6-wangkefeng.wang@huawei.com> (raw) In-Reply-To: <20210728081320.20394-1-wangkefeng.wang@huawei.com> The is_kernel[_text]() function check the address whether or not in kernel[_text] ranges, also they will check the address whether or not in gate area, so use better name. Cc: Alexei Starovoitov <ast@kernel.org> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Sami Tolvanen <samitolvanen@google.com> Cc: Nathan Chancellor <nathan@kernel.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: bpf@vger.kernel.org Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- arch/x86/net/bpf_jit_comp.c | 2 +- include/linux/kallsyms.h | 8 ++++---- kernel/cfi.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/net/bpf_jit_comp.c b/arch/x86/net/bpf_jit_comp.c index 333650b9372a..c87d0dd4370d 100644 --- a/arch/x86/net/bpf_jit_comp.c +++ b/arch/x86/net/bpf_jit_comp.c @@ -372,7 +372,7 @@ static int __bpf_arch_text_poke(void *ip, enum bpf_text_poke_type t, int bpf_arch_text_poke(void *ip, enum bpf_text_poke_type t, void *old_addr, void *new_addr) { - if (!is_kernel_text((long)ip) && + if (!is_kernel_text_or_gate_area((long)ip) && !is_bpf_text_address((long)ip)) /* BPF poking in modules is not supported */ return -EINVAL; diff --git a/include/linux/kallsyms.h b/include/linux/kallsyms.h index 8a9d329c927c..4f501ac9c2c2 100644 --- a/include/linux/kallsyms.h +++ b/include/linux/kallsyms.h @@ -24,14 +24,14 @@ struct cred; struct module; -static inline int is_kernel_text(unsigned long addr) +static inline int is_kernel_text_or_gate_area(unsigned long addr) { if ((addr >= (unsigned long)_stext && addr < (unsigned long)_etext)) return 1; return in_gate_area_no_mm(addr); } -static inline int is_kernel(unsigned long addr) +static inline int is_kernel_or_gate_area(unsigned long addr) { if (addr >= (unsigned long)_stext && addr < (unsigned long)_end) return 1; @@ -41,9 +41,9 @@ static inline int is_kernel(unsigned long addr) static inline int is_ksym_addr(unsigned long addr) { if (IS_ENABLED(CONFIG_KALLSYMS_ALL)) - return is_kernel(addr); + return is_kernel_or_gate_area(addr); - return is_kernel_text(addr) || is_kernel_inittext(addr); + return is_kernel_text_or_gate_area(addr) || is_kernel_inittext(addr); } static inline void *dereference_symbol_descriptor(void *ptr) diff --git a/kernel/cfi.c b/kernel/cfi.c index e17a56639766..e7d90eff4382 100644 --- a/kernel/cfi.c +++ b/kernel/cfi.c @@ -282,7 +282,7 @@ static inline cfi_check_fn find_check_fn(unsigned long ptr) { cfi_check_fn fn = NULL; - if (is_kernel_text(ptr)) + if (is_kernel_text_or_gate_area(ptr)) return __cfi_check; /* -- 2.26.2
next prev parent reply other threads:[~2021-07-28 8:07 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-28 8:13 [PATCH v2 0/7] sections: Unify kernel sections range check and use Kefeng Wang 2021-07-28 8:13 ` [PATCH v2 1/7] kallsyms: Remove arch specific text and data check Kefeng Wang 2021-07-28 8:13 ` [PATCH v2 2/7] kallsyms: Fix address-checks for kernel related range Kefeng Wang 2021-07-28 14:46 ` Steven Rostedt 2021-07-29 2:03 ` Kefeng Wang 2021-07-28 8:13 ` [PATCH v2 3/7] sections: Move and rename core_kernel_data() to is_kernel_core_data() Kefeng Wang 2021-07-28 8:13 ` [PATCH v2 4/7] sections: Move is_kernel_inittext() into sections.h Kefeng Wang 2021-07-28 8:13 ` Kefeng Wang [this message] 2021-07-28 15:28 ` [PATCH v2 5/7] kallsyms: Rename is_kernel() and is_kernel_text() Steven Rostedt 2021-07-29 2:00 ` Kefeng Wang 2021-07-29 4:05 ` Steven Rostedt 2021-07-29 11:06 ` Kefeng Wang 2021-07-28 8:13 ` [PATCH v2 6/7] sections: Add new " Kefeng Wang 2021-07-28 15:32 ` Steven Rostedt 2021-07-29 2:02 ` Kefeng Wang 2021-07-28 8:13 ` [PATCH v2 7/7] powerpc/mm: Use is_kernel_text() and is_kernel_inittext() helper Kefeng Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210728081320.20394-6-wangkefeng.wang@huawei.com \ --to=wangkefeng.wang@huawei.com \ --cc=arnd@arndb.de \ --cc=ast@kernel.org \ --cc=benh@kernel.crashing.org \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=davem@davemloft.net \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mingo@redhat.com \ --cc=mpe@ellerman.id.au \ --cc=nathan@kernel.org \ --cc=paulus@samba.org \ --cc=rostedt@goodmis.org \ --cc=ryabinin.a.a@gmail.com \ --cc=samitolvanen@google.com \ --subject='Re: [PATCH v2 5/7] kallsyms: Rename is_kernel() and is_kernel_text()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).