From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: <arnd@arndb.de>, <linux-arch@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
<mingo@redhat.com>, <davem@davemloft.net>, <ast@kernel.org>,
<ryabinin.a.a@gmail.com>, <mpe@ellerman.id.au>,
<benh@kernel.crashing.org>, <paulus@samba.org>
Subject: Re: [PATCH v2 6/7] sections: Add new is_kernel() and is_kernel_text()
Date: Thu, 29 Jul 2021 10:02:55 +0800 [thread overview]
Message-ID: <503b712c-ae62-ae05-907d-7bca67a2b00a@huawei.com> (raw)
In-Reply-To: <20210728113204.67fa6dfc@oasis.local.home>
On 2021/7/28 23:32, Steven Rostedt wrote:
> On Wed, 28 Jul 2021 16:13:19 +0800
> Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
>> @@ -64,8 +64,7 @@ const struct exception_table_entry *search_exception_tables(unsigned long addr)
>>
>> int notrace core_kernel_text(unsigned long addr)
>> {
>> - if (addr >= (unsigned long)_stext &&
>> - addr < (unsigned long)_etext)
>> + if (is_kernel_text(addr))
> Perhaps this was a bug, and these functions should be checking the gate
> area as well, as that is part of kernel text.
Ok, I would fix this if patch5 is reviewed well.
>
> -- Steve
>
>
>> return 1;
>>
>> if (system_state < SYSTEM_RUNNING &&
>> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
>> index 884a950c7026..88f5b0c058b7 100644
>> --- a/mm/kasan/report.c
>> +++ b/mm/kasan/report.c
>> @@ -235,7 +235,7 @@ static void describe_object(struct kmem_cache *cache, void *object,
>>
>> static inline bool kernel_or_module_addr(const void *addr)
>> {
>> - if (addr >= (void *)_stext && addr < (void *)_end)
>> + if (is_kernel((unsigned long)addr))
>> return true;
>> if (is_module_address((unsigned long)addr))
>> return true;
>> --
> .
>
next prev parent reply other threads:[~2021-07-29 2:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 8:13 [PATCH v2 0/7] sections: Unify kernel sections range check and use Kefeng Wang
2021-07-28 8:13 ` [PATCH v2 1/7] kallsyms: Remove arch specific text and data check Kefeng Wang
2021-07-28 8:13 ` [PATCH v2 2/7] kallsyms: Fix address-checks for kernel related range Kefeng Wang
2021-07-28 14:46 ` Steven Rostedt
2021-07-29 2:03 ` Kefeng Wang
2021-07-28 8:13 ` [PATCH v2 3/7] sections: Move and rename core_kernel_data() to is_kernel_core_data() Kefeng Wang
2021-07-28 8:13 ` [PATCH v2 4/7] sections: Move is_kernel_inittext() into sections.h Kefeng Wang
2021-07-28 8:13 ` [PATCH v2 5/7] kallsyms: Rename is_kernel() and is_kernel_text() Kefeng Wang
2021-07-28 15:28 ` Steven Rostedt
2021-07-29 2:00 ` Kefeng Wang
2021-07-29 4:05 ` Steven Rostedt
2021-07-29 11:06 ` Kefeng Wang
2021-07-28 8:13 ` [PATCH v2 6/7] sections: Add new " Kefeng Wang
2021-07-28 15:32 ` Steven Rostedt
2021-07-29 2:02 ` Kefeng Wang [this message]
2021-07-28 8:13 ` [PATCH v2 7/7] powerpc/mm: Use is_kernel_text() and is_kernel_inittext() helper Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503b712c-ae62-ae05-907d-7bca67a2b00a@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).