linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 0/1] AUXADC: Mediatek auxadc driver
@ 2021-07-29  8:01 Hui Liu
  2021-07-29  8:01 ` [PATCH v1] iio: mtk-auxadc: add mutex_destroy Hui Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Hui Liu @ 2021-07-29  8:01 UTC (permalink / raw)
  To: robh+dt, jic23, lars, pmeerw
  Cc: srv_heupstream, hui.liu, zhiyong.tao, chun-hung.wu, yingjoe.chen,
	seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel,
	linux-arm-kernel, linux-iio, linux-mediatek

This series includes one patch:
1.Add mutex_destroy when probe fail and remove device.

Changes in patch v1:
1. In probe function, move mutex_destroy to "err_power_off".
2. In remove function, move mutex_destroy before "clk_disable_unprepare".

Hui Liu (1):
  iio: mtk-auxadc: add mutex_destroy

 drivers/iio/adc/mt6577_auxadc.c | 2 ++
 1 file changed, 2 insertions(+)

--
2.18.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v1] iio: mtk-auxadc: add mutex_destroy
  2021-07-29  8:01 [PATCH v1 0/1] AUXADC: Mediatek auxadc driver Hui Liu
@ 2021-07-29  8:01 ` Hui Liu
  2021-07-30 13:44   ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: Hui Liu @ 2021-07-29  8:01 UTC (permalink / raw)
  To: robh+dt, jic23, lars, pmeerw
  Cc: srv_heupstream, hui.liu, zhiyong.tao, chun-hung.wu, yingjoe.chen,
	seiya.wang, matthias.bgg, s.hauer, devicetree, linux-kernel,
	linux-arm-kernel, linux-iio, linux-mediatek

Add mutex_destroy when probe fail and remove device.

Signed-off-by: Hui Liu <hui.liu@mediatek.com>
---
 drivers/iio/adc/mt6577_auxadc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
index 79c1dd68b909..d57243037ad6 100644
--- a/drivers/iio/adc/mt6577_auxadc.c
+++ b/drivers/iio/adc/mt6577_auxadc.c
@@ -289,6 +289,7 @@ static int mt6577_auxadc_probe(struct platform_device *pdev)
 	ret = iio_device_register(indio_dev);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "failed to register iio device\n");
+		mutex_destroy(&adc_dev->lock);
 		goto err_power_off;
 	}
 
@@ -313,6 +314,7 @@ static int mt6577_auxadc_remove(struct platform_device *pdev)
 			      0, MT6577_AUXADC_PDN_EN);
 
 	clk_disable_unprepare(adc_dev->adc_clk);
+	mutex_destroy(&adc_dev->lock);
 
 	return 0;
 }
-- 
2.18.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] iio: mtk-auxadc: add mutex_destroy
  2021-07-29  8:01 ` [PATCH v1] iio: mtk-auxadc: add mutex_destroy Hui Liu
@ 2021-07-30 13:44   ` Jonathan Cameron
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2021-07-30 13:44 UTC (permalink / raw)
  To: Hui Liu
  Cc: robh+dt, jic23, lars, pmeerw, srv_heupstream, zhiyong.tao,
	chun-hung.wu, yingjoe.chen, seiya.wang, matthias.bgg, s.hauer,
	devicetree, linux-kernel, linux-arm-kernel, linux-iio,
	linux-mediatek

On Thu, 29 Jul 2021 16:01:35 +0800
Hui Liu <hui.liu@mediatek.com> wrote:

> Add mutex_destroy when probe fail and remove device.
> 
> Signed-off-by: Hui Liu <hui.liu@mediatek.com>

Hi Hui Liu,

Two things here.

1) You need to explain with a clear example flow when this would serve a
   useful purpose.  As I explained before, we do no in general put mutex_destroy()
   in remove paths as it is usually just noise.

2) It's in the wrong order logically. mutex init is between the clk_prepare_enable
   and iio_device_register, hence if we are going to have mutex destroy it must also
   be in that that location (remove should be reverse of probe or there should be
   a clear comment explaining why we need to do things in a different order.

3) If touching this code at all, please move all of the probe / remove to devm_
   managed code so that we don't need to get this ordering right at all because
   it will be done automatically.

So I won't apply this without 1 and even if I accepted the principle, it's
still in the wrong place in remove.

Jonathan

> ---
>  drivers/iio/adc/mt6577_auxadc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
> index 79c1dd68b909..d57243037ad6 100644
> --- a/drivers/iio/adc/mt6577_auxadc.c
> +++ b/drivers/iio/adc/mt6577_auxadc.c
> @@ -289,6 +289,7 @@ static int mt6577_auxadc_probe(struct platform_device *pdev)
>  	ret = iio_device_register(indio_dev);
>  	if (ret < 0) {
>  		dev_err(&pdev->dev, "failed to register iio device\n");
> +		mutex_destroy(&adc_dev->lock);
>  		goto err_power_off;
>  	}
>  
> @@ -313,6 +314,7 @@ static int mt6577_auxadc_remove(struct platform_device *pdev)
>  			      0, MT6577_AUXADC_PDN_EN);
>  
>  	clk_disable_unprepare(adc_dev->adc_clk);
> +	mutex_destroy(&adc_dev->lock);
>  
>  	return 0;
>  }


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-30 13:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29  8:01 [PATCH v1 0/1] AUXADC: Mediatek auxadc driver Hui Liu
2021-07-29  8:01 ` [PATCH v1] iio: mtk-auxadc: add mutex_destroy Hui Liu
2021-07-30 13:44   ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).