* [PATCH v2 0/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART @ 2021-06-15 13:16 Zhen Lei 2021-06-15 13:16 ` [PATCH v2 1/1] " Zhen Lei 0 siblings, 1 reply; 8+ messages in thread From: Zhen Lei @ 2021-06-15 13:16 UTC (permalink / raw) To: Shawn Guo, Li Yang, Rob Herring, Mark Kettenis, devicetree, linux-arm-kernel, linux-kernel Cc: Zhen Lei v1 --> v2: The UART of LX2160A is PL011, not sbsa-uart, correct the compatible string. v1: Remove from "arm,pl011" the compatible string. Zhen Lei (1): arm64: dts: lx2160a: Fix the compatible string of LX2160A UART arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) -- 2.25.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART 2021-06-15 13:16 [PATCH v2 0/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART Zhen Lei @ 2021-06-15 13:16 ` Zhen Lei 2021-07-14 7:22 ` Shawn Guo 2021-08-09 22:52 ` Leo Li 0 siblings, 2 replies; 8+ messages in thread From: Zhen Lei @ 2021-06-15 13:16 UTC (permalink / raw) To: Shawn Guo, Li Yang, Rob Herring, Mark Kettenis, devicetree, linux-arm-kernel, linux-kernel Cc: Zhen Lei Mark Kettenis told us that: According to the NXP documentation, the LX2160A has a real PL011 UART. Therefore, rewrite it to the compatible string of pl011. The property "current-speed" specific to "arm,sbsa-uart" is also deleted. Suggested-by: Shawn Guo <shawnguo@kernel.org> Suggested-by: Mark Kettenis <mark.kettenis@xs4all.nl> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi index c4b1a59ba424..d2e6f7285674 100644 --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi @@ -920,34 +920,30 @@ QORIQ_CLK_PLL_DIV(8)>, }; uart0: serial@21c0000 { - compatible = "arm,sbsa-uart","arm,pl011"; + compatible = "arm,pl011", "arm,primecell"; reg = <0x0 0x21c0000 0x0 0x1000>; interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; - current-speed = <115200>; status = "disabled"; }; uart1: serial@21d0000 { - compatible = "arm,sbsa-uart","arm,pl011"; + compatible = "arm,pl011", "arm,primecell"; reg = <0x0 0x21d0000 0x0 0x1000>; interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>; - current-speed = <115200>; status = "disabled"; }; uart2: serial@21e0000 { - compatible = "arm,sbsa-uart","arm,pl011"; + compatible = "arm,pl011", "arm,primecell"; reg = <0x0 0x21e0000 0x0 0x1000>; interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; - current-speed = <115200>; status = "disabled"; }; uart3: serial@21f0000 { - compatible = "arm,sbsa-uart","arm,pl011"; + compatible = "arm,pl011", "arm,primecell"; reg = <0x0 0x21f0000 0x0 0x1000>; interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; - current-speed = <115200>; status = "disabled"; }; -- 2.25.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART 2021-06-15 13:16 ` [PATCH v2 1/1] " Zhen Lei @ 2021-07-14 7:22 ` Shawn Guo 2021-08-09 22:52 ` Leo Li 1 sibling, 0 replies; 8+ messages in thread From: Shawn Guo @ 2021-07-14 7:22 UTC (permalink / raw) To: Zhen Lei Cc: Li Yang, Rob Herring, Mark Kettenis, devicetree, linux-arm-kernel, linux-kernel On Tue, Jun 15, 2021 at 09:16:05PM +0800, Zhen Lei wrote: > Mark Kettenis told us that: > According to the NXP documentation, the LX2160A has a real PL011 UART. > > Therefore, rewrite it to the compatible string of pl011. The property > "current-speed" specific to "arm,sbsa-uart" is also deleted. > > Suggested-by: Shawn Guo <shawnguo@kernel.org> > Suggested-by: Mark Kettenis <mark.kettenis@xs4all.nl> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> Applied, thanks. ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART 2021-06-15 13:16 ` [PATCH v2 1/1] " Zhen Lei 2021-07-14 7:22 ` Shawn Guo @ 2021-08-09 22:52 ` Leo Li 2021-08-10 1:28 ` Leizhen (ThunderTown) 2021-08-14 4:47 ` Shawn Guo 1 sibling, 2 replies; 8+ messages in thread From: Leo Li @ 2021-08-09 22:52 UTC (permalink / raw) To: Zhen Lei, Shawn Guo, Rob Herring, Mark Kettenis, devicetree, linux-arm-kernel, linux-kernel > -----Original Message----- > From: Zhen Lei <thunder.leizhen@huawei.com> > Sent: Tuesday, June 15, 2021 8:16 AM > To: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob > Herring <robh+dt@kernel.org>; Mark Kettenis <mark.kettenis@xs4all.nl>; > devicetree <devicetree@vger.kernel.org>; linux-arm-kernel <linux-arm- > kernel@lists.infradead.org>; linux-kernel <linux-kernel@vger.kernel.org> > Cc: Zhen Lei <thunder.leizhen@huawei.com> > Subject: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of > LX2160A UART > > Mark Kettenis told us that: > According to the NXP documentation, the LX2160A has a real PL011 UART. > > Therefore, rewrite it to the compatible string of pl011. The property "current- > speed" specific to "arm,sbsa-uart" is also deleted. Sorry that I missed the discussion on the v1. But looks like this change breaks the LX2160 boot. The AMBA matching doesn't seem to work. And the console is not registered correctly. [ 0.639055] OF: amba_device_add() failed (-2) for /soc/serial@21c0000 [ 0.645612] OF: amba_device_add() failed (-2) for /soc/serial@21d0000 > > Suggested-by: Shawn Guo <shawnguo@kernel.org> > Suggested-by: Mark Kettenis <mark.kettenis@xs4all.nl> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > index c4b1a59ba424..d2e6f7285674 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > @@ -920,34 +920,30 @@ QORIQ_CLK_PLL_DIV(8)>, > }; > > uart0: serial@21c0000 { > - compatible = "arm,sbsa-uart","arm,pl011"; > + compatible = "arm,pl011", "arm,primecell"; > reg = <0x0 0x21c0000 0x0 0x1000>; > interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; > - current-speed = <115200>; > status = "disabled"; > }; > > uart1: serial@21d0000 { > - compatible = "arm,sbsa-uart","arm,pl011"; > + compatible = "arm,pl011", "arm,primecell"; > reg = <0x0 0x21d0000 0x0 0x1000>; > interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>; > - current-speed = <115200>; > status = "disabled"; > }; > > uart2: serial@21e0000 { > - compatible = "arm,sbsa-uart","arm,pl011"; > + compatible = "arm,pl011", "arm,primecell"; > reg = <0x0 0x21e0000 0x0 0x1000>; > interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; > - current-speed = <115200>; > status = "disabled"; > }; > > uart3: serial@21f0000 { > - compatible = "arm,sbsa-uart","arm,pl011"; > + compatible = "arm,pl011", "arm,primecell"; > reg = <0x0 0x21f0000 0x0 0x1000>; > interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; > - current-speed = <115200>; > status = "disabled"; > }; > > -- > 2.25.1 > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART 2021-08-09 22:52 ` Leo Li @ 2021-08-10 1:28 ` Leizhen (ThunderTown) 2021-08-10 3:38 ` Leo Li 2021-08-14 4:47 ` Shawn Guo 1 sibling, 1 reply; 8+ messages in thread From: Leizhen (ThunderTown) @ 2021-08-10 1:28 UTC (permalink / raw) To: Leo Li, Shawn Guo, Rob Herring, Mark Kettenis, devicetree, linux-arm-kernel, linux-kernel On 2021/8/10 6:52, Leo Li wrote: > > >> -----Original Message----- >> From: Zhen Lei <thunder.leizhen@huawei.com> >> Sent: Tuesday, June 15, 2021 8:16 AM >> To: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob >> Herring <robh+dt@kernel.org>; Mark Kettenis <mark.kettenis@xs4all.nl>; >> devicetree <devicetree@vger.kernel.org>; linux-arm-kernel <linux-arm- >> kernel@lists.infradead.org>; linux-kernel <linux-kernel@vger.kernel.org> >> Cc: Zhen Lei <thunder.leizhen@huawei.com> >> Subject: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of >> LX2160A UART >> >> Mark Kettenis told us that: >> According to the NXP documentation, the LX2160A has a real PL011 UART. >> >> Therefore, rewrite it to the compatible string of pl011. The property "current- >> speed" specific to "arm,sbsa-uart" is also deleted. > > Sorry that I missed the discussion on the v1. But looks like this change breaks the LX2160 boot. The AMBA matching doesn't seem to work. And the console is not registered correctly. https://lore.kernel.org/linux-arm-kernel/cba3a29f-92b5-072a-9a27-60240f072dad@huawei.com/ Maybe we should fall back to v1. > > [ 0.639055] OF: amba_device_add() failed (-2) for /soc/serial@21c0000 > [ 0.645612] OF: amba_device_add() failed (-2) for /soc/serial@21d0000 > >> >> Suggested-by: Shawn Guo <shawnguo@kernel.org> >> Suggested-by: Mark Kettenis <mark.kettenis@xs4all.nl> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> >> --- >> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 12 ++++-------- >> 1 file changed, 4 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >> b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >> index c4b1a59ba424..d2e6f7285674 100644 >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >> @@ -920,34 +920,30 @@ QORIQ_CLK_PLL_DIV(8)>, >> }; >> >> uart0: serial@21c0000 { >> - compatible = "arm,sbsa-uart","arm,pl011"; >> + compatible = "arm,pl011", "arm,primecell"; >> reg = <0x0 0x21c0000 0x0 0x1000>; >> interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; >> - current-speed = <115200>; >> status = "disabled"; >> }; >> >> uart1: serial@21d0000 { >> - compatible = "arm,sbsa-uart","arm,pl011"; >> + compatible = "arm,pl011", "arm,primecell"; >> reg = <0x0 0x21d0000 0x0 0x1000>; >> interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>; >> - current-speed = <115200>; >> status = "disabled"; >> }; >> >> uart2: serial@21e0000 { >> - compatible = "arm,sbsa-uart","arm,pl011"; >> + compatible = "arm,pl011", "arm,primecell"; >> reg = <0x0 0x21e0000 0x0 0x1000>; >> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; >> - current-speed = <115200>; >> status = "disabled"; >> }; >> >> uart3: serial@21f0000 { >> - compatible = "arm,sbsa-uart","arm,pl011"; >> + compatible = "arm,pl011", "arm,primecell"; >> reg = <0x0 0x21f0000 0x0 0x1000>; >> interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; >> - current-speed = <115200>; >> status = "disabled"; >> }; >> >> -- >> 2.25.1 >> > > . > ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART 2021-08-10 1:28 ` Leizhen (ThunderTown) @ 2021-08-10 3:38 ` Leo Li 2021-08-12 23:09 ` Li Yang 0 siblings, 1 reply; 8+ messages in thread From: Leo Li @ 2021-08-10 3:38 UTC (permalink / raw) To: Leizhen (ThunderTown), Shawn Guo, Rob Herring, Mark Kettenis, devicetree, linux-arm-kernel, linux-kernel > -----Original Message----- > From: Leizhen (ThunderTown) <thunder.leizhen@huawei.com> > Sent: Monday, August 9, 2021 8:28 PM > To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org>; Rob > Herring <robh+dt@kernel.org>; Mark Kettenis <mark.kettenis@xs4all.nl>; > devicetree <devicetree@vger.kernel.org>; linux-arm-kernel <linux-arm- > kernel@lists.infradead.org>; linux-kernel <linux-kernel@vger.kernel.org> > Subject: Re: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of > LX2160A UART > > > > On 2021/8/10 6:52, Leo Li wrote: > > > > > >> -----Original Message----- > >> From: Zhen Lei <thunder.leizhen@huawei.com> > >> Sent: Tuesday, June 15, 2021 8:16 AM > >> To: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; > Rob > >> Herring <robh+dt@kernel.org>; Mark Kettenis > >> <mark.kettenis@xs4all.nl>; devicetree <devicetree@vger.kernel.org>; > >> linux-arm-kernel <linux-arm- kernel@lists.infradead.org>; > >> linux-kernel <linux-kernel@vger.kernel.org> > >> Cc: Zhen Lei <thunder.leizhen@huawei.com> > >> Subject: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible > >> string of LX2160A UART > >> > >> Mark Kettenis told us that: > >> According to the NXP documentation, the LX2160A has a real PL011 UART. > >> > >> Therefore, rewrite it to the compatible string of pl011. The property > >> "current- speed" specific to "arm,sbsa-uart" is also deleted. > > > > Sorry that I missed the discussion on the v1. But looks like this change > breaks the LX2160 boot. The AMBA matching doesn't seem to work. And > the console is not registered correctly. > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.k > ernel.org%2Flinux-arm-kernel%2Fcba3a29f-92b5-072a-9a27- > 60240f072dad%40huawei.com%2F&data=04%7C01%7Cleoyang.li%40nx > p.com%7C9986b52f71724d7f6ae108d95b9e1d9b%7C686ea1d3bc2b4c6fa92cd > 99c5c301635%7C0%7C0%7C637641556923909225%7CUnknown%7CTWFpbGZ > sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M > n0%3D%7C1000&sdata=wReesSfMj1hV2iPTN0%2F%2B%2Fb%2BKJH8xF > LLcDgOMfjx731I%3D&reserved=0 > > Maybe we should fall back to v1. I didn't look into the problem in detail. Probably it is because of lacking the clock properties needed by the AMBA bus? > > > > > [ 0.639055] OF: amba_device_add() failed (-2) for /soc/serial@21c0000 > > [ 0.645612] OF: amba_device_add() failed (-2) for /soc/serial@21d0000 > > > >> > >> Suggested-by: Shawn Guo <shawnguo@kernel.org> > >> Suggested-by: Mark Kettenis <mark.kettenis@xs4all.nl> > >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > >> --- > >> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 12 ++++-------- > >> 1 file changed, 4 insertions(+), 8 deletions(-) > >> > >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > >> b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > >> index c4b1a59ba424..d2e6f7285674 100644 > >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > >> @@ -920,34 +920,30 @@ QORIQ_CLK_PLL_DIV(8)>, > >> }; > >> > >> uart0: serial@21c0000 { > >> - compatible = "arm,sbsa-uart","arm,pl011"; > >> + compatible = "arm,pl011", "arm,primecell"; > >> reg = <0x0 0x21c0000 0x0 0x1000>; > >> interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; > >> - current-speed = <115200>; > >> status = "disabled"; > >> }; > >> > >> uart1: serial@21d0000 { > >> - compatible = "arm,sbsa-uart","arm,pl011"; > >> + compatible = "arm,pl011", "arm,primecell"; > >> reg = <0x0 0x21d0000 0x0 0x1000>; > >> interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>; > >> - current-speed = <115200>; > >> status = "disabled"; > >> }; > >> > >> uart2: serial@21e0000 { > >> - compatible = "arm,sbsa-uart","arm,pl011"; > >> + compatible = "arm,pl011", "arm,primecell"; > >> reg = <0x0 0x21e0000 0x0 0x1000>; > >> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; > >> - current-speed = <115200>; > >> status = "disabled"; > >> }; > >> > >> uart3: serial@21f0000 { > >> - compatible = "arm,sbsa-uart","arm,pl011"; > >> + compatible = "arm,pl011", "arm,primecell"; > >> reg = <0x0 0x21f0000 0x0 0x1000>; > >> interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; > >> - current-speed = <115200>; > >> status = "disabled"; > >> }; > >> > >> -- > >> 2.25.1 > >> > > > > . > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART 2021-08-10 3:38 ` Leo Li @ 2021-08-12 23:09 ` Li Yang 0 siblings, 0 replies; 8+ messages in thread From: Li Yang @ 2021-08-12 23:09 UTC (permalink / raw) To: Leizhen (ThunderTown), Shawn Guo, Rob Herring, Mark Kettenis, devicetree, linux-arm-kernel, linux-kernel On Tue, Aug 10, 2021 at 1:28 AM Leo Li <leoyang.li@nxp.com> wrote: > > > > > -----Original Message----- > > From: Leizhen (ThunderTown) <thunder.leizhen@huawei.com> > > Sent: Monday, August 9, 2021 8:28 PM > > To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org>; Rob > > Herring <robh+dt@kernel.org>; Mark Kettenis <mark.kettenis@xs4all.nl>; > > devicetree <devicetree@vger.kernel.org>; linux-arm-kernel <linux-arm- > > kernel@lists.infradead.org>; linux-kernel <linux-kernel@vger.kernel.org> > > Subject: Re: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of > > LX2160A UART > > > > > > > > On 2021/8/10 6:52, Leo Li wrote: > > > > > > > > >> -----Original Message----- > > >> From: Zhen Lei <thunder.leizhen@huawei.com> > > >> Sent: Tuesday, June 15, 2021 8:16 AM > > >> To: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; > > Rob > > >> Herring <robh+dt@kernel.org>; Mark Kettenis > > >> <mark.kettenis@xs4all.nl>; devicetree <devicetree@vger.kernel.org>; > > >> linux-arm-kernel <linux-arm- kernel@lists.infradead.org>; > > >> linux-kernel <linux-kernel@vger.kernel.org> > > >> Cc: Zhen Lei <thunder.leizhen@huawei.com> > > >> Subject: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible > > >> string of LX2160A UART > > >> > > >> Mark Kettenis told us that: > > >> According to the NXP documentation, the LX2160A has a real PL011 UART. > > >> > > >> Therefore, rewrite it to the compatible string of pl011. The property > > >> "current- speed" specific to "arm,sbsa-uart" is also deleted. > > > > > > Sorry that I missed the discussion on the v1. But looks like this change > > breaks the LX2160 boot. The AMBA matching doesn't seem to work. And > > the console is not registered correctly. > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.k > > ernel.org%2Flinux-arm-kernel%2Fcba3a29f-92b5-072a-9a27- > > 60240f072dad%40huawei.com%2F&data=04%7C01%7Cleoyang.li%40nx > > p.com%7C9986b52f71724d7f6ae108d95b9e1d9b%7C686ea1d3bc2b4c6fa92cd > > 99c5c301635%7C0%7C0%7C637641556923909225%7CUnknown%7CTWFpbGZ > > sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M > > n0%3D%7C1000&sdata=wReesSfMj1hV2iPTN0%2F%2B%2Fb%2BKJH8xF > > LLcDgOMfjx731I%3D&reserved=0 > > > > Maybe we should fall back to v1. > > I didn't look into the problem in detail. Probably it is because of lacking the clock properties needed by the AMBA bus? > After reading through the history of sbsa-uart, I think that I would prefer us to fall back to v1 to be compatible with sbsa-uart rather than changing it to be compatible with pl011. Although the hardware is actually compatible with the pl011, it would be better for us to follow the newer SBSA standard to leave advanced configuration to firmware and just expose the simple standard interface to OS. Regards, Leo > > > > > > > > [ 0.639055] OF: amba_device_add() failed (-2) for /soc/serial@21c0000 > > > [ 0.645612] OF: amba_device_add() failed (-2) for /soc/serial@21d0000 > > > > > >> > > >> Suggested-by: Shawn Guo <shawnguo@kernel.org> > > >> Suggested-by: Mark Kettenis <mark.kettenis@xs4all.nl> > > >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > > >> --- > > >> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 12 ++++-------- > > >> 1 file changed, 4 insertions(+), 8 deletions(-) > > >> > > >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > >> b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > >> index c4b1a59ba424..d2e6f7285674 100644 > > >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > >> @@ -920,34 +920,30 @@ QORIQ_CLK_PLL_DIV(8)>, > > >> }; > > >> > > >> uart0: serial@21c0000 { > > >> - compatible = "arm,sbsa-uart","arm,pl011"; > > >> + compatible = "arm,pl011", "arm,primecell"; > > >> reg = <0x0 0x21c0000 0x0 0x1000>; > > >> interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; > > >> - current-speed = <115200>; > > >> status = "disabled"; > > >> }; > > >> > > >> uart1: serial@21d0000 { > > >> - compatible = "arm,sbsa-uart","arm,pl011"; > > >> + compatible = "arm,pl011", "arm,primecell"; > > >> reg = <0x0 0x21d0000 0x0 0x1000>; > > >> interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>; > > >> - current-speed = <115200>; > > >> status = "disabled"; > > >> }; > > >> > > >> uart2: serial@21e0000 { > > >> - compatible = "arm,sbsa-uart","arm,pl011"; > > >> + compatible = "arm,pl011", "arm,primecell"; > > >> reg = <0x0 0x21e0000 0x0 0x1000>; > > >> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; > > >> - current-speed = <115200>; > > >> status = "disabled"; > > >> }; > > >> > > >> uart3: serial@21f0000 { > > >> - compatible = "arm,sbsa-uart","arm,pl011"; > > >> + compatible = "arm,pl011", "arm,primecell"; > > >> reg = <0x0 0x21f0000 0x0 0x1000>; > > >> interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; > > >> - current-speed = <115200>; > > >> status = "disabled"; > > >> }; > > >> > > >> -- > > >> 2.25.1 > > >> > > > > > > . > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART 2021-08-09 22:52 ` Leo Li 2021-08-10 1:28 ` Leizhen (ThunderTown) @ 2021-08-14 4:47 ` Shawn Guo 1 sibling, 0 replies; 8+ messages in thread From: Shawn Guo @ 2021-08-14 4:47 UTC (permalink / raw) To: Leo Li Cc: Zhen Lei, Rob Herring, Mark Kettenis, devicetree, linux-arm-kernel, linux-kernel On Mon, Aug 09, 2021 at 10:52:04PM +0000, Leo Li wrote: > > > > -----Original Message----- > > From: Zhen Lei <thunder.leizhen@huawei.com> > > Sent: Tuesday, June 15, 2021 8:16 AM > > To: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob > > Herring <robh+dt@kernel.org>; Mark Kettenis <mark.kettenis@xs4all.nl>; > > devicetree <devicetree@vger.kernel.org>; linux-arm-kernel <linux-arm- > > kernel@lists.infradead.org>; linux-kernel <linux-kernel@vger.kernel.org> > > Cc: Zhen Lei <thunder.leizhen@huawei.com> > > Subject: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of > > LX2160A UART > > > > Mark Kettenis told us that: > > According to the NXP documentation, the LX2160A has a real PL011 UART. > > > > Therefore, rewrite it to the compatible string of pl011. The property "current- > > speed" specific to "arm,sbsa-uart" is also deleted. > > Sorry that I missed the discussion on the v1. But looks like this change breaks the LX2160 boot. The AMBA matching doesn't seem to work. And the console is not registered correctly. > > [ 0.639055] OF: amba_device_add() failed (-2) for /soc/serial@21c0000 > [ 0.645612] OF: amba_device_add() failed (-2) for /soc/serial@21d0000 Patch dropped. Shawn ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-08-14 4:47 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-06-15 13:16 [PATCH v2 0/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART Zhen Lei 2021-06-15 13:16 ` [PATCH v2 1/1] " Zhen Lei 2021-07-14 7:22 ` Shawn Guo 2021-08-09 22:52 ` Leo Li 2021-08-10 1:28 ` Leizhen (ThunderTown) 2021-08-10 3:38 ` Leo Li 2021-08-12 23:09 ` Li Yang 2021-08-14 4:47 ` Shawn Guo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).