* [PATCH] ASoC: fsl: add COMPILE_TEST for SND_SOC_FSL_ASRC
@ 2021-10-03 3:04 Randy Dunlap
2021-10-04 7:17 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2021-10-03 3:04 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Geert Uytterhoeven, Liam Girdwood, Mark Brown,
alsa-devel, Nicolin Chen, Xiubo Li, Sudip Mukherjee,
Shengjiu Wang, Fabio Estevam
Geert pointed out that since sound/soc has the soc_dummy_driver for
NO_DMA platforms, it is possible (desirable) to have drivers that
depend on HAS_DMA to alternately depend on COMPILE_TEST.
This means that SND_ATMEL_FSL_ASRC can depend on HAS_DMA || COMPIE_TEST.
Fixes: 121a01521b1e ("ASoC: fsl: fix build failure")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Cc: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Xiubo Li <Xiubo.Lee@gmail.com>
Cc: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: Fabio Estevam <festevam@gmail.com>
---
sound/soc/fsl/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20211001.orig/sound/soc/fsl/Kconfig
+++ linux-next-20211001/sound/soc/fsl/Kconfig
@@ -5,7 +5,7 @@ comment "Common SoC Audio options for Fr
config SND_SOC_FSL_ASRC
tristate "Asynchronous Sample Rate Converter (ASRC) module support"
- depends on HAS_DMA
+ depends on HAS_DMA || COMPILE_TEST
select REGMAP_MMIO
select SND_SOC_GENERIC_DMAENGINE_PCM
help
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: fsl: add COMPILE_TEST for SND_SOC_FSL_ASRC
2021-10-03 3:04 [PATCH] ASoC: fsl: add COMPILE_TEST for SND_SOC_FSL_ASRC Randy Dunlap
@ 2021-10-04 7:17 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-10-04 7:17 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Liam Girdwood, Mark Brown, alsa-devel,
Nicolin Chen, Xiubo Li, Sudip Mukherjee, Shengjiu Wang,
Fabio Estevam
Hi Randy,
On Sun, Oct 3, 2021 at 5:04 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Geert pointed out that since sound/soc has the soc_dummy_driver for
> NO_DMA platforms, it is possible (desirable) to have drivers that
> depend on HAS_DMA to alternately depend on COMPILE_TEST.
Actually I had never heard about the soc_dummy_driver before ;-)
I did know about the dummies in include/linux/dma-mapping.h.
> This means that SND_ATMEL_FSL_ASRC can depend on HAS_DMA || COMPIE_TEST.
COMPILE_TEST
> Fixes: 121a01521b1e ("ASoC: fsl: fix build failure")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> --- linux-next-20211001.orig/sound/soc/fsl/Kconfig
> +++ linux-next-20211001/sound/soc/fsl/Kconfig
> @@ -5,7 +5,7 @@ comment "Common SoC Audio options for Fr
>
> config SND_SOC_FSL_ASRC
> tristate "Asynchronous Sample Rate Converter (ASRC) module support"
> - depends on HAS_DMA
> + depends on HAS_DMA || COMPILE_TEST
> select REGMAP_MMIO
> select SND_SOC_GENERIC_DMAENGINE_PCM
> help
The actual change LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-04 7:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-03 3:04 [PATCH] ASoC: fsl: add COMPILE_TEST for SND_SOC_FSL_ASRC Randy Dunlap
2021-10-04 7:17 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).