linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] init: Make unknown command line param message clearer
@ 2021-10-12 21:35 Andrew Halaney
  2021-10-13  0:01 ` Steven Rostedt
  0 siblings, 1 reply; 11+ messages in thread
From: Andrew Halaney @ 2021-10-12 21:35 UTC (permalink / raw)
  To: akpm; +Cc: rostedt, bp, linux-kernel, Andrew Halaney

The prior message is confusing users, which is the exact opposite of the
goal. Try and make it clear (without needing to look at the kernel
source) that the message is indicating one of the following
situations:

 1. the param is misspelled
 2. the param is not valid due to the kernel configuration
 3. the param is intended for init but isn't after the '--'
    delineator on the command line

On that same topic, also make it clear that these params are passed to
init still despite not being after the delineator.

Fixes: 86d1919a4fb0 ("init: print out unknown kernel parameters")
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---

I'm not a huge fan of the wall of text this adds, but at the same time
I've had a few people come to me with confusion about the message and
concern that userspace isn't getting the params (not the case here, it's
just a cosmetic message). I'm open to better ideas on how to express
what I describe in the commit message, or if people think the message is
more confusing than useful a full revert would be ok with me too
(although I do think it is useful personally).

Thanks,
Andrew

 init/main.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/init/main.c b/init/main.c
index ee4d3e1b3eb9..8dc88c2386ee 100644
--- a/init/main.c
+++ b/init/main.c
@@ -925,6 +925,10 @@ static void __init print_unknown_bootoptions(void)
 	for (p = &envp_init[2]; *p; p++)
 		end += sprintf(end, " %s", *p);
 
+	pr_notice("The kernel command line has unknown parameters. They are either\n");
+	pr_notice("misspelled, not valid for the current kernel configuration,\n");
+	pr_notice("or are meant for init but are not after the '--' delineator. They will\n");
+	pr_notice("be passed to init along with those after '--' on the command line.\n");
 	pr_notice("Unknown command line parameters:%s\n", unknown_options);
 	memblock_free(unknown_options, len);
 }
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [PATCH] init: Make unknown command line param message clearer
@ 2021-10-13 22:35 Andrew Halaney
  2021-10-13 22:49 ` Randy Dunlap
  2021-10-13 23:12 ` Andrew Morton
  0 siblings, 2 replies; 11+ messages in thread
From: Andrew Halaney @ 2021-10-13 22:35 UTC (permalink / raw)
  To: akpm; +Cc: rostedt, bp, rdunlap, linux-kernel, Andrew Halaney

The prior message is confusing users, which is the exact opposite of the
goal. If the message is being seen, one of the following situations is
happening:

 1. the param is misspelled
 2. the param is not valid due to the kernel configuration
 3. the param is intended for init but isn't after the '--'
    delineator on the command line

To make that more clear to the user, explicitly mention "kernel command
line" and also note that the params are still passed to user space to
avoid causing any alarm over params intended for init.

Fixes: 86d1919a4fb0 ("init: print out unknown kernel parameters")
Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---

Here's v2 of this. I had to change the code a bit from what Steven
recommended to compile/look proper, but the intended format he had
suggested is still the same.

v1 -> v2:
 * Print a much more concise message

v1: https://lore.kernel.org/all/20211012213523.39801-1-ahalaney@redhat.com/

Thanks,
Andrew

 init/main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/init/main.c b/init/main.c
index ee4d3e1b3eb9..a286995449e2 100644
--- a/init/main.c
+++ b/init/main.c
@@ -925,7 +925,9 @@ static void __init print_unknown_bootoptions(void)
 	for (p = &envp_init[2]; *p; p++)
 		end += sprintf(end, " %s", *p);
 
-	pr_notice("Unknown command line parameters:%s\n", unknown_options);
+	/* Start at unknown_options[1] to skip the initial space */
+	pr_notice("Unknown kernel command line parameters \"%s\", will be passed to user space.\n",
+		&unknown_options[1]);
 	memblock_free(unknown_options, len);
 }
 
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-10-14 12:48 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-12 21:35 [PATCH] init: Make unknown command line param message clearer Andrew Halaney
2021-10-13  0:01 ` Steven Rostedt
2021-10-13  0:18   ` Randy Dunlap
2021-10-13  0:22     ` Steven Rostedt
2021-10-13 12:56     ` Andrew Halaney
2021-10-13 13:03       ` Steven Rostedt
2021-10-13 13:10         ` Borislav Petkov
2021-10-13 22:35 Andrew Halaney
2021-10-13 22:49 ` Randy Dunlap
2021-10-13 23:12 ` Andrew Morton
2021-10-14 12:47   ` Andrew Halaney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).