* [PATCH] random: Document add_hwgenerator_randomness() with other input functions
@ 2021-10-15 13:34 Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2021-10-15 13:34 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: akpm, linux-kernel, Mark Brown
The section at the top of random.c which documents the input functions
available does not document add_hwgenerator_randomness() which might lead
a reader to overlook it. Add a brief note about it.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/char/random.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 605969ed0f96..456a4f43d935 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -228,6 +228,14 @@
* particular randomness source. They do this by keeping track of the
* first and second order deltas of the event timings.
*
+ * There is also an interface for true hardware RNGs:
+ *
+ * void add_hwgenerator_randomness(const char *buffer, size_t count,
+ * size_t entropy);
+ *
+ * This will credit entropy as specified by the caller, if the entropy
+ * pool is full it will block until more entropy is needed.
+ *
* Ensuring unpredictability at system startup
* ============================================
*
--
2.30.2
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] random: Document add_hwgenerator_randomness() with other input functions
2021-12-01 17:44 Mark Brown
@ 2021-12-02 4:48 ` Jason A. Donenfeld
0 siblings, 0 replies; 13+ messages in thread
From: Jason A. Donenfeld @ 2021-12-02 4:48 UTC (permalink / raw)
To: Mark Brown; +Cc: tytso, akpm, linux-kernel, Randy Dunlap
Hi Mark,
On Wed, Dec 01, 2021 at 05:44:49PM +0000, Mark Brown wrote:
> The section at the top of random.c which documents the input functions
> available does not document add_hwgenerator_randomness() which might lead
> a reader to overlook it. Add a brief note about it.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>
> Ted, I've been sending this for almost two years at this point and
> you've not commented on it - if there's some issue please let me know.
Sorry for the delay. I've queued this up in my random tree now after
incorporating Randy's punctuation suggestion from two of the former
posts:
https://git.kernel.org/zx2c4/random-linux/c/91995de6b6dd91
This will transition through the various trees next time I send a pull.
Regards,
Jason
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] random: Document add_hwgenerator_randomness() with other input functions
@ 2021-12-01 17:44 Mark Brown
2021-12-02 4:48 ` Jason A. Donenfeld
0 siblings, 1 reply; 13+ messages in thread
From: Mark Brown @ 2021-12-01 17:44 UTC (permalink / raw)
To: tytso, akpm; +Cc: linux-kernel, Mark Brown
The section at the top of random.c which documents the input functions
available does not document add_hwgenerator_randomness() which might lead
a reader to overlook it. Add a brief note about it.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
Ted, I've been sending this for almost two years at this point and
you've not commented on it - if there's some issue please let me know.
drivers/char/random.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 35fcc09c0228..9192da308f87 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -228,6 +228,14 @@
* particular randomness source. They do this by keeping track of the
* first and second order deltas of the event timings.
*
+ * There is also an interface for true hardware RNGs:
+ *
+ * void add_hwgenerator_randomness(const char *buffer, size_t count,
+ * size_t entropy);
+ *
+ * This will credit entropy as specified by the caller, if the entropy
+ * pool is full it will block until more entropy is needed.
+ *
* Ensuring unpredictability at system startup
* ============================================
*
--
2.30.2
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] random: Document add_hwgenerator_randomness() with other input functions
@ 2021-11-15 17:42 Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2021-11-15 17:42 UTC (permalink / raw)
To: Theodore Ts'o, akpm; +Cc: linux-kernel, Mark Brown
The section at the top of random.c which documents the input functions
available does not document add_hwgenerator_randomness() which might lead
a reader to overlook it. Add a brief note about it.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/char/random.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 605969ed0f96..456a4f43d935 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -228,6 +228,14 @@
* particular randomness source. They do this by keeping track of the
* first and second order deltas of the event timings.
*
+ * There is also an interface for true hardware RNGs:
+ *
+ * void add_hwgenerator_randomness(const char *buffer, size_t count,
+ * size_t entropy);
+ *
+ * This will credit entropy as specified by the caller, if the entropy
+ * pool is full it will block until more entropy is needed.
+ *
* Ensuring unpredictability at system startup
* ============================================
*
--
2.30.2
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] random: Document add_hwgenerator_randomness() with other input functions
@ 2021-09-21 21:39 Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2021-09-21 21:39 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: linux-kernel, Mark Brown
The section at the top of random.c which documents the input functions
available does not document add_hwgenerator_randomness() which might lead
a reader to overlook it. Add a brief note about it.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/char/random.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 605969ed0f96..456a4f43d935 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -228,6 +228,14 @@
* particular randomness source. They do this by keeping track of the
* first and second order deltas of the event timings.
*
+ * There is also an interface for true hardware RNGs:
+ *
+ * void add_hwgenerator_randomness(const char *buffer, size_t count,
+ * size_t entropy);
+ *
+ * This will credit entropy as specified by the caller, if the entropy
+ * pool is full it will block until more entropy is needed.
+ *
* Ensuring unpredictability at system startup
* ============================================
*
--
2.20.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] random: Document add_hwgenerator_randomness() with other input functions
@ 2021-07-12 12:07 Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2021-07-12 12:07 UTC (permalink / raw)
To: tytso; +Cc: linux-kernel, akpm, Mark Brown
The section at the top of random.c which documents the input functions
available does not document add_hwgenerator_randomness() which might lead
a reader to overlook it. Add a brief note about it.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/char/random.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 605969ed0f96..456a4f43d935 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -228,6 +228,14 @@
* particular randomness source. They do this by keeping track of the
* first and second order deltas of the event timings.
*
+ * There is also an interface for true hardware RNGs:
+ *
+ * void add_hwgenerator_randomness(const char *buffer, size_t count,
+ * size_t entropy);
+ *
+ * This will credit entropy as specified by the caller, if the entropy
+ * pool is full it will block until more entropy is needed.
+ *
* Ensuring unpredictability at system startup
* ============================================
*
--
2.20.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] random: Document add_hwgenerator_randomness() with other input functions
@ 2021-05-11 17:29 Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2021-05-11 17:29 UTC (permalink / raw)
To: tytso; +Cc: linux-kernel, akpm, Mark Brown
The section at the top of random.c which documents the input functions
available does not document add_hwgenerator_randomness() which might lead
a reader to overlook it. Add a brief note about it.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/char/random.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 605969ed0f96..456a4f43d935 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -228,6 +228,14 @@
* particular randomness source. They do this by keeping track of the
* first and second order deltas of the event timings.
*
+ * There is also an interface for true hardware RNGs:
+ *
+ * void add_hwgenerator_randomness(const char *buffer, size_t count,
+ * size_t entropy);
+ *
+ * This will credit entropy as specified by the caller, if the entropy
+ * pool is full it will block until more entropy is needed.
+ *
* Ensuring unpredictability at system startup
* ============================================
*
--
2.20.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] random: Document add_hwgenerator_randomness() with other input functions
@ 2021-01-13 17:10 Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2021-01-13 17:10 UTC (permalink / raw)
To: tytso; +Cc: linux-kernel, Mark Brown
The section at the top of random.c which documents the input functions
available does not document add_hwgenerator_randomness() which might lead
a reader to overlook it. Add a brief note about it.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
This patch is almost a year old at this point...
drivers/char/random.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 5f3b8ac9d97b..3e17e04c3cef 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -228,6 +228,14 @@
* particular randomness source. They do this by keeping track of the
* first and second order deltas of the event timings.
*
+ * There is also an interface for true hardware RNGs:
+ *
+ * void add_hwgenerator_randomness(const char *buffer, size_t count,
+ * size_t entropy);
+ *
+ * This will credit entropy as specified by the caller, if the entropy
+ * pool is full it will block until more entropy is needed.
+ *
* Ensuring unpredictability at system startup
* ============================================
*
--
2.20.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] random: Document add_hwgenerator_randomness() with other input functions
@ 2020-07-01 17:15 Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2020-07-01 17:15 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: linux-kernel, Mark Brown
The section at the top of random.c which documents the input functions
available does not document add_hwgenerator_randomness() which might lead
a reader to overlook it. Add a brief note about it.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/char/random.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 2a41b21623ae..fc822842eb0e 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -228,6 +228,14 @@
* particular randomness source. They do this by keeping track of the
* first and second order deltas of the event timings.
*
+ * There is also an interface for true hardware RNGs:
+ *
+ * void add_hwgenerator_randomness(const char *buffer, size_t count,
+ * size_t entropy);
+ *
+ * This will credit entropy as specified by the caller, if the entropy
+ * pool is full it will block until more entropy is needed.
+ *
* Ensuring unpredictability at system startup
* ============================================
*
--
2.20.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] random: Document add_hwgenerator_randomness() with other input functions
2020-04-24 12:39 Mark Brown
@ 2020-04-24 16:03 ` Randy Dunlap
0 siblings, 0 replies; 13+ messages in thread
From: Randy Dunlap @ 2020-04-24 16:03 UTC (permalink / raw)
To: Mark Brown, Theodore Ts'o; +Cc: linux-kernel
On 4/24/20 5:39 AM, Mark Brown wrote:
> The section at the top of random.c which documents the input functions
> available does not document add_hwgenerator_randomness() which might lead
> a reader to overlook it. Add a brief note about it.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> drivers/char/random.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index 0d10e31fd342..ba2dc45bf718 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -228,6 +228,14 @@
> * particular randomness source. They do this by keeping track of the
> * first and second order deltas of the event timings.
> *
> + * There is also an interface for true hardware RNGs:
> + *
> + * void add_hwgenerator_randomness(const char *buffer, size_t count,
> + * size_t entropy);
> + *
> + * This will credit entropy as specified by the caller, if the entropy
Use a ';' or '.' instead of ','. (and "If" if a period is used)
> + * pool is full it will block until more entropy is needed.
> + *
> * Ensuring unpredictability at system startup
> * ============================================
> *
>
Otherwise looks good. Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] random: Document add_hwgenerator_randomness() with other input functions
@ 2020-04-24 12:39 Mark Brown
2020-04-24 16:03 ` Randy Dunlap
0 siblings, 1 reply; 13+ messages in thread
From: Mark Brown @ 2020-04-24 12:39 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: linux-kernel, Mark Brown
The section at the top of random.c which documents the input functions
available does not document add_hwgenerator_randomness() which might lead
a reader to overlook it. Add a brief note about it.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/char/random.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 0d10e31fd342..ba2dc45bf718 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -228,6 +228,14 @@
* particular randomness source. They do this by keeping track of the
* first and second order deltas of the event timings.
*
+ * There is also an interface for true hardware RNGs:
+ *
+ * void add_hwgenerator_randomness(const char *buffer, size_t count,
+ * size_t entropy);
+ *
+ * This will credit entropy as specified by the caller, if the entropy
+ * pool is full it will block until more entropy is needed.
+ *
* Ensuring unpredictability at system startup
* ============================================
*
--
2.20.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] random: Document add_hwgenerator_randomness() with other input functions
2020-01-24 13:41 Mark Brown
@ 2020-01-24 20:23 ` Randy Dunlap
0 siblings, 0 replies; 13+ messages in thread
From: Randy Dunlap @ 2020-01-24 20:23 UTC (permalink / raw)
To: Mark Brown, Theodore Ts'o; +Cc: linux-kernel
On 1/24/20 5:41 AM, Mark Brown wrote:
> The section at the top of random.c which documents the input functions
> available does not document add_hwgenerator_randomness() which might lead
> a reader to overlook it. Add a brief note about it.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> drivers/char/random.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index c7f9584de2c8..16070c36add3 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -228,6 +228,14 @@
> * particular randomness source. They do this by keeping track of the
> * first and second order deltas of the event timings.
> *
> + * There is also an interface for true hardware RNGs:
> + *
> + * void add_hwgenerator_randomness(const char *buffer, size_t count,
> + * size_t entropy);
> + *
> + * This will credit entropy as specified by the caller, if the entropy
Not a comma there. Either a ';' or "caller. If ..."
> + * pool is full it will block until more entropy is needed.
> + *
> * Ensuring unpredictability at system startup
> * ============================================
> *
>
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] random: Document add_hwgenerator_randomness() with other input functions
@ 2020-01-24 13:41 Mark Brown
2020-01-24 20:23 ` Randy Dunlap
0 siblings, 1 reply; 13+ messages in thread
From: Mark Brown @ 2020-01-24 13:41 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: linux-kernel, Mark Brown
The section at the top of random.c which documents the input functions
available does not document add_hwgenerator_randomness() which might lead
a reader to overlook it. Add a brief note about it.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/char/random.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index c7f9584de2c8..16070c36add3 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -228,6 +228,14 @@
* particular randomness source. They do this by keeping track of the
* first and second order deltas of the event timings.
*
+ * There is also an interface for true hardware RNGs:
+ *
+ * void add_hwgenerator_randomness(const char *buffer, size_t count,
+ * size_t entropy);
+ *
+ * This will credit entropy as specified by the caller, if the entropy
+ * pool is full it will block until more entropy is needed.
+ *
* Ensuring unpredictability at system startup
* ============================================
*
--
2.20.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2021-12-02 4:49 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 13:34 [PATCH] random: Document add_hwgenerator_randomness() with other input functions Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2021-12-01 17:44 Mark Brown
2021-12-02 4:48 ` Jason A. Donenfeld
2021-11-15 17:42 Mark Brown
2021-09-21 21:39 Mark Brown
2021-07-12 12:07 Mark Brown
2021-05-11 17:29 Mark Brown
2021-01-13 17:10 Mark Brown
2020-07-01 17:15 Mark Brown
2020-04-24 12:39 Mark Brown
2020-04-24 16:03 ` Randy Dunlap
2020-01-24 13:41 Mark Brown
2020-01-24 20:23 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).