* [PATCH] arm64: extable: remove unsed ex_handler_t definition
@ 2021-11-18 12:02 Jisheng Zhang
2021-11-18 15:13 ` Mark Rutland
0 siblings, 1 reply; 2+ messages in thread
From: Jisheng Zhang @ 2021-11-18 12:02 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, Mark Rutland, linux-arm-kernel,
linux-kernel
From: Jisheng Zhang <jszhang@kernel.org>
The type ex_handler_t is defined but not used, remove it.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
arch/arm64/mm/extable.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm64/mm/extable.c b/arch/arm64/mm/extable.c
index c3d53811a15e..c0181e60cc98 100644
--- a/arch/arm64/mm/extable.c
+++ b/arch/arm64/mm/extable.c
@@ -10,9 +10,6 @@
#include <asm/asm-extable.h>
#include <asm/ptrace.h>
-typedef bool (*ex_handler_t)(const struct exception_table_entry *,
- struct pt_regs *);
-
static inline unsigned long
get_ex_fixup(const struct exception_table_entry *ex)
{
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: extable: remove unsed ex_handler_t definition
2021-11-18 12:02 [PATCH] arm64: extable: remove unsed ex_handler_t definition Jisheng Zhang
@ 2021-11-18 15:13 ` Mark Rutland
0 siblings, 0 replies; 2+ messages in thread
From: Mark Rutland @ 2021-11-18 15:13 UTC (permalink / raw)
To: Jisheng Zhang
Cc: Catalin Marinas, Will Deacon, linux-arm-kernel, linux-kernel
On Thu, Nov 18, 2021 at 08:02:49PM +0800, Jisheng Zhang wrote:
> From: Jisheng Zhang <jszhang@kernel.org>
>
> The type ex_handler_t is defined but not used, remove it.
It's probably worth saying:
| The ex_handler_t type was introduced in commit:
|
| d6e2cc5647753825 ("arm64: extable: add `type` and `data` fields")
|
| ... but has never been used, and is unnecessary. Remove it.
... as this was a leftover from a prior version of that patch, and in
the form merged in mainline it was redundant becuase we moved to using
an enumerated type rather than a function pointer in the ex_table_entry.
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
With or without the wording above:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
> ---
> arch/arm64/mm/extable.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/mm/extable.c b/arch/arm64/mm/extable.c
> index c3d53811a15e..c0181e60cc98 100644
> --- a/arch/arm64/mm/extable.c
> +++ b/arch/arm64/mm/extable.c
> @@ -10,9 +10,6 @@
> #include <asm/asm-extable.h>
> #include <asm/ptrace.h>
>
> -typedef bool (*ex_handler_t)(const struct exception_table_entry *,
> - struct pt_regs *);
> -
> static inline unsigned long
> get_ex_fixup(const struct exception_table_entry *ex)
> {
> --
> 2.33.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-18 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-18 12:02 [PATCH] arm64: extable: remove unsed ex_handler_t definition Jisheng Zhang
2021-11-18 15:13 ` Mark Rutland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).