* [PATCH] staging: vt6655: drop off byRxMode var in device.h
@ 2021-12-19 18:20 Tommaso Merciai
2021-12-20 16:39 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Tommaso Merciai @ 2021-12-19 18:20 UTC (permalink / raw)
Cc: linuxfancy, tomm.merciai, Forest Bond, Greg Kroah-Hartman,
Alberto Merciai, Karolina Drobnik, Aldas Taraškevičius,
linux-staging, linux-kernel
Drop off unused variable byRxMode in device.h, this fix following
checkpatch.pl check:
CHECK: Avoid CamelCase: <byRxMode>
131: FILE: drivers/staging/vt6655/device.h:131:
unsigned char byRxMode
Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
---
drivers/staging/vt6655/device.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index 4706bde1ec1d..84b1dcf80e47 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -128,8 +128,6 @@ struct vnt_private {
u32 memaddr;
u32 ioaddr;
- unsigned char byRxMode;
-
spinlock_t lock;
volatile int iTDUsed[TYPE_MAXTD];
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vt6655: drop off byRxMode var in device.h
2021-12-19 18:20 [PATCH] staging: vt6655: drop off byRxMode var in device.h Tommaso Merciai
@ 2021-12-20 16:39 ` Greg Kroah-Hartman
2021-12-20 19:31 ` Tommaso Merciai
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2021-12-20 16:39 UTC (permalink / raw)
To: Tommaso Merciai
Cc: linuxfancy, Forest Bond, Alberto Merciai, Karolina Drobnik,
Aldas Taraškevičius, linux-staging, linux-kernel
On Sun, Dec 19, 2021 at 07:20:03PM +0100, Tommaso Merciai wrote:
> Drop off unused variable byRxMode in device.h, this fix following
> checkpatch.pl check:
>
> CHECK: Avoid CamelCase: <byRxMode>
> 131: FILE: drivers/staging/vt6655/device.h:131:
> unsigned char byRxMode
>
> Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
> ---
> drivers/staging/vt6655/device.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> index 4706bde1ec1d..84b1dcf80e47 100644
> --- a/drivers/staging/vt6655/device.h
> +++ b/drivers/staging/vt6655/device.h
> @@ -128,8 +128,6 @@ struct vnt_private {
> u32 memaddr;
> u32 ioaddr;
>
> - unsigned char byRxMode;
> -
> spinlock_t lock;
>
> volatile int iTDUsed[TYPE_MAXTD];
> --
> 2.25.1
>
>
Did you send this twice? What is the difference between the two
versions?
And you have trailing whitespace in the changelog for this message,
please fix.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vt6655: drop off byRxMode var in device.h
2021-12-20 16:39 ` Greg Kroah-Hartman
@ 2021-12-20 19:31 ` Tommaso Merciai
0 siblings, 0 replies; 3+ messages in thread
From: Tommaso Merciai @ 2021-12-20 19:31 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linuxfancy, Forest Bond, Alberto Merciai, Karolina Drobnik,
Aldas Taraškevičius, linux-staging, linux-kernel
On Mon, Dec 20, 2021 at 05:39:18PM +0100, Greg Kroah-Hartman wrote:
> On Sun, Dec 19, 2021 at 07:20:03PM +0100, Tommaso Merciai wrote:
> > Drop off unused variable byRxMode in device.h, this fix following
> > checkpatch.pl check:
> >
> > CHECK: Avoid CamelCase: <byRxMode>
> > 131: FILE: drivers/staging/vt6655/device.h:131:
> > unsigned char byRxMode
> >
> > Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
> > ---
> > drivers/staging/vt6655/device.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> > index 4706bde1ec1d..84b1dcf80e47 100644
> > --- a/drivers/staging/vt6655/device.h
> > +++ b/drivers/staging/vt6655/device.h
> > @@ -128,8 +128,6 @@ struct vnt_private {
> > u32 memaddr;
> > u32 ioaddr;
> >
> > - unsigned char byRxMode;
> > -
> > spinlock_t lock;
> >
> > volatile int iTDUsed[TYPE_MAXTD];
> > --
> > 2.25.1
> >
> >
>
> Did you send this twice? What is the difference between the two
> versions?
Hi Gregh,
I send twice for error, sorry.
>
> And you have trailing whitespace in the changelog for this message,
> please fix.
I'll fix and send v2.
>
> thanks,
>
> greg k-h
thanks,
tommaso
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-20 19:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-19 18:20 [PATCH] staging: vt6655: drop off byRxMode var in device.h Tommaso Merciai
2021-12-20 16:39 ` Greg Kroah-Hartman
2021-12-20 19:31 ` Tommaso Merciai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).