[PATCH] staging: vt6655: drop off byRxMode var in device.h

[PATCH] staging: vt6655: drop off byRxMode var in device.h

[Tommaso Merciai]

Drop off unused variable byRxMode in device.h, this fix following 
checkpatch.pl check:

CHECK: Avoid CamelCase: <byRxMode>
131: FILE: drivers/staging/vt6655/device.h:131:
	unsigned char byRxMode

Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
---
 drivers/staging/vt6655/device.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index 4706bde1ec1d..84b1dcf80e47 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -128,8 +128,6 @@ struct vnt_private {
 	u32                         memaddr;
 	u32                         ioaddr;
 
-	unsigned char byRxMode;
-
 	spinlock_t                  lock;
 
 	volatile int                iTDUsed[TYPE_MAXTD];
-- 
2.25.1

Re: [PATCH] staging: vt6655: drop off byRxMode var in device.h

[Greg Kroah-Hartman]

On Sun, Dec 19, 2021 at 07:20:03PM +0100, Tommaso Merciai wrote:
> Drop off unused variable byRxMode in device.h, this fix following 
> checkpatch.pl check:
> 
> CHECK: Avoid CamelCase: <byRxMode>
> 131: FILE: drivers/staging/vt6655/device.h:131:
> 	unsigned char byRxMode
> 
> Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
> ---
>  drivers/staging/vt6655/device.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> index 4706bde1ec1d..84b1dcf80e47 100644
> --- a/drivers/staging/vt6655/device.h
> +++ b/drivers/staging/vt6655/device.h
> @@ -128,8 +128,6 @@ struct vnt_private {
>  	u32                         memaddr;
>  	u32                         ioaddr;
>  
> -	unsigned char byRxMode;
> -
>  	spinlock_t                  lock;
>  
>  	volatile int                iTDUsed[TYPE_MAXTD];
> -- 
> 2.25.1
> 
> 

Did you send this twice?  What is the difference between the two
versions?

And you have trailing whitespace in the changelog for this message,
please fix.

thanks,

greg k-h

Re: [PATCH] staging: vt6655: drop off byRxMode var in device.h

[Tommaso Merciai]

On Mon, Dec 20, 2021 at 05:39:18PM +0100, Greg Kroah-Hartman wrote:
> On Sun, Dec 19, 2021 at 07:20:03PM +0100, Tommaso Merciai wrote:
> > Drop off unused variable byRxMode in device.h, this fix following 
> > checkpatch.pl check:
> > 
> > CHECK: Avoid CamelCase: <byRxMode>
> > 131: FILE: drivers/staging/vt6655/device.h:131:
> > 	unsigned char byRxMode
> > 
> > Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
> > ---
> >  drivers/staging/vt6655/device.h | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> > index 4706bde1ec1d..84b1dcf80e47 100644
> > --- a/drivers/staging/vt6655/device.h
> > +++ b/drivers/staging/vt6655/device.h
> > @@ -128,8 +128,6 @@ struct vnt_private {
> >  	u32                         memaddr;
> >  	u32                         ioaddr;
> >  
> > -	unsigned char byRxMode;
> > -
> >  	spinlock_t                  lock;
> >  
> >  	volatile int                iTDUsed[TYPE_MAXTD];
> > -- 
> > 2.25.1
> > 
> > 
> 
> Did you send this twice?  What is the difference between the two
> versions?

Hi Gregh,
I send twice for error, sorry.
> 
> And you have trailing whitespace in the changelog for this message,
> please fix.
I'll fix and send v2.

> 
> thanks,
> 
> greg k-h

thanks,
tommaso