* [PATCH 1/7] ARM: dts: ls1021a: remove unused num-viewport from pcie nodes
2021-12-29 16:02 [PATCH 0/7] arm/arm64: dts: Remove unused num-viewport from pcie node Jisheng Zhang
@ 2021-12-29 16:02 ` Jisheng Zhang
2021-12-29 16:02 ` [PATCH 2/7] arm64: dts: visconti: Remove unused num-viewport from pcie node Jisheng Zhang
` (6 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Jisheng Zhang @ 2021-12-29 16:02 UTC (permalink / raw)
To: Shawn Guo, Li Yang, Rob Herring, Krzysztof Kozlowski,
Russell King, Andrew Lunn, Sebastian Hesselbarth, Thierry Reding,
Jonathan Hunter, Kunihiko Hayashi, Masami Hiramatsu,
Nobuhiro Iwamatsu
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-samsung-soc,
linux-tegra
After commit 281f1f99cf3a("PCI: dwc: Detect number of iATU windows"),
the number of iATU windows is detected at runtime, what's more,
the 'num-viewport' property parsing has been removed, so remove the
unused num-viewport from pcie nodes.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
arch/arm/boot/dts/ls1021a.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index 2e69d6eab4d1..1adc1771b454 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -814,7 +814,6 @@ pcie@3400000 {
#address-cells = <3>;
#size-cells = <2>;
device_type = "pci";
- num-viewport = <6>;
bus-range = <0x0 0xff>;
ranges = <0x81000000 0x0 0x00000000 0x40 0x00010000 0x0 0x00010000>, /* downstream I/O */
<0x82000000 0x0 0x40000000 0x40 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
@@ -838,7 +837,6 @@ pcie@3500000 {
#address-cells = <3>;
#size-cells = <2>;
device_type = "pci";
- num-viewport = <6>;
bus-range = <0x0 0xff>;
ranges = <0x81000000 0x0 0x00000000 0x48 0x00010000 0x0 0x00010000>, /* downstream I/O */
<0x82000000 0x0 0x40000000 0x48 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/7] arm64: dts: visconti: Remove unused num-viewport from pcie node
2021-12-29 16:02 [PATCH 0/7] arm/arm64: dts: Remove unused num-viewport from pcie node Jisheng Zhang
2021-12-29 16:02 ` [PATCH 1/7] ARM: dts: ls1021a: remove unused num-viewport from pcie nodes Jisheng Zhang
@ 2021-12-29 16:02 ` Jisheng Zhang
2021-12-29 16:02 ` [PATCH 3/7] arm64: dts: uniphier: " Jisheng Zhang
` (5 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Jisheng Zhang @ 2021-12-29 16:02 UTC (permalink / raw)
To: Shawn Guo, Li Yang, Rob Herring, Krzysztof Kozlowski,
Russell King, Andrew Lunn, Sebastian Hesselbarth, Thierry Reding,
Jonathan Hunter, Kunihiko Hayashi, Masami Hiramatsu,
Nobuhiro Iwamatsu
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-samsung-soc,
linux-tegra
After commit 281f1f99cf3a("PCI: dwc: Detect number of iATU windows"),
the number of iATU windows is detected at runtime, what's more,
the 'num-viewport' property parsing has been removed, so remove the
unused num-viewport from pcie nodes.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
arch/arm64/boot/dts/toshiba/tmpv7708.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
index 01d7ee61ad25..7ecbfedc02b7 100644
--- a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
+++ b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
@@ -481,7 +481,6 @@ pcie: pcie@28400000 {
device_type = "pci";
bus-range = <0x00 0xff>;
num-lanes = <2>;
- num-viewport = <8>;
#address-cells = <3>;
#size-cells = <2>;
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 3/7] arm64: dts: uniphier: Remove unused num-viewport from pcie node
2021-12-29 16:02 [PATCH 0/7] arm/arm64: dts: Remove unused num-viewport from pcie node Jisheng Zhang
2021-12-29 16:02 ` [PATCH 1/7] ARM: dts: ls1021a: remove unused num-viewport from pcie nodes Jisheng Zhang
2021-12-29 16:02 ` [PATCH 2/7] arm64: dts: visconti: Remove unused num-viewport from pcie node Jisheng Zhang
@ 2021-12-29 16:02 ` Jisheng Zhang
2021-12-29 16:02 ` [PATCH 4/7] arm64: tegra: " Jisheng Zhang
` (4 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Jisheng Zhang @ 2021-12-29 16:02 UTC (permalink / raw)
To: Shawn Guo, Li Yang, Rob Herring, Krzysztof Kozlowski,
Russell King, Andrew Lunn, Sebastian Hesselbarth, Thierry Reding,
Jonathan Hunter, Kunihiko Hayashi, Masami Hiramatsu,
Nobuhiro Iwamatsu
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-samsung-soc,
linux-tegra
After commit 281f1f99cf3a("PCI: dwc: Detect number of iATU windows"),
the number of iATU windows is detected at runtime, what's more,
the 'num-viewport' property parsing has been removed, so remove the
unused num-viewport from pcie nodes.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 1 -
arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi | 1 -
2 files changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
index 8f2c1c1e2c64..cc7a18591921 100644
--- a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
+++ b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
@@ -905,7 +905,6 @@ pcie: pcie@66000000 {
clocks = <&sys_clk 24>;
resets = <&sys_rst 24>;
num-lanes = <1>;
- num-viewport = <1>;
bus-range = <0x0 0xff>;
device_type = "pci";
ranges =
diff --git a/arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi b/arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi
index be97da132258..7646d14d1fa9 100644
--- a/arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi
+++ b/arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi
@@ -802,7 +802,6 @@ pcie: pcie@66000000 {
clocks = <&sys_clk 24>;
resets = <&sys_rst 24>;
num-lanes = <1>;
- num-viewport = <1>;
bus-range = <0x0 0xff>;
device_type = "pci";
ranges =
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 4/7] arm64: tegra: Remove unused num-viewport from pcie node
2021-12-29 16:02 [PATCH 0/7] arm/arm64: dts: Remove unused num-viewport from pcie node Jisheng Zhang
` (2 preceding siblings ...)
2021-12-29 16:02 ` [PATCH 3/7] arm64: dts: uniphier: " Jisheng Zhang
@ 2021-12-29 16:02 ` Jisheng Zhang
2021-12-29 16:02 ` [PATCH 5/7] arm64: dts: marvell: " Jisheng Zhang
` (3 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Jisheng Zhang @ 2021-12-29 16:02 UTC (permalink / raw)
To: Shawn Guo, Li Yang, Rob Herring, Krzysztof Kozlowski,
Russell King, Andrew Lunn, Sebastian Hesselbarth, Thierry Reding,
Jonathan Hunter, Kunihiko Hayashi, Masami Hiramatsu,
Nobuhiro Iwamatsu
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-samsung-soc,
linux-tegra
After commit 281f1f99cf3a("PCI: dwc: Detect number of iATU windows"),
the number of iATU windows is detected at runtime, what's more,
the 'num-viewport' property parsing has been removed, so remove the
unused num-viewport from pcie nodes.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
arch/arm64/boot/dts/nvidia/tegra194.dtsi | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
index 851e049b3519..e5c7c22b1c05 100644
--- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
@@ -2007,7 +2007,6 @@ pcie@14100000 {
#size-cells = <2>;
device_type = "pci";
num-lanes = <1>;
- num-viewport = <8>;
linux,pci-domain = <1>;
clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_1>;
@@ -2061,7 +2060,6 @@ pcie@14120000 {
#size-cells = <2>;
device_type = "pci";
num-lanes = <1>;
- num-viewport = <8>;
linux,pci-domain = <2>;
clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_2>;
@@ -2115,7 +2113,6 @@ pcie@14140000 {
#size-cells = <2>;
device_type = "pci";
num-lanes = <1>;
- num-viewport = <8>;
linux,pci-domain = <3>;
clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_3>;
@@ -2169,7 +2166,6 @@ pcie@14160000 {
#size-cells = <2>;
device_type = "pci";
num-lanes = <4>;
- num-viewport = <8>;
linux,pci-domain = <4>;
clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_4>;
@@ -2223,7 +2219,6 @@ pcie@14180000 {
#size-cells = <2>;
device_type = "pci";
num-lanes = <8>;
- num-viewport = <8>;
linux,pci-domain = <0>;
clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_0>;
@@ -2277,7 +2272,6 @@ pcie@141a0000 {
#size-cells = <2>;
device_type = "pci";
num-lanes = <8>;
- num-viewport = <8>;
linux,pci-domain = <5>;
pinctrl-names = "default";
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 5/7] arm64: dts: marvell: Remove unused num-viewport from pcie node
2021-12-29 16:02 [PATCH 0/7] arm/arm64: dts: Remove unused num-viewport from pcie node Jisheng Zhang
` (3 preceding siblings ...)
2021-12-29 16:02 ` [PATCH 4/7] arm64: tegra: " Jisheng Zhang
@ 2021-12-29 16:02 ` Jisheng Zhang
2021-12-29 16:02 ` [PATCH 6/7] arm64: dts: freescale: " Jisheng Zhang
` (2 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Jisheng Zhang @ 2021-12-29 16:02 UTC (permalink / raw)
To: Shawn Guo, Li Yang, Rob Herring, Krzysztof Kozlowski,
Russell King, Andrew Lunn, Sebastian Hesselbarth, Thierry Reding,
Jonathan Hunter, Kunihiko Hayashi, Masami Hiramatsu,
Nobuhiro Iwamatsu
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-samsung-soc,
linux-tegra
After commit 281f1f99cf3a("PCI: dwc: Detect number of iATU windows"),
the number of iATU windows is detected at runtime, what's more,
the 'num-viewport' property parsing has been removed, so remove the
unused num-viewport from pcie nodes.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 1 -
arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts | 1 -
arch/arm64/boot/dts/marvell/cn9130-crb-A.dts | 1 -
arch/arm64/boot/dts/marvell/cn9130-crb-B.dts | 1 -
arch/arm64/boot/dts/marvell/cn9130-db.dtsi | 1 -
arch/arm64/boot/dts/marvell/cn9131-db.dtsi | 1 -
arch/arm64/boot/dts/marvell/cn9132-db.dtsi | 2 --
7 files changed, 8 deletions(-)
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
index adbfecc678b5..860912e47732 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
@@ -180,7 +180,6 @@ &cp0_pcie0 {
pinctrl-names = "default";
pinctrl-0 = <&cp0_pcie_pins>;
num-lanes = <4>;
- num-viewport = <8>;
reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_LOW>;
ranges = <0x82000000 0x0 0xc0000000 0x0 0xc0000000 0x0 0x20000000>;
phys = <&cp0_comphy0 0>, <&cp0_comphy1 0>,
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts b/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts
index dac85fa748de..c5ba03c2194d 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts
@@ -330,7 +330,6 @@ &cp0_pcie0 {
pinctrl-names = "default";
pinctrl-0 = <&cp0_pcie_pins>;
num-lanes = <1>;
- num-viewport = <8>;
reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_LOW>;
ranges = <0x82000000 0x0 0xc0000000 0x0 0xc0000000 0x0 0x20000000>;
phys = <&cp0_comphy0 0>;
diff --git a/arch/arm64/boot/dts/marvell/cn9130-crb-A.dts b/arch/arm64/boot/dts/marvell/cn9130-crb-A.dts
index a7b6dfba8af5..ccb48d81604a 100644
--- a/arch/arm64/boot/dts/marvell/cn9130-crb-A.dts
+++ b/arch/arm64/boot/dts/marvell/cn9130-crb-A.dts
@@ -12,7 +12,6 @@ / {
&cp0_pcie0 {
status = "okay";
num-lanes = <4>;
- num-viewport = <8>;
/* Generic PHY, providing serdes lanes */
phys = <&cp0_comphy0 0
&cp0_comphy1 0
diff --git a/arch/arm64/boot/dts/marvell/cn9130-crb-B.dts b/arch/arm64/boot/dts/marvell/cn9130-crb-B.dts
index 0904cb0309ae..4c68c8c310ae 100644
--- a/arch/arm64/boot/dts/marvell/cn9130-crb-B.dts
+++ b/arch/arm64/boot/dts/marvell/cn9130-crb-B.dts
@@ -12,7 +12,6 @@ / {
&cp0_pcie0 {
status = "okay";
num-lanes = <1>;
- num-viewport = <8>;
/* Generic PHY, providing serdes lanes */
phys = <&cp0_comphy0 0>;
iommu-map =
diff --git a/arch/arm64/boot/dts/marvell/cn9130-db.dtsi b/arch/arm64/boot/dts/marvell/cn9130-db.dtsi
index c00b69b88bd2..54f40674808b 100644
--- a/arch/arm64/boot/dts/marvell/cn9130-db.dtsi
+++ b/arch/arm64/boot/dts/marvell/cn9130-db.dtsi
@@ -271,7 +271,6 @@ partition@1000000 {
&cp0_pcie0 {
status = "okay";
num-lanes = <4>;
- num-viewport = <8>;
/* Generic PHY, providing serdes lanes */
phys = <&cp0_comphy0 0
&cp0_comphy1 0
diff --git a/arch/arm64/boot/dts/marvell/cn9131-db.dtsi b/arch/arm64/boot/dts/marvell/cn9131-db.dtsi
index f995b1bcda01..ccf162fa751b 100644
--- a/arch/arm64/boot/dts/marvell/cn9131-db.dtsi
+++ b/arch/arm64/boot/dts/marvell/cn9131-db.dtsi
@@ -112,7 +112,6 @@ &cp1_pcie0 {
pinctrl-names = "default";
pinctrl-0 = <&cp1_pcie_reset_pins>;
num-lanes = <2>;
- num-viewport = <8>;
marvell,reset-gpio = <&cp1_gpio1 0 GPIO_ACTIVE_HIGH>;
status = "okay";
/* Generic PHY, providing serdes lanes */
diff --git a/arch/arm64/boot/dts/marvell/cn9132-db.dtsi b/arch/arm64/boot/dts/marvell/cn9132-db.dtsi
index 3f1795fb4fe7..be96d5f3398e 100644
--- a/arch/arm64/boot/dts/marvell/cn9132-db.dtsi
+++ b/arch/arm64/boot/dts/marvell/cn9132-db.dtsi
@@ -153,7 +153,6 @@ cp2_module_expander1: pca9555@21 {
&cp2_pcie0 {
status = "okay";
num-lanes = <2>;
- num-viewport = <8>;
/* Generic PHY, providing serdes lanes */
phys = <&cp2_comphy0 0
&cp2_comphy1 0>;
@@ -163,7 +162,6 @@ &cp2_pcie0 {
&cp2_pcie2 {
status = "okay";
num-lanes = <1>;
- num-viewport = <8>;
/* Generic PHY, providing serdes lanes */
phys = <&cp2_comphy5 2>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 6/7] arm64: dts: freescale: Remove unused num-viewport from pcie node
2021-12-29 16:02 [PATCH 0/7] arm/arm64: dts: Remove unused num-viewport from pcie node Jisheng Zhang
` (4 preceding siblings ...)
2021-12-29 16:02 ` [PATCH 5/7] arm64: dts: marvell: " Jisheng Zhang
@ 2021-12-29 16:02 ` Jisheng Zhang
2021-12-29 16:02 ` [PATCH 7/7] arm64: dts: exynos: " Jisheng Zhang
2021-12-29 16:50 ` [PATCH 0/7] arm/arm64: dts: " Mark Kettenis
7 siblings, 0 replies; 12+ messages in thread
From: Jisheng Zhang @ 2021-12-29 16:02 UTC (permalink / raw)
To: Shawn Guo, Li Yang, Rob Herring, Krzysztof Kozlowski,
Russell King, Andrew Lunn, Sebastian Hesselbarth, Thierry Reding,
Jonathan Hunter, Kunihiko Hayashi, Masami Hiramatsu,
Nobuhiro Iwamatsu
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-samsung-soc,
linux-tegra
After commit 281f1f99cf3a("PCI: dwc: Detect number of iATU windows"),
the number of iATU windows is detected at runtime, what's more,
the 'num-viewport' property parsing has been removed, so remove the
unused num-viewport from pcie nodes.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 -
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 --
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 3 ---
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 ---
arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 3 ---
arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 4 ----
6 files changed, 16 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
index 50a72cda4727..13e57f34ca5b 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
@@ -531,7 +531,6 @@ pcie1: pcie@3400000 {
#address-cells = <3>;
#size-cells = <2>;
device_type = "pci";
- num-viewport = <2>;
bus-range = <0x0 0xff>;
ranges = <0x81000000 0x0 0x00000000 0x40 0x00010000 0x0 0x00010000 /* downstream I/O */
0x82000000 0x0 0x40000000 0x40 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index fd3f3e8bb6ce..ac6e1f795bc9 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -622,7 +622,6 @@ pcie1: pcie@3400000 {
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- num-viewport = <8>;
bus-range = <0x0 0xff>;
ranges = <0x81000000 0x0 0x00000000 0x80 0x00010000 0x0 0x00010000 /* downstream I/O */
0x82000000 0x0 0x40000000 0x80 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
@@ -649,7 +648,6 @@ pcie2: pcie@3500000 {
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- num-viewport = <8>;
bus-range = <0x0 0xff>;
ranges = <0x81000000 0x0 0x00000000 0x88 0x00010000 0x0 0x00010000 /* downstream I/O */
0x82000000 0x0 0x40000000 0x88 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index 01b01e320411..a8d1db620497 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -879,7 +879,6 @@ pcie1: pcie@3400000 {
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- num-viewport = <6>;
bus-range = <0x0 0xff>;
ranges = <0x81000000 0x0 0x00000000 0x40 0x00010000 0x0 0x00010000 /* downstream I/O */
0x82000000 0x0 0x40000000 0x40 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
@@ -905,7 +904,6 @@ pcie2: pcie@3500000 {
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- num-viewport = <6>;
bus-range = <0x0 0xff>;
ranges = <0x81000000 0x0 0x00000000 0x48 0x00010000 0x0 0x00010000 /* downstream I/O */
0x82000000 0x0 0x40000000 0x48 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
@@ -931,7 +929,6 @@ pcie3: pcie@3600000 {
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- num-viewport = <6>;
bus-range = <0x0 0xff>;
ranges = <0x81000000 0x0 0x00000000 0x50 0x00010000 0x0 0x00010000 /* downstream I/O */
0x82000000 0x0 0x40000000 0x50 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 687fea6d8afa..8c3166afe737 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -783,7 +783,6 @@ pcie1: pcie@3400000 {
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- num-viewport = <8>;
bus-range = <0x0 0xff>;
ranges = <0x81000000 0x0 0x00000000 0x40 0x00010000 0x0 0x00010000 /* downstream I/O */
0x82000000 0x0 0x40000000 0x40 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
@@ -819,7 +818,6 @@ pcie2: pcie@3500000 {
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- num-viewport = <8>;
bus-range = <0x0 0xff>;
ranges = <0x81000000 0x0 0x00000000 0x48 0x00010000 0x0 0x00010000 /* downstream I/O */
0x82000000 0x0 0x40000000 0x48 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
@@ -855,7 +853,6 @@ pcie3: pcie@3600000 {
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- num-viewport = <8>;
bus-range = <0x0 0xff>;
ranges = <0x81000000 0x0 0x00000000 0x50 0x00010000 0x0 0x00010000 /* downstream I/O */
0x82000000 0x0 0x40000000 0x50 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
index f891ef6a3754..cfed82908e7f 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
@@ -550,7 +550,6 @@ pcie1: pcie@3400000 {
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- num-viewport = <256>;
bus-range = <0x0 0xff>;
ranges = <0x81000000 0x0 0x00000000 0x20 0x00010000 0x0 0x00010000 /* downstream I/O */
0x82000000 0x0 0x40000000 0x20 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
@@ -587,7 +586,6 @@ pcie2: pcie@3500000 {
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- num-viewport = <6>;
bus-range = <0x0 0xff>;
ranges = <0x81000000 0x0 0x00000000 0x28 0x00010000 0x0 0x00010000 /* downstream I/O */
0x82000000 0x0 0x40000000 0x28 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
@@ -623,7 +621,6 @@ pcie3: pcie@3600000 {
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- num-viewport = <6>;
bus-range = <0x0 0xff>;
ranges = <0x81000000 0x0 0x00000000 0x30 0x00010000 0x0 0x00010000 /* downstream I/O */
0x82000000 0x0 0x40000000 0x30 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
index 3cb9c21d2775..5bd651454705 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
@@ -1074,7 +1074,6 @@ pcie1: pcie@3400000 {
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- num-viewport = <6>;
bus-range = <0x0 0xff>;
msi-parent = <&its>;
#interrupt-cells = <1>;
@@ -1096,7 +1095,6 @@ pcie2: pcie@3500000 {
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- num-viewport = <6>;
bus-range = <0x0 0xff>;
msi-parent = <&its>;
#interrupt-cells = <1>;
@@ -1118,7 +1116,6 @@ pcie3: pcie@3600000 {
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- num-viewport = <256>;
bus-range = <0x0 0xff>;
msi-parent = <&its>;
#interrupt-cells = <1>;
@@ -1140,7 +1137,6 @@ pcie4: pcie@3700000 {
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- num-viewport = <6>;
bus-range = <0x0 0xff>;
msi-parent = <&its>;
#interrupt-cells = <1>;
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 7/7] arm64: dts: exynos: Remove unused num-viewport from pcie node
2021-12-29 16:02 [PATCH 0/7] arm/arm64: dts: Remove unused num-viewport from pcie node Jisheng Zhang
` (5 preceding siblings ...)
2021-12-29 16:02 ` [PATCH 6/7] arm64: dts: freescale: " Jisheng Zhang
@ 2021-12-29 16:02 ` Jisheng Zhang
2021-12-29 16:50 ` [PATCH 0/7] arm/arm64: dts: " Mark Kettenis
7 siblings, 0 replies; 12+ messages in thread
From: Jisheng Zhang @ 2021-12-29 16:02 UTC (permalink / raw)
To: Shawn Guo, Li Yang, Rob Herring, Krzysztof Kozlowski,
Russell King, Andrew Lunn, Sebastian Hesselbarth, Thierry Reding,
Jonathan Hunter, Kunihiko Hayashi, Masami Hiramatsu,
Nobuhiro Iwamatsu
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-samsung-soc,
linux-tegra
After commit 281f1f99cf3a("PCI: dwc: Detect number of iATU windows"),
the number of iATU windows is detected at runtime, what's more,
the 'num-viewport' property parsing has been removed, so remove the
unused num-viewport from pcie nodes.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 4422021cf4b2..8d65a4115c47 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -1960,7 +1960,6 @@ pcie: pcie@15700000 {
<&cmu_fsys CLK_PCLK_PCIE_PHY>;
clock-names = "pcie", "pcie_bus";
num-lanes = <1>;
- num-viewport = <3>;
bus-range = <0x00 0xff>;
phys = <&pcie_phy>;
ranges = <0x81000000 0 0 0x0c001000 0 0x00010000>,
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 0/7] arm/arm64: dts: Remove unused num-viewport from pcie node
2021-12-29 16:02 [PATCH 0/7] arm/arm64: dts: Remove unused num-viewport from pcie node Jisheng Zhang
` (6 preceding siblings ...)
2021-12-29 16:02 ` [PATCH 7/7] arm64: dts: exynos: " Jisheng Zhang
@ 2021-12-29 16:50 ` Mark Kettenis
2022-01-07 12:47 ` Krzysztof Kozlowski
7 siblings, 1 reply; 12+ messages in thread
From: Mark Kettenis @ 2021-12-29 16:50 UTC (permalink / raw)
To: Jisheng Zhang
Cc: shawnguo, leoyang.li, robh+dt, krzysztof.kozlowski, linux,
andrew, sebastian.hesselbarth, thierry.reding, jonathanh,
hayashi.kunihiko, mhiramat, nobuhiro1.iwamatsu, linux-arm-kernel,
devicetree, linux-kernel, linux-samsung-soc, linux-tegra
> From: Jisheng Zhang <jszhang@kernel.org>
> Date: Thu, 30 Dec 2021 00:02:38 +0800
>
> After commit 281f1f99cf3a("PCI: dwc: Detect number of iATU windows"),
> the number of iATU windows is detected at runtime, what's more,
> the 'num-viewport' property parsing has been removed, so remove the
> unused num-viewport from pcie node(s).
>
> It's too late for linux-5.17-rc1, I will rebase and send out v2 if
> necessary when 5.17-rc1 is released.
Please no. This only makes the device trees unnecessarily
incompatible with older kernels and other OSes that do rely on the
"num-viewport" property. It really doesn't hurt to keep this property
even if future Linux kernels no longer look at it.
Thanks,
Mark
> Jisheng Zhang (7):
> ARM: dts: ls1021a: remove unused num-viewport from pcie nodes
> arm64: dts: visconti: Remove unused num-viewport from pcie node
> arm64: dts: uniphier: Remove unused num-viewport from pcie node
> arm64: tegra: Remove unused num-viewport from pcie node
> arm64: dts: marvell: Remove unused num-viewport from pcie node
> arm64: dts: freescale: Remove unused num-viewport from pcie node
> arm64: dts: exynos: Remove unused num-viewport from pcie node
>
> arch/arm/boot/dts/ls1021a.dtsi | 2 --
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 1 -
> arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 -
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 --
> arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 3 ---
> arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 ---
> arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 3 ---
> arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 4 ----
> arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 1 -
> arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts | 1 -
> arch/arm64/boot/dts/marvell/cn9130-crb-A.dts | 1 -
> arch/arm64/boot/dts/marvell/cn9130-crb-B.dts | 1 -
> arch/arm64/boot/dts/marvell/cn9130-db.dtsi | 1 -
> arch/arm64/boot/dts/marvell/cn9131-db.dtsi | 1 -
> arch/arm64/boot/dts/marvell/cn9132-db.dtsi | 2 --
> arch/arm64/boot/dts/nvidia/tegra194.dtsi | 6 ------
> arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 1 -
> arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi | 1 -
> arch/arm64/boot/dts/toshiba/tmpv7708.dtsi | 1 -
> 19 files changed, 36 deletions(-)
>
> --
> 2.34.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/7] arm/arm64: dts: Remove unused num-viewport from pcie node
2021-12-29 16:50 ` [PATCH 0/7] arm/arm64: dts: " Mark Kettenis
@ 2022-01-07 12:47 ` Krzysztof Kozlowski
2022-01-07 19:39 ` Mark Kettenis
0 siblings, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-01-07 12:47 UTC (permalink / raw)
To: Mark Kettenis, Jisheng Zhang
Cc: shawnguo, leoyang.li, robh+dt, linux, andrew,
sebastian.hesselbarth, thierry.reding, jonathanh,
hayashi.kunihiko, mhiramat, nobuhiro1.iwamatsu, linux-arm-kernel,
devicetree, linux-kernel, linux-samsung-soc, linux-tegra
On 29/12/2021 17:50, Mark Kettenis wrote:
>> From: Jisheng Zhang <jszhang@kernel.org>
>> Date: Thu, 30 Dec 2021 00:02:38 +0800
>>
>> After commit 281f1f99cf3a("PCI: dwc: Detect number of iATU windows"),
>> the number of iATU windows is detected at runtime, what's more,
>> the 'num-viewport' property parsing has been removed, so remove the
>> unused num-viewport from pcie node(s).
>>
>> It's too late for linux-5.17-rc1, I will rebase and send out v2 if
>> necessary when 5.17-rc1 is released.
>
> Please no. This only makes the device trees unnecessarily
> incompatible with older kernels
Anyone who is running a new DTB with older kernel is doomed anyway, not
only because of this change but hundreds of other similar cleanups, e.g.
making DTS conforming to dtschema. Are you sure there are such use cases
of using new DTB with old kernel? I cannot imagine making a stable
product with such scenario...
> and other OSes that do rely on the
> "num-viewport" property.
Right. We should have move the DTS out of the kernel when it was still
small. :)
> It really doesn't hurt to keep this property
> even if future Linux kernels no longer look at it.
For Exynos PCIe, the property is still required by bindings, so
definitely it cannot be removed from DTS. I did not check the other
bindings.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/7] arm/arm64: dts: Remove unused num-viewport from pcie node
2022-01-07 12:47 ` Krzysztof Kozlowski
@ 2022-01-07 19:39 ` Mark Kettenis
2022-01-10 9:21 ` Krzysztof Kozlowski
0 siblings, 1 reply; 12+ messages in thread
From: Mark Kettenis @ 2022-01-07 19:39 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: jszhang, shawnguo, leoyang.li, robh+dt, linux, andrew,
sebastian.hesselbarth, thierry.reding, jonathanh,
hayashi.kunihiko, mhiramat, nobuhiro1.iwamatsu, linux-arm-kernel,
devicetree, linux-kernel, linux-samsung-soc, linux-tegra
> Date: Fri, 7 Jan 2022 13:47:03 +0100
> From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> On 29/12/2021 17:50, Mark Kettenis wrote:
> >> From: Jisheng Zhang <jszhang@kernel.org>
> >> Date: Thu, 30 Dec 2021 00:02:38 +0800
> >>
> >> After commit 281f1f99cf3a("PCI: dwc: Detect number of iATU windows"),
> >> the number of iATU windows is detected at runtime, what's more,
> >> the 'num-viewport' property parsing has been removed, so remove the
> >> unused num-viewport from pcie node(s).
> >>
> >> It's too late for linux-5.17-rc1, I will rebase and send out v2 if
> >> necessary when 5.17-rc1 is released.
> >
> > Please no. This only makes the device trees unnecessarily
> > incompatible with older kernels
>
> Anyone who is running a new DTB with older kernel is doomed anyway, not
> only because of this change but hundreds of other similar cleanups, e.g.
> making DTS conforming to dtschema. Are you sure there are such use cases
> of using new DTB with old kernel? I cannot imagine making a stable
> product with such scenario...
Well, many of those changes just affect the node names, which aren't
part of the ABI. And adding missing properties or compatibles doesn't
break things either. But yes, we keep seeing diffs to "cleanup"
bindings and device trees, especially in the context of converting
them to dtschema. And that's just wrong. If old device trees don't
pass validation, the default assumption should be that the schema is
wrong; not the other way around.
> > and other OSes that do rely on the
> > "num-viewport" property.
>
> Right. We should have move the DTS out of the kernel when it was still
> small. :)
I don't think the number/size of DTs really matters. But yes, moving
them to a separate repository would certainly make it more obvious
that they should not be tied to a particular kernel version and that
they are shared with other projects such as U-Boot and other OSes.
> > It really doesn't hurt to keep this property
> > even if future Linux kernels no longer look at it.
>
> For Exynos PCIe, the property is still required by bindings, so
> definitely it cannot be removed from DTS. I did not check the other
> bindings.
>
> Best regards,
> Krzysztof
Cheers,
Mark
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/7] arm/arm64: dts: Remove unused num-viewport from pcie node
2022-01-07 19:39 ` Mark Kettenis
@ 2022-01-10 9:21 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-01-10 9:21 UTC (permalink / raw)
To: Mark Kettenis
Cc: jszhang, shawnguo, leoyang.li, robh+dt, linux, andrew,
sebastian.hesselbarth, thierry.reding, jonathanh,
hayashi.kunihiko, mhiramat, nobuhiro1.iwamatsu, linux-arm-kernel,
devicetree, linux-kernel, linux-samsung-soc, linux-tegra
On 07/01/2022 20:39, Mark Kettenis wrote:
>> Date: Fri, 7 Jan 2022 13:47:03 +0100
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>
>> On 29/12/2021 17:50, Mark Kettenis wrote:
>>>> From: Jisheng Zhang <jszhang@kernel.org>
>>>> Date: Thu, 30 Dec 2021 00:02:38 +0800
>>>>
>>>> After commit 281f1f99cf3a("PCI: dwc: Detect number of iATU windows"),
>>>> the number of iATU windows is detected at runtime, what's more,
>>>> the 'num-viewport' property parsing has been removed, so remove the
>>>> unused num-viewport from pcie node(s).
>>>>
>>>> It's too late for linux-5.17-rc1, I will rebase and send out v2 if
>>>> necessary when 5.17-rc1 is released.
>>>
>>> Please no. This only makes the device trees unnecessarily
>>> incompatible with older kernels
>>
>> Anyone who is running a new DTB with older kernel is doomed anyway, not
>> only because of this change but hundreds of other similar cleanups, e.g.
>> making DTS conforming to dtschema. Are you sure there are such use cases
>> of using new DTB with old kernel? I cannot imagine making a stable
>> product with such scenario...
>
> Well, many of those changes just affect the node names, which aren't
> part of the ABI. And adding missing properties or compatibles doesn't
> break things either. But yes, we keep seeing diffs to "cleanup"
> bindings and device trees, especially in the context of converting
> them to dtschema. And that's just wrong. If old device trees don't
> pass validation, the default assumption should be that the schema is
> wrong; not the other way around.
I cannot get how you reached a conclusion that old device tree could be
good, but old bindings would be bad... Both were developed without
consistency, sometimes without proper review. Simply both can be wrong
and now we fix them - the bindings by converting to stricter schema and
DTS files by aligning them with new schema.
There was never a contract between us and users that OLD kernel will
work with NEW DTB. The only contract we made was the other way around -
NEW kernel will work with OLD DTB.
I understand that it is useful to have new DTB working with old kernel.
I consider it as a "nice to have" feature but:
1. Still there are no real users of such pattern (new DTB with old
kernel), around Linux kernel. If they are - I am repaeting - their Linux
project is already broken.
2. If Linux drivers or other projects depend on node names and anything
not being part of bindings (the ABI), they are broken by design. They
should either be fixed or accept that might get broken anytime soon
because they do not use bindings but undocumented parts (which are not ABI).
3. "Nice to have" should not stop us in improving out codebase and
making it easier to maintain for us. We do not make these "dtschema
align" changes for pure fun, but to make everything easier for us in the
longterm. The dtschema checks I was running (and converting to dtschema)
already found errors in DTS. These are real bugs which are fixed by this
stricter dtschema.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread