* [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls
@ 2022-01-27 1:44 cgel.zte
2022-01-27 12:35 ` Stefan Wahren
0 siblings, 1 reply; 4+ messages in thread
From: cgel.zte @ 2022-01-27 1:44 UTC (permalink / raw)
To: nsaenz
Cc: rdunlap, unixbhaskar, stefan.wahren, dave.stevenson,
bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel,
linux-staging, linux-kernel, Minghao Chi (CGEL ZTE),
Zeal Robot, CGEL ZTE
From: "Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn>
'destroy_workqueue()' already drains the queue before destroying it,
so there is no need to flush it explicitly.
Remove the redundant 'flush_workqueue()' calls.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
---
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
index 76d3f0399964..60305c63c6f6 100644
--- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
+++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
@@ -1844,7 +1844,6 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance)
mutex_unlock(&instance->vchiq_mutex);
vchiq_shutdown(instance->vchiq_instance);
- flush_workqueue(instance->bulk_wq);
destroy_workqueue(instance->bulk_wq);
vfree(instance->bulk_scratch);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls
2022-01-27 1:44 [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls cgel.zte
@ 2022-01-27 12:35 ` Stefan Wahren
2022-01-28 7:03 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Wahren @ 2022-01-27 12:35 UTC (permalink / raw)
To: cgel.zte, nsaenz
Cc: rdunlap, unixbhaskar, dave.stevenson, bcm-kernel-feedback-list,
linux-rpi-kernel, linux-arm-kernel, linux-staging, linux-kernel,
Minghao Chi (CGEL ZTE),
Zeal Robot
Hi,
Am 27.01.22 um 02:44 schrieb cgel.zte@gmail.com:
> From: "Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn>
>
> 'destroy_workqueue()' already drains the queue before destroying it,
> so there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
are you sure that drain_workqueue() is the same as flush_workqueue()?
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
> ---
> drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> index 76d3f0399964..60305c63c6f6 100644
> --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> @@ -1844,7 +1844,6 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance)
> mutex_unlock(&instance->vchiq_mutex);
>
> vchiq_shutdown(instance->vchiq_instance);
> - flush_workqueue(instance->bulk_wq);
> destroy_workqueue(instance->bulk_wq);
>
> vfree(instance->bulk_scratch);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls
2022-01-27 12:35 ` Stefan Wahren
@ 2022-01-28 7:03 ` Dan Carpenter
2022-01-28 11:51 ` Stefan Wahren
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2022-01-28 7:03 UTC (permalink / raw)
To: Stefan Wahren
Cc: cgel.zte, nsaenz, rdunlap, unixbhaskar, dave.stevenson,
bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel,
linux-staging, linux-kernel, Minghao Chi (CGEL ZTE),
Zeal Robot
On Thu, Jan 27, 2022 at 01:35:09PM +0100, Stefan Wahren wrote:
> Hi,
>
> Am 27.01.22 um 02:44 schrieb cgel.zte@gmail.com:
> > From: "Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn>
> >
> > 'destroy_workqueue()' already drains the queue before destroying it,
> > so there is no need to flush it explicitly.
> >
> > Remove the redundant 'flush_workqueue()' calls.
> are you sure that drain_workqueue() is the same as flush_workqueue()?
drain_workqueue() calls flush_workqueue() repeatedly.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls
2022-01-28 7:03 ` Dan Carpenter
@ 2022-01-28 11:51 ` Stefan Wahren
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Wahren @ 2022-01-28 11:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: cgel.zte, nsaenz, rdunlap, unixbhaskar, dave.stevenson,
bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel,
linux-staging, linux-kernel, Minghao Chi (CGEL ZTE),
Zeal Robot
Am 28.01.22 um 08:03 schrieb Dan Carpenter:
> On Thu, Jan 27, 2022 at 01:35:09PM +0100, Stefan Wahren wrote:
>> Hi,
>>
>> Am 27.01.22 um 02:44 schrieb cgel.zte@gmail.com:
>>> From: "Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn>
>>>
>>> 'destroy_workqueue()' already drains the queue before destroying it,
>>> so there is no need to flush it explicitly.
>>>
>>> Remove the redundant 'flush_workqueue()' calls.
>> are you sure that drain_workqueue() is the same as flush_workqueue()?
> drain_workqueue() calls flush_workqueue() repeatedly.
sorry, i overlooked this
I'm fine with the patch
>
> regards,
> dan carpenter
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-28 11:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-27 1:44 [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls cgel.zte
2022-01-27 12:35 ` Stefan Wahren
2022-01-28 7:03 ` Dan Carpenter
2022-01-28 11:51 ` Stefan Wahren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).