From: Srinivas Neeli <srinivas.neeli@xilinx.com>
To: <wg@grandegger.com>, <mkl@pengutronix.de>, <davem@davemloft.net>,
<kuba@kernel.org>
Cc: <michal.simek@xilinx.com>, <linux-can@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <appana.durga.rao@xilinx.com>,
<sgoud@xilinx.com>, <git@xilinx.com>,
Srinivas Neeli <srinivas.neeli@xilinx.com>
Subject: [PATCH] can: xilinx_can: Add check for NAPI Poll function
Date: Tue, 8 Feb 2022 21:50:53 +0530 [thread overview]
Message-ID: <20220208162053.39896-1-srinivas.neeli@xilinx.com> (raw)
Add check for NAPI poll function to avoid enabling interrupts
with out completing the NAPI call.
Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
---
drivers/net/can/xilinx_can.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c
index 1674b561c9a2..e562c5ab1149 100644
--- a/drivers/net/can/xilinx_can.c
+++ b/drivers/net/can/xilinx_can.c
@@ -1215,10 +1215,11 @@ static int xcan_rx_poll(struct napi_struct *napi, int quota)
}
if (work_done < quota) {
- napi_complete_done(napi, work_done);
- ier = priv->read_reg(priv, XCAN_IER_OFFSET);
- ier |= xcan_rx_int_mask(priv);
- priv->write_reg(priv, XCAN_IER_OFFSET, ier);
+ if (napi_complete_done(napi, work_done)) {
+ ier = priv->read_reg(priv, XCAN_IER_OFFSET);
+ ier |= xcan_rx_int_mask(priv);
+ priv->write_reg(priv, XCAN_IER_OFFSET, ier);
+ }
}
return work_done;
}
--
2.17.1
next reply other threads:[~2022-02-08 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 16:20 Srinivas Neeli [this message]
2022-02-09 7:49 ` [PATCH] can: xilinx_can: Add check for NAPI Poll function Marc Kleine-Budde
2022-02-09 8:29 ` Srinivas Neeli
2022-02-09 8:31 ` Marc Kleine-Budde
2022-02-09 8:40 ` Srinivas Neeli
2022-02-09 8:41 ` Michal Simek
2022-02-09 8:43 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220208162053.39896-1-srinivas.neeli@xilinx.com \
--to=srinivas.neeli@xilinx.com \
--cc=appana.durga.rao@xilinx.com \
--cc=davem@davemloft.net \
--cc=git@xilinx.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=sgoud@xilinx.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).