From: Srinivas Neeli <sneeli@xilinx.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "wg@grandegger.com" <wg@grandegger.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
Michal Simek <michals@xilinx.com>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Appana Durga Kedareswara Rao <appanad@xilinx.com>,
Srinivas Goud <sgoud@xilinx.com>, git <git@xilinx.com>
Subject: RE: [PATCH] can: xilinx_can: Add check for NAPI Poll function
Date: Wed, 9 Feb 2022 08:29:55 +0000 [thread overview]
Message-ID: <DM6PR02MB53861A46A48B4689F668BEE9AF2E9@DM6PR02MB5386.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20220209074930.azbn26glrxukg4sr@pengutronix.de>
Hi Marc,
> -----Original Message-----
> From: Marc Kleine-Budde <mkl@pengutronix.de>
> Sent: Wednesday, February 9, 2022 1:20 PM
> To: Srinivas Neeli <sneeli@xilinx.com>
> Cc: wg@grandegger.com; davem@davemloft.net; kuba@kernel.org; Michal
> Simek <michals@xilinx.com>; linux-can@vger.kernel.org;
> netdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; Appana Durga Kedareswara Rao
> <appanad@xilinx.com>; Srinivas Goud <sgoud@xilinx.com>; git
> <git@xilinx.com>
> Subject: Re: [PATCH] can: xilinx_can: Add check for NAPI Poll function
>
> On 08.02.2022 21:50:53, Srinivas Neeli wrote:
> > Add check for NAPI poll function to avoid enabling interrupts with out
> > completing the NAPI call.
>
> Thanks for the patch. Does this fix a bug? If so, please add a Fixes:
> tag that lists the patch that introduced that bug.
It is not a bug. I am adding additional safety check( Validating the return value of "napi_complete_done" call).
Thanks
Srinivas Neeli
>
> regards,
> Marc
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Embedded Linux | https://www.pengutronix.de |
> Vertretung West/Dortmund | Phone: +49-231-2826-924 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-02-09 8:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 16:20 [PATCH] can: xilinx_can: Add check for NAPI Poll function Srinivas Neeli
2022-02-09 7:49 ` Marc Kleine-Budde
2022-02-09 8:29 ` Srinivas Neeli [this message]
2022-02-09 8:31 ` Marc Kleine-Budde
2022-02-09 8:40 ` Srinivas Neeli
2022-02-09 8:41 ` Michal Simek
2022-02-09 8:43 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR02MB53861A46A48B4689F668BEE9AF2E9@DM6PR02MB5386.namprd02.prod.outlook.com \
--to=sneeli@xilinx.com \
--cc=appanad@xilinx.com \
--cc=davem@davemloft.net \
--cc=git@xilinx.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=sgoud@xilinx.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).