* [PATCH] ARM: dts: qcom: pm8226: add node for RTC
@ 2022-02-09 5:29 Jack Matthews
2022-02-09 8:00 ` Luca Weiss
2022-02-09 16:57 ` [PATCH v2] " Jack Matthews
0 siblings, 2 replies; 4+ messages in thread
From: Jack Matthews @ 2022-02-09 5:29 UTC (permalink / raw)
Cc: jm5112356, Andy Gross, Bjorn Andersson, Rob Herring,
linux-arm-msm, devicetree, linux-kernel
Add a node for PM8226's real time clock.
Signed-off-by: Jack Matthews <jm5112356@gmail.com>
---
arch/arm/boot/dts/qcom-pm8226.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi b/arch/arm/boot/dts/qcom-pm8226.dtsi
index 04d070d98f97..ecc38ab1dc4b 100644
--- a/arch/arm/boot/dts/qcom-pm8226.dtsi
+++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
@@ -17,6 +17,13 @@ pwrkey@800 {
bias-pull-up;
};
+ rtc@6000 {
+ compatible = "qcom,pm8941-rtc";
+ reg = <0x6000>, <0x6100>;
+ reg-names = "rtc", "alarm";
+ interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
+ };
+
smbb: charger@1000 {
compatible = "qcom,pm8226-charger";
reg = <0x1000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: qcom: pm8226: add node for RTC
2022-02-09 5:29 [PATCH] ARM: dts: qcom: pm8226: add node for RTC Jack Matthews
@ 2022-02-09 8:00 ` Luca Weiss
2022-02-09 16:57 ` [PATCH v2] " Jack Matthews
1 sibling, 0 replies; 4+ messages in thread
From: Luca Weiss @ 2022-02-09 8:00 UTC (permalink / raw)
To: Jack Matthews
Cc: jm5112356, Andy Gross, Bjorn Andersson, Rob Herring,
linux-arm-msm, devicetree, linux-kernel
Hi Jack,
On Mittwoch, 9. Februar 2022 06:29:28 CET Jack Matthews wrote:
> Add a node for PM8226's real time clock.
>
> Signed-off-by: Jack Matthews <jm5112356@gmail.com>
> ---
> arch/arm/boot/dts/qcom-pm8226.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi
> b/arch/arm/boot/dts/qcom-pm8226.dtsi index 04d070d98f97..ecc38ab1dc4b
> 100644
> --- a/arch/arm/boot/dts/qcom-pm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
> @@ -17,6 +17,13 @@ pwrkey@800 {
> bias-pull-up;
> };
>
> + rtc@6000 {
Please keep the nodes sorted by address, so don't put @6000 between @800 and
@1000 please ;)
Regards
Luca
> + compatible = "qcom,pm8941-rtc";
> + reg = <0x6000>, <0x6100>;
> + reg-names = "rtc", "alarm";
> + interrupts = <0x0 0x61 0x1
IRQ_TYPE_EDGE_RISING>;
> + };
> +
> smbb: charger@1000 {
> compatible = "qcom,pm8226-charger";
> reg = <0x1000>;
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] ARM: dts: qcom: pm8226: add node for RTC
2022-02-09 5:29 [PATCH] ARM: dts: qcom: pm8226: add node for RTC Jack Matthews
2022-02-09 8:00 ` Luca Weiss
@ 2022-02-09 16:57 ` Jack Matthews
2022-03-30 19:31 ` Luca Weiss
1 sibling, 1 reply; 4+ messages in thread
From: Jack Matthews @ 2022-02-09 16:57 UTC (permalink / raw)
Cc: jm5112356, Andy Gross, Bjorn Andersson, Rob Herring,
linux-arm-msm, devicetree, linux-kernel
Add a node for PM8226's real time clock.
Signed-off-by: Jack Matthews <jm5112356@gmail.com>
---
arch/arm/boot/dts/qcom-pm8226.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi b/arch/arm/boot/dts/qcom-pm8226.dtsi
index 872724490a5d..8ee628ce88a9 100644
--- a/arch/arm/boot/dts/qcom-pm8226.dtsi
+++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
@@ -73,6 +73,13 @@ adc-chan@f {
};
};
+ rtc@6000 {
+ compatible = "qcom,pm8941-rtc";
+ reg = <0x6000>, <0x6100>;
+ reg-names = "rtc", "alarm";
+ interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
+ };
+
pm8226_mpps: mpps@a000 {
compatible = "qcom,pm8226-mpp", "qcom,spmi-mpp";
reg = <0xa000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] ARM: dts: qcom: pm8226: add node for RTC
2022-02-09 16:57 ` [PATCH v2] " Jack Matthews
@ 2022-03-30 19:31 ` Luca Weiss
0 siblings, 0 replies; 4+ messages in thread
From: Luca Weiss @ 2022-03-30 19:31 UTC (permalink / raw)
To: Jack Matthews
Cc: jm5112356, Andy Gross, Bjorn Andersson, Rob Herring,
linux-arm-msm, devicetree, linux-kernel
On Mittwoch, 9. Februar 2022 17:57:41 CEST Jack Matthews wrote:
> Add a node for PM8226's real time clock.
>
> Signed-off-by: Jack Matthews <jm5112356@gmail.com>
Reviewed-by: Luca Weiss <luca@z3ntu.xyz>
Also on lg-lenok at least "allow-set-time;" seems to allow writing to the RTC.
As I'm quite unsure of the reasoning of it normally being read-only and the
implementation details behind what might restrict this I don't think we can
safely add this to all pm8226.
Regards
Luca
> ---
> arch/arm/boot/dts/qcom-pm8226.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi
> b/arch/arm/boot/dts/qcom-pm8226.dtsi index 872724490a5d..8ee628ce88a9
> 100644
> --- a/arch/arm/boot/dts/qcom-pm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
> @@ -73,6 +73,13 @@ adc-chan@f {
> };
> };
>
> + rtc@6000 {
> + compatible = "qcom,pm8941-rtc";
> + reg = <0x6000>, <0x6100>;
> + reg-names = "rtc", "alarm";
> + interrupts = <0x0 0x61 0x1
IRQ_TYPE_EDGE_RISING>;
> + };
> +
> pm8226_mpps: mpps@a000 {
> compatible = "qcom,pm8226-mpp", "qcom,spmi-
mpp";
> reg = <0xa000>;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-30 19:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-09 5:29 [PATCH] ARM: dts: qcom: pm8226: add node for RTC Jack Matthews
2022-02-09 8:00 ` Luca Weiss
2022-02-09 16:57 ` [PATCH v2] " Jack Matthews
2022-03-30 19:31 ` Luca Weiss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).