* [PATCH] staging: greybus: Remove redundant 'flush_workqueue()' calls
@ 2022-02-10 6:02 cgel.zte
2022-02-10 11:43 ` Rui Miguel Silva
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-02-10 6:02 UTC (permalink / raw)
To: rmfrfs
Cc: johan, elder, gregkh, greybus-dev, linux-staging, linux-kernel,
Minghao Chi, Zeal Robot
From: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
'destroy_workqueue()' already drains the queue before destroying it,
so there is no need to flush it explicitly.
Remove the redundant 'flush_workqueue()' calls.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
---
drivers/staging/greybus/sdio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
index 37bf04c22dbc..25bee5335c70 100644
--- a/drivers/staging/greybus/sdio.c
+++ b/drivers/staging/greybus/sdio.c
@@ -858,7 +858,6 @@ static void gb_sdio_remove(struct gbphy_device *gbphy_dev)
gb_connection_set_data(connection, NULL);
mutex_unlock(&host->lock);
- flush_workqueue(host->mrq_workqueue);
destroy_workqueue(host->mrq_workqueue);
gb_connection_disable_rx(connection);
mmc_remove_host(mmc);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: greybus: Remove redundant 'flush_workqueue()' calls
2022-02-10 6:02 [PATCH] staging: greybus: Remove redundant 'flush_workqueue()' calls cgel.zte
@ 2022-02-10 11:43 ` Rui Miguel Silva
0 siblings, 0 replies; 2+ messages in thread
From: Rui Miguel Silva @ 2022-02-10 11:43 UTC (permalink / raw)
To: cgel.zte
Cc: johan, elder, gregkh, greybus-dev, linux-staging, linux-kernel,
Minghao Chi, Zeal Robot
Hey Minghao,
Many thanks for the patch.
On Thu Feb 10, 2022 at 6:02 AM WET, wrote:
> From: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
>
> 'destroy_workqueue()' already drains the queue before destroying it,
> so there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
LGTM.
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Cheers,
Rui
> ---
> drivers/staging/greybus/sdio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
> index 37bf04c22dbc..25bee5335c70 100644
> --- a/drivers/staging/greybus/sdio.c
> +++ b/drivers/staging/greybus/sdio.c
> @@ -858,7 +858,6 @@ static void gb_sdio_remove(struct gbphy_device *gbphy_dev)
> gb_connection_set_data(connection, NULL);
> mutex_unlock(&host->lock);
>
> - flush_workqueue(host->mrq_workqueue);
> destroy_workqueue(host->mrq_workqueue);
> gb_connection_disable_rx(connection);
> mmc_remove_host(mmc);
> --
> 2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-10 11:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10 6:02 [PATCH] staging: greybus: Remove redundant 'flush_workqueue()' calls cgel.zte
2022-02-10 11:43 ` Rui Miguel Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).