* [PATCH v2 0/3] Add support for ocp8110 flash
[not found] <20211117091405.7412-1-git@apitzsch.eu>
@ 2022-02-07 23:06 ` André Apitzsch
2022-02-07 23:06 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add ocs prefix André Apitzsch
` (3 more replies)
2022-02-12 18:09 ` [PATCH v3 1/3] dt-bindings: vendor-prefixes: Add ocs prefix André Apitzsch
` (2 subsequent siblings)
3 siblings, 4 replies; 14+ messages in thread
From: André Apitzsch @ 2022-02-07 23:06 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-leds, Pavel Machek
Cc: Rob Herring, Matthias Brugger, Linus Walleij, André Apitzsch
The led is used as front flash of BQ Aquaris M5.
https://github.com/bq/aquaris-M5/blob/901d0b2ca05c0b0af49786fb548eb0fc289867ff/arch/arm/boot/dts/qcom/piccolo-msm8939-camera-sensor-qrd.dtsi#L16
v2: Reorder patches
André Apitzsch (3):
dt-bindings: vendor-prefixes: Add ocs prefix
dt-bindings: leds: sgm3140: Document ocp8110 compatible
leds: sgm3140: Add ocs,ocp8110 compatible
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 4 +++-
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
drivers/leds/flash/leds-sgm3140.c | 1 +
3 files changed, 6 insertions(+), 1 deletion(-)
base-commit: 2ade8eef993c37a2a43e51a9b1f6c25509a2acce
--
2.35.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add ocs prefix
2022-02-07 23:06 ` [PATCH v2 0/3] Add support for ocp8110 flash André Apitzsch
@ 2022-02-07 23:06 ` André Apitzsch
2022-02-11 16:33 ` Rob Herring
2022-02-07 23:06 ` [PATCH v2 2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible André Apitzsch
` (2 subsequent siblings)
3 siblings, 1 reply; 14+ messages in thread
From: André Apitzsch @ 2022-02-07 23:06 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-leds, Pavel Machek
Cc: Rob Herring, Matthias Brugger, Linus Walleij, André Apitzsch
Add the prefix for Orient Chip Technology.
Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 294093d45a23..9ffffa9773ca 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -854,6 +854,8 @@ patternProperties:
description: NXP Semiconductors
"^oceanic,.*":
description: Oceanic Systems (UK) Ltd.
+ "^ocs,.*":
+ description: Orient Chip Technology Co., Ltd.
"^oct,.*":
description: Octavo Systems LLC
"^okaya,.*":
--
2.35.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add ocs prefix
2022-02-07 23:06 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add ocs prefix André Apitzsch
@ 2022-02-11 16:33 ` Rob Herring
0 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2022-02-11 16:33 UTC (permalink / raw)
To: André Apitzsch
Cc: linux-leds, Matthias Brugger, Linus Walleij, linux-kernel,
devicetree, Pavel Machek, Rob Herring
On Tue, 08 Feb 2022 00:06:36 +0100, André Apitzsch wrote:
> Add the prefix for Orient Chip Technology.
>
> Signed-off-by: André Apitzsch <git@apitzsch.eu>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible
2022-02-07 23:06 ` [PATCH v2 0/3] Add support for ocp8110 flash André Apitzsch
2022-02-07 23:06 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add ocs prefix André Apitzsch
@ 2022-02-07 23:06 ` André Apitzsch
2022-02-11 16:34 ` Rob Herring
2022-02-07 23:06 ` [PATCH v2 3/3] leds: sgm3140: Add ocs,ocp8110 compatible André Apitzsch
2022-02-12 11:28 ` [PATCH v2 0/3] Add support for ocp8110 flash Pavel Machek
3 siblings, 1 reply; 14+ messages in thread
From: André Apitzsch @ 2022-02-07 23:06 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-leds, Pavel Machek
Cc: Rob Herring, Matthias Brugger, Linus Walleij, André Apitzsch
Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
index f68259619488..1c345cf16d08 100644
--- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
@@ -18,7 +18,9 @@ description: |
properties:
compatible:
- const: sgmicro,sgm3140
+ enum:
+ - ocs,ocp8110
+ - sgmicro,sgm3140
enable-gpios:
maxItems: 1
--
2.35.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible
2022-02-07 23:06 ` [PATCH v2 2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible André Apitzsch
@ 2022-02-11 16:34 ` Rob Herring
2022-02-12 13:13 ` André Apitzsch
0 siblings, 1 reply; 14+ messages in thread
From: Rob Herring @ 2022-02-11 16:34 UTC (permalink / raw)
To: André Apitzsch
Cc: linux-kernel, devicetree, linux-leds, Pavel Machek,
Matthias Brugger, Linus Walleij
On Tue, Feb 08, 2022 at 12:06:37AM +0100, André Apitzsch wrote:
> Signed-off-by: André Apitzsch <git@apitzsch.eu>
Commit msg? What's this h/w?
> ---
> Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> index f68259619488..1c345cf16d08 100644
> --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> @@ -18,7 +18,9 @@ description: |
>
> properties:
> compatible:
> - const: sgmicro,sgm3140
> + enum:
> + - ocs,ocp8110
> + - sgmicro,sgm3140
>
> enable-gpios:
> maxItems: 1
> --
> 2.35.1
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible
2022-02-11 16:34 ` Rob Herring
@ 2022-02-12 13:13 ` André Apitzsch
2022-02-12 17:03 ` Pavel Machek
0 siblings, 1 reply; 14+ messages in thread
From: André Apitzsch @ 2022-02-12 13:13 UTC (permalink / raw)
To: Rob Herring
Cc: linux-kernel, devicetree, linux-leds, Pavel Machek,
Matthias Brugger, Linus Walleij
Am Freitag, dem 11.02.2022 um 10:34 -0600 schrieb Rob Herring:
> On Tue, Feb 08, 2022 at 12:06:37AM +0100, André Apitzsch wrote:
> > Signed-off-by: André Apitzsch <git@apitzsch.eu>
>
> Commit msg? What's this h/w?
>
Thanks for the feedback.
Would the following message be sufficient?
"""
dt-bindings: leds: sgm3140: Document ocp8110 compatible
Add devicetree binding for Orient Chip OCP8110 charge pump used for
camera flash LEDs.
"""
> > ---
> > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > index f68259619488..1c345cf16d08 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > @@ -18,7 +18,9 @@ description: |
> >
> > properties:
> > compatible:
> > - const: sgmicro,sgm3140
> > + enum:
> > + - ocs,ocp8110
> > + - sgmicro,sgm3140
> >
> > enable-gpios:
> > maxItems: 1
> > --
> > 2.35.1
> >
> >
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible
2022-02-12 13:13 ` André Apitzsch
@ 2022-02-12 17:03 ` Pavel Machek
0 siblings, 0 replies; 14+ messages in thread
From: Pavel Machek @ 2022-02-12 17:03 UTC (permalink / raw)
To: André Apitzsch
Cc: Rob Herring, linux-kernel, devicetree, linux-leds,
Matthias Brugger, Linus Walleij
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
On Sat 2022-02-12 14:13:32, André Apitzsch wrote:
> Am Freitag, dem 11.02.2022 um 10:34 -0600 schrieb Rob Herring:
> > On Tue, Feb 08, 2022 at 12:06:37AM +0100, André Apitzsch wrote:
> > > Signed-off-by: André Apitzsch <git@apitzsch.eu>
> >
> > Commit msg? What's this h/w?
> >
> Thanks for the feedback.
>
> Would the following message be sufficient?
>
> """
> dt-bindings: leds: sgm3140: Document ocp8110 compatible
>
> Add devicetree binding for Orient Chip OCP8110 charge pump used for
> camera flash LEDs.
> """
Sounds good to me.
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 3/3] leds: sgm3140: Add ocs,ocp8110 compatible
2022-02-07 23:06 ` [PATCH v2 0/3] Add support for ocp8110 flash André Apitzsch
2022-02-07 23:06 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add ocs prefix André Apitzsch
2022-02-07 23:06 ` [PATCH v2 2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible André Apitzsch
@ 2022-02-07 23:06 ` André Apitzsch
2022-02-12 11:28 ` [PATCH v2 0/3] Add support for ocp8110 flash Pavel Machek
3 siblings, 0 replies; 14+ messages in thread
From: André Apitzsch @ 2022-02-07 23:06 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-leds, Pavel Machek
Cc: Rob Herring, Matthias Brugger, Linus Walleij, André Apitzsch
Orient-Chip's ocp8110 has the same pin configuration as the sgm3140.
The data sheet can be found at:
https://cdn.datasheetspdf.com/pdf-down/O/C/P/OCP8110-OrientChip.pdf
Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
drivers/leds/flash/leds-sgm3140.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/flash/leds-sgm3140.c b/drivers/leds/flash/leds-sgm3140.c
index f4f831570f11..d3a30ad94ac4 100644
--- a/drivers/leds/flash/leds-sgm3140.c
+++ b/drivers/leds/flash/leds-sgm3140.c
@@ -290,6 +290,7 @@ static int sgm3140_remove(struct platform_device *pdev)
}
static const struct of_device_id sgm3140_dt_match[] = {
+ { .compatible = "ocs,ocp8110" },
{ .compatible = "sgmicro,sgm3140" },
{ /* sentinel */ }
};
--
2.35.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 0/3] Add support for ocp8110 flash
2022-02-07 23:06 ` [PATCH v2 0/3] Add support for ocp8110 flash André Apitzsch
` (2 preceding siblings ...)
2022-02-07 23:06 ` [PATCH v2 3/3] leds: sgm3140: Add ocs,ocp8110 compatible André Apitzsch
@ 2022-02-12 11:28 ` Pavel Machek
3 siblings, 0 replies; 14+ messages in thread
From: Pavel Machek @ 2022-02-12 11:28 UTC (permalink / raw)
To: André Apitzsch
Cc: linux-kernel, devicetree, linux-leds, Rob Herring,
Matthias Brugger, Linus Walleij
[-- Attachment #1: Type: text/plain, Size: 372 bytes --]
Hi!
> The led is used as front flash of BQ Aquaris M5.
>
> https://github.com/bq/aquaris-M5/blob/901d0b2ca05c0b0af49786fb548eb0fc289867ff/arch/arm/boot/dts/qcom/piccolo-msm8939-camera-sensor-qrd.dtsi#L16
Thanks for patches, I took 1 and 3/3, waiting for some kind of
changelog on 2/.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3 1/3] dt-bindings: vendor-prefixes: Add ocs prefix
[not found] <20211117091405.7412-1-git@apitzsch.eu>
2022-02-07 23:06 ` [PATCH v2 0/3] Add support for ocp8110 flash André Apitzsch
@ 2022-02-12 18:09 ` André Apitzsch
2022-02-12 18:09 ` [PATCH v3 2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible André Apitzsch
2022-02-12 18:09 ` [PATCH v3 3/3] leds: sgm3140: Add ocs,ocp8110 compatible André Apitzsch
3 siblings, 0 replies; 14+ messages in thread
From: André Apitzsch @ 2022-02-12 18:09 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-leds, Pavel Machek
Cc: Rob Herring, Matthias Brugger, Linus Walleij,
André Apitzsch, Rob Herring
Add the prefix for Orient Chip Technology.
Signed-off-by: André Apitzsch <git@apitzsch.eu>
Acked-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 294093d45a23..9ffffa9773ca 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -854,6 +854,8 @@ patternProperties:
description: NXP Semiconductors
"^oceanic,.*":
description: Oceanic Systems (UK) Ltd.
+ "^ocs,.*":
+ description: Orient Chip Technology Co., Ltd.
"^oct,.*":
description: Octavo Systems LLC
"^okaya,.*":
--
2.35.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v3 2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible
[not found] <20211117091405.7412-1-git@apitzsch.eu>
2022-02-07 23:06 ` [PATCH v2 0/3] Add support for ocp8110 flash André Apitzsch
2022-02-12 18:09 ` [PATCH v3 1/3] dt-bindings: vendor-prefixes: Add ocs prefix André Apitzsch
@ 2022-02-12 18:09 ` André Apitzsch
2022-02-22 20:56 ` Rob Herring
2022-02-12 18:09 ` [PATCH v3 3/3] leds: sgm3140: Add ocs,ocp8110 compatible André Apitzsch
3 siblings, 1 reply; 14+ messages in thread
From: André Apitzsch @ 2022-02-12 18:09 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-leds, Pavel Machek
Cc: Rob Herring, Matthias Brugger, Linus Walleij, André Apitzsch
Add devicetree binding for Orient Chip OCP8110 charge pump used for
camera flash LEDs.
Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
V2 -> V3: Add commit message, h/w info
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
index f68259619488..1c345cf16d08 100644
--- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
@@ -18,7 +18,9 @@ description: |
properties:
compatible:
- const: sgmicro,sgm3140
+ enum:
+ - ocs,ocp8110
+ - sgmicro,sgm3140
enable-gpios:
maxItems: 1
--
2.35.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v3 2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible
2022-02-12 18:09 ` [PATCH v3 2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible André Apitzsch
@ 2022-02-22 20:56 ` Rob Herring
2022-03-21 19:05 ` André Apitzsch
0 siblings, 1 reply; 14+ messages in thread
From: Rob Herring @ 2022-02-22 20:56 UTC (permalink / raw)
To: André Apitzsch
Cc: devicetree, Pavel Machek, Rob Herring, linux-leds,
Matthias Brugger, linux-kernel, Linus Walleij
On Sat, 12 Feb 2022 19:09:41 +0100, André Apitzsch wrote:
> Add devicetree binding for Orient Chip OCP8110 charge pump used for
> camera flash LEDs.
>
> Signed-off-by: André Apitzsch <git@apitzsch.eu>
> ---
> V2 -> V3: Add commit message, h/w info
>
> Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible
2022-02-22 20:56 ` Rob Herring
@ 2022-03-21 19:05 ` André Apitzsch
0 siblings, 0 replies; 14+ messages in thread
From: André Apitzsch @ 2022-03-21 19:05 UTC (permalink / raw)
To: Pavel Machek
Cc: devicetree, Rob Herring, linux-leds, Matthias Brugger,
linux-kernel, Linus Walleij, André Apitzsch
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
Am Dienstag, dem 22.02.2022 um 14:56 -0600 schrieb Rob Herring:
> On Sat, 12 Feb 2022 19:09:41 +0100, André Apitzsch wrote:
> > Add devicetree binding for Orient Chip OCP8110 charge pump used for
> > camera flash LEDs.
> >
> > Signed-off-by: André Apitzsch <git@apitzsch.eu>
> > ---
> > V2 -> V3: Add commit message, h/w info
> >
> > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Hello Pavel,
kind reminder that patch 2/3 hasn't been applied to [1], yet.
Is there anything that needs to be done from my side?
Best regards,
André
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/log/?h=for-next
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3 3/3] leds: sgm3140: Add ocs,ocp8110 compatible
[not found] <20211117091405.7412-1-git@apitzsch.eu>
` (2 preceding siblings ...)
2022-02-12 18:09 ` [PATCH v3 2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible André Apitzsch
@ 2022-02-12 18:09 ` André Apitzsch
3 siblings, 0 replies; 14+ messages in thread
From: André Apitzsch @ 2022-02-12 18:09 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-leds, Pavel Machek
Cc: Rob Herring, Matthias Brugger, Linus Walleij, André Apitzsch
Orient-Chip's ocp8110 has the same pin configuration as the sgm3140.
The data sheet can be found at:
https://cdn.datasheetspdf.com/pdf-down/O/C/P/OCP8110-OrientChip.pdf
Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
drivers/leds/flash/leds-sgm3140.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/flash/leds-sgm3140.c b/drivers/leds/flash/leds-sgm3140.c
index f4f831570f11..d3a30ad94ac4 100644
--- a/drivers/leds/flash/leds-sgm3140.c
+++ b/drivers/leds/flash/leds-sgm3140.c
@@ -290,6 +290,7 @@ static int sgm3140_remove(struct platform_device *pdev)
}
static const struct of_device_id sgm3140_dt_match[] = {
+ { .compatible = "ocs,ocp8110" },
{ .compatible = "sgmicro,sgm3140" },
{ /* sentinel */ }
};
--
2.35.1
^ permalink raw reply related [flat|nested] 14+ messages in thread