From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Peter Robinson <pbrobinson@gmail.com>,
Jeremy Linton <jeremy.linton@arm.com>,
netdev@vger.kernel.org, opendmb@gmail.com, davem@davemloft.net,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: bcmgenet: Use stronger register read/writes to assure ordering
Date: Fri, 18 Mar 2022 12:20:17 -0700 [thread overview]
Message-ID: <20220318122017.24341eb1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <472540d2-3a61-beca-70df-d5f152e1cfd1@gmail.com>
On Fri, 18 Mar 2022 12:01:20 -0700 Florian Fainelli wrote:
> Given the time crunch we should go with Jeremy's patch that uses
> stronger I/O access method and then we will work with Jeremy offline to
> make sure that our version of GCC12 is exactly the same as his, as well
> as the compiler options (like -mtune/-march) to reproduce this.
>
> If we believe this is only a problem with GCC12 and 5.17 in Fedora, then
> I would be inclined to remove the Fixes tag such that when we come up
> with a more localized solution we do not have to revert "net: bcmgenet:
> Use stronger register read/writes to assure ordering" from stable
> branches. This would be mostly a courtesy to our future selves, but an
> argument could be made that this probably has always existed, and that
> different compilers could behave more or less like GCC12.
Are you expecting this patch to make 5.17? If Linus cuts final this
weekend, as he most likely will, unless we do something special the
patch in question will end up getting merged during the merge window.
Without the Fixes tag you'll need to manually instruct Greg to pull
it in. Is that the plan?
next prev parent reply other threads:[~2022-03-18 19:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 4:53 [PATCH] net: bcmgenet: Use stronger register read/writes to assure ordering Jeremy Linton
2022-03-10 17:29 ` Peter Robinson
2022-03-10 18:59 ` Florian Fainelli
2022-03-11 1:09 ` Jeremy Linton
2022-03-11 3:57 ` Florian Fainelli
2022-03-15 15:29 ` Peter Robinson
2022-03-18 19:01 ` Florian Fainelli
2022-03-18 19:20 ` Jakub Kicinski [this message]
2022-03-18 21:26 ` Florian Fainelli
2022-03-19 0:22 ` Jakub Kicinski
2022-03-18 19:04 ` Florian Fainelli
2022-03-21 21:26 ` Jakub Kicinski
2022-03-21 21:28 ` Florian Fainelli
2022-03-29 15:07 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318122017.24341eb1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jeremy.linton@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pbrobinson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).