From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Peter Robinson <pbrobinson@gmail.com>,
Jeremy Linton <jeremy.linton@arm.com>,
netdev@vger.kernel.org, opendmb@gmail.com, davem@davemloft.net,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: bcmgenet: Use stronger register read/writes to assure ordering
Date: Fri, 18 Mar 2022 17:22:21 -0700 [thread overview]
Message-ID: <20220318172221.68ecb86a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <082a7743-2eb8-c067-e41d-2a3acca5c056@gmail.com>
On Fri, 18 Mar 2022 14:26:36 -0700 Florian Fainelli wrote:
> Maybe I should have refrained from making that comment after all :)
> Having the Fixes: tag dramatically helps with getting this patch applied
> all the way to the relevant stable trees and surely correctness over
> speed should prevail. If we want to restore the performance loss (with
> the onus on Doug and I to prove that there is a performance drop), then
> we could send a fix with the appropriate localized barrier followed by a
> revert of Jeremy's patch. And if we cared about getting those two
> patches applied to stable, we would tag them with the appropriate Fixes tag.
>
> It looks like there are a few 'net' changes that showed up, are you
> going to send a pull request to Linus before 5.17 final is cut?
Not unless there's -rc9. We'll just merge net into net-next before
submitting net-next, most likely.
next prev parent reply other threads:[~2022-03-19 0:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 4:53 [PATCH] net: bcmgenet: Use stronger register read/writes to assure ordering Jeremy Linton
2022-03-10 17:29 ` Peter Robinson
2022-03-10 18:59 ` Florian Fainelli
2022-03-11 1:09 ` Jeremy Linton
2022-03-11 3:57 ` Florian Fainelli
2022-03-15 15:29 ` Peter Robinson
2022-03-18 19:01 ` Florian Fainelli
2022-03-18 19:20 ` Jakub Kicinski
2022-03-18 21:26 ` Florian Fainelli
2022-03-19 0:22 ` Jakub Kicinski [this message]
2022-03-18 19:04 ` Florian Fainelli
2022-03-21 21:26 ` Jakub Kicinski
2022-03-21 21:28 ` Florian Fainelli
2022-03-29 15:07 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318172221.68ecb86a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jeremy.linton@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pbrobinson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).