From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Chen-Yu Tsai <wenst@chromium.org>,
Ryder Lee <ryder.lee@kernel.org>, Hui Liu <hui.liu@mediatek.com>
Subject: Re: [PATCH v4 08/22] arm64: dts: mt8192: Add infracfg_rst node
Date: Tue, 22 Mar 2022 17:57:54 -0400 [thread overview]
Message-ID: <20220322215754.j2hzutm775hvr25n@notapiano> (raw)
In-Reply-To: <20220318144534.17996-9-allen-kh.cheng@mediatek.com>
Hi Allen,
please see my comment below.
On Fri, Mar 18, 2022 at 10:45:20PM +0800, Allen-KH Cheng wrote:
> Add infracfg_rst node for mt8192 SoC.
> - Add simple-mfd to allow probing the ti,syscon-reset node.
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8192.dtsi | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index 40cf6dacca3e..82de1af3f6aa 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -12,6 +12,7 @@
> #include <dt-bindings/pinctrl/mt8192-pinfunc.h>
> #include <dt-bindings/phy/phy.h>
> #include <dt-bindings/power/mt8192-power.h>
> +#include <dt-bindings/reset/ti-syscon.h>
>
> / {
> compatible = "mediatek,mt8192";
> @@ -267,10 +268,23 @@
> #clock-cells = <1>;
> };
>
> - infracfg: syscon@10001000 {
> - compatible = "mediatek,mt8192-infracfg", "syscon";
> + infracfg: infracfg@10001000 {
> + compatible = "mediatek,mt8192-infracfg", "syscon", "simple-mfd";
> reg = <0 0x10001000 0 0x1000>;
> #clock-cells = <1>;
> +
> + infracfg_rst: reset-controller {
> + compatible = "ti,syscon-reset";
> + #reset-cells = <1>;
> +
> + ti,reset-bits = <
> + 0x120 0 0x124 0 0 0 (ASSERT_SET | DEASSERT_SET | STATUS_NONE) /* 0: lvts_ap */
> + 0x730 12 0x734 12 0 0 (ASSERT_SET | DEASSERT_SET | STATUS_NONE) /* 1: lvts_mcu */
> + 0x140 15 0x144 15 0 0 (ASSERT_SET | DEASSERT_SET | STATUS_NONE) /* 2: pcie phy */
> + 0x730 1 0x734 1 0 0 (ASSERT_SET | DEASSERT_SET | STATUS_NONE) /* 3: pcie top */
> + 0x150 5 0x154 5 0 0 (ASSERT_SET | DEASSERT_SET | STATUS_NONE) /* 4: svs */
> + >;
If you see [1], Rob has previously said that there shouldn't be new users of the
ti,reset-bits property. I suggest doing like proposed on [2]: moving these bit
definitions to the reset-ti-syscon driver, and have them selected through the
compatible. You'd need to add a mt8192 specific compatible here too for that.
[1] https://lore.kernel.org/all/CAL_JsqJq6gqoXtvG1U7UDsOQpz7oMLMunZHq2njN6nvPr8PZMA@mail.gmail.com/
[2] https://lore.kernel.org/all/CAATdQgA5pKhjOf5gxo+h7cs7kCts3DeKGU5axeX2t+OaJFHyBg@mail.gmail.com/
Thanks,
Nícolas
> + };
> };
>
> pericfg: syscon@10003000 {
> --
> 2.18.0
>
>
next prev parent reply other threads:[~2022-03-22 21:58 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 14:45 [PATCH v4 00/22] Add driver nodes for MT8192 SoC Allen-KH Cheng
2022-03-18 14:45 ` [PATCH v4 01/22] arm64: dts: mt8192: Add pwrap node Allen-KH Cheng
2022-03-23 17:15 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 02/22] arm64: dts: mt8192: Add spmi node Allen-KH Cheng
2022-03-23 17:16 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 03/22] arm64: dts: mt8192: Add gce node Allen-KH Cheng
2022-03-23 17:24 ` Matthias Brugger
2022-03-29 20:11 ` Nícolas F. R. A. Prado
2022-03-18 14:45 ` [PATCH v4 04/22] arm64: dts: mt8192: Add SCP node Allen-KH Cheng
2022-03-21 12:04 ` AngeloGioacchino Del Regno
2022-03-22 20:28 ` Nícolas F. R. A. Prado
2022-03-23 17:26 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 05/22] arm64: dts: mt8192: Add usb-phy node Allen-KH Cheng
2022-03-21 12:04 ` AngeloGioacchino Del Regno
2022-03-21 22:22 ` Nícolas F. R. A. Prado
2022-03-24 12:28 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 06/22] arm64: dts: mt8192: Add xhci node Allen-KH Cheng
2022-03-21 22:26 ` Nícolas F. R. A. Prado
2022-03-24 13:45 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 07/22] arm64: dts: mt8192: Add audio-related nodes Allen-KH Cheng
2022-03-24 14:45 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 08/22] arm64: dts: mt8192: Add infracfg_rst node Allen-KH Cheng
2022-03-22 21:57 ` Nícolas F. R. A. Prado [this message]
[not found] ` <17bc30c64db3f3280993669a39edf3a11f76fb68.camel@mediatek.com>
2022-03-24 13:57 ` Nícolas F. R. A. Prado
2022-03-18 14:45 ` [PATCH v4 09/22] arm64: dts: mt8192: Add PCIe node Allen-KH Cheng
2022-03-21 12:04 ` AngeloGioacchino Del Regno
2022-03-22 22:18 ` Nícolas F. R. A. Prado
2022-03-24 17:44 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 10/22] arm64: dts: mt8192: Fix nor_flash status disable typo Allen-KH Cheng
2022-03-18 23:52 ` Miles Chen
2022-03-21 22:30 ` Nícolas F. R. A. Prado
2022-03-24 17:45 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 11/22] arm64: dts: mt8192: Add efuse node Allen-KH Cheng
2022-03-21 12:04 ` AngeloGioacchino Del Regno
2022-03-22 15:10 ` Nícolas F. R. A. Prado
2022-03-24 17:46 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 12/22] arm64: dts: mt8192: Add mmc device nodes Allen-KH Cheng
2022-03-22 14:34 ` Nícolas F. R. A. Prado
2022-03-24 17:53 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 13/22] arm64: dts: mt8192: Add mipi_tx node Allen-KH Cheng
2022-03-21 12:04 ` AngeloGioacchino Del Regno
2022-03-21 22:41 ` Nícolas F. R. A. Prado
2022-03-18 14:45 ` [PATCH v4 14/22] arm64: dts: mt8192: Add m4u and smi nodes Allen-KH Cheng
2022-03-25 10:58 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 15/22] arm64: dts: mt8192: Add H264 venc device node Allen-KH Cheng
2022-03-25 11:01 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 16/22] arm64: dts: mt8192: Add vcodec lat and core nodes Allen-KH Cheng
2022-03-21 12:04 ` AngeloGioacchino Del Regno
2022-03-25 15:22 ` Matthias Brugger
[not found] ` <af19b42faf9a510578e48d6f497e7d2069327195.camel@mediatek.com>
2022-03-29 9:58 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 17/22] arm64: dts: mt8192: Add dpi node Allen-KH Cheng
2022-03-21 12:04 ` AngeloGioacchino Del Regno
2022-03-25 15:24 ` Matthias Brugger
[not found] ` <e4edbb8d599fe202aa89f4dea88e6addfbeb4e0d.camel@mediatek.com>
2022-03-29 10:01 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 18/22] arm64: dts: mt8192: Add display nodes Allen-KH Cheng
2022-03-21 23:26 ` Nícolas F. R. A. Prado
[not found] ` <28c6f778b312b53ec22aec536dadfb3d7d85c35e.camel@mediatek.com>
2022-03-22 14:19 ` Nícolas F. R. A. Prado
2022-03-25 15:47 ` Matthias Brugger
2022-03-28 10:04 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 19/22] arm64: dts: mt8192: Add the mmsys reset bit to reset the dsi0 Allen-KH Cheng
2022-03-21 23:38 ` Rob Herring
2022-03-22 20:16 ` Nícolas F. R. A. Prado
2022-03-25 13:55 ` AngeloGioacchino Del Regno
2022-03-28 10:57 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 20/22] arm64: dts: mt8192: Add dsi node Allen-KH Cheng
2022-03-21 12:04 ` AngeloGioacchino Del Regno
2022-03-22 20:13 ` Nícolas F. R. A. Prado
2022-03-28 11:01 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 21/22] arm64: dts: mt8192: Add gce info for display nodes Allen-KH Cheng
2022-03-22 21:25 ` Nícolas F. R. A. Prado
2022-03-25 13:56 ` AngeloGioacchino Del Regno
2022-03-28 11:06 ` Matthias Brugger
2022-03-18 14:45 ` [PATCH v4 22/22] arm64: dts: mt8192: Add pwm node Allen-KH Cheng
2022-03-21 12:04 ` AngeloGioacchino Del Regno
2022-03-21 22:18 ` Nícolas F. R. A. Prado
2022-03-28 11:10 ` Matthias Brugger
[not found] ` <6ab86a35394879cf35fd9d780f8b7ab1695c931b.camel@mediatek.com>
2022-03-29 10:03 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220322215754.j2hzutm775hvr25n@notapiano \
--to=nfraprado@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hui.liu@mediatek.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).