From: cgel.zte@gmail.com
To: akpm@linux-foundation.org, david@redhat.com
Cc: yang.yang29@zte.com.cn, ran.xiaokai@zte.com.cn,
yang.shi@linux.alibaba.com, dave.hansen@linux.intel.com,
minchan@kernel.org, saravanand@fb.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
xu xin <xu.xin16@zte.com.cn>
Subject: [PATCH v3] mm/vmstat: add events for ksm cow
Date: Thu, 24 Mar 2022 10:43:33 +0000 [thread overview]
Message-ID: <20220324104332.2350482-1-yang.yang29@zte.com.cn> (raw)
From: Yang Yang <yang.yang29@zte.com.cn>
Users may use ksm by calling madvise(, , MADV_MERGEABLE) when they want
to save memory, it's a tradeoff by suffering delay on ksm cow. Users can
get to know how much memory ksm saved by reading
/sys/kernel/mm/ksm/pages_sharing, but they don't know what's the costs
of ksm cow, and this is important of some delay sensitive tasks.
So add ksm cow events to help users evaluate whether or how to use ksm.
Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: xu xin <xu.xin16@zte.com.cn>
Reviewed-by: Ran Xiaokai <ran.xiaokai@zte.com.cn>
---
v2:
- fix compile error when CONFIG_KSM is not set
v3:
- delete KSM_COW_FAIL event
---
include/linux/vm_event_item.h | 1 +
mm/memory.c | 4 ++++
mm/vmstat.c | 1 +
3 files changed, 6 insertions(+)
diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h
index 16a0a4fd000b..d817ba541851 100644
--- a/include/linux/vm_event_item.h
+++ b/include/linux/vm_event_item.h
@@ -131,6 +131,7 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT,
SWAP_RA_HIT,
#ifdef CONFIG_KSM
KSM_SWPIN_COPY,
+ COW_KSM,
#endif
#endif
#ifdef CONFIG_X86
diff --git a/mm/memory.c b/mm/memory.c
index 4111f97c91a0..12925ceaf745 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3339,6 +3339,10 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf)
get_page(vmf->page);
pte_unmap_unlock(vmf->pte, vmf->ptl);
+#ifdef CONFIG_KSM
+ if (PageKsm(vmf->page))
+ count_vm_event(COW_KSM);
+#endif
return wp_page_copy(vmf);
}
diff --git a/mm/vmstat.c b/mm/vmstat.c
index d5cc8d739fac..710d71af2285 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1390,6 +1390,7 @@ const char * const vmstat_text[] = {
"swap_ra_hit",
#ifdef CONFIG_KSM
"ksm_swpin_copy",
+ "cow_ksm",
#endif
#endif
#ifdef CONFIG_X86
--
2.25.1
next reply other threads:[~2022-03-24 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 10:43 cgel.zte [this message]
2022-03-24 12:45 ` [PATCH v3] mm/vmstat: add events for ksm cow Matthew Wilcox
2022-03-24 12:49 ` David Hildenbrand
2022-03-25 20:09 ` Andrew Morton
2022-03-25 20:19 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220324104332.2350482-1-yang.yang29@zte.com.cn \
--to=cgel.zte@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ran.xiaokai@zte.com.cn \
--cc=saravanand@fb.com \
--cc=xu.xin16@zte.com.cn \
--cc=yang.shi@linux.alibaba.com \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).