From: Matthew Wilcox <willy@infradead.org>
To: cgel.zte@gmail.com
Cc: akpm@linux-foundation.org, david@redhat.com,
yang.yang29@zte.com.cn, ran.xiaokai@zte.com.cn,
yang.shi@linux.alibaba.com, dave.hansen@linux.intel.com,
minchan@kernel.org, saravanand@fb.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
xu xin <xu.xin16@zte.com.cn>
Subject: Re: [PATCH v3] mm/vmstat: add events for ksm cow
Date: Thu, 24 Mar 2022 12:45:27 +0000 [thread overview]
Message-ID: <Yjxn53YcdKDcV7zX@casper.infradead.org> (raw)
In-Reply-To: <20220324104332.2350482-1-yang.yang29@zte.com.cn>
On Thu, Mar 24, 2022 at 10:43:33AM +0000, cgel.zte@gmail.com wrote:
> +++ b/include/linux/vm_event_item.h
> @@ -131,6 +131,7 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT,
> SWAP_RA_HIT,
> #ifdef CONFIG_KSM
> KSM_SWPIN_COPY,
> + COW_KSM,
Shouldn't we call this KSM_COW?
> +++ b/mm/vmstat.c
> @@ -1390,6 +1390,7 @@ const char * const vmstat_text[] = {
> "swap_ra_hit",
> #ifdef CONFIG_KSM
> "ksm_swpin_copy",
> + "cow_ksm",
... and this "ksm_cow"?
next prev parent reply other threads:[~2022-03-24 12:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 10:43 [PATCH v3] mm/vmstat: add events for ksm cow cgel.zte
2022-03-24 12:45 ` Matthew Wilcox [this message]
2022-03-24 12:49 ` David Hildenbrand
2022-03-25 20:09 ` Andrew Morton
2022-03-25 20:19 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjxn53YcdKDcV7zX@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cgel.zte@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ran.xiaokai@zte.com.cn \
--cc=saravanand@fb.com \
--cc=xu.xin16@zte.com.cn \
--cc=yang.shi@linux.alibaba.com \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).