From: David Hildenbrand <david@redhat.com>
To: Matthew Wilcox <willy@infradead.org>, cgel.zte@gmail.com
Cc: akpm@linux-foundation.org, yang.yang29@zte.com.cn,
ran.xiaokai@zte.com.cn, yang.shi@linux.alibaba.com,
dave.hansen@linux.intel.com, minchan@kernel.org,
saravanand@fb.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, xu xin <xu.xin16@zte.com.cn>
Subject: Re: [PATCH v3] mm/vmstat: add events for ksm cow
Date: Thu, 24 Mar 2022 13:49:25 +0100 [thread overview]
Message-ID: <eabdd49c-d69c-91f3-c780-9bbf661f704c@redhat.com> (raw)
In-Reply-To: <Yjxn53YcdKDcV7zX@casper.infradead.org>
On 24.03.22 13:45, Matthew Wilcox wrote:
> On Thu, Mar 24, 2022 at 10:43:33AM +0000, cgel.zte@gmail.com wrote:
>> +++ b/include/linux/vm_event_item.h
>> @@ -131,6 +131,7 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT,
>> SWAP_RA_HIT,
>> #ifdef CONFIG_KSM
>> KSM_SWPIN_COPY,
>> + COW_KSM,
>
> Shouldn't we call this KSM_COW?
I guess I proposed COW_KSM because ideally we'll have COW_ANON,
COW_ZERO, COW_OTHER, ... so it'd be under the "COW" namespace. No strong
opinion, though.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-03-24 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 10:43 [PATCH v3] mm/vmstat: add events for ksm cow cgel.zte
2022-03-24 12:45 ` Matthew Wilcox
2022-03-24 12:49 ` David Hildenbrand [this message]
2022-03-25 20:09 ` Andrew Morton
2022-03-25 20:19 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eabdd49c-d69c-91f3-c780-9bbf661f704c@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cgel.zte@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ran.xiaokai@zte.com.cn \
--cc=saravanand@fb.com \
--cc=willy@infradead.org \
--cc=xu.xin16@zte.com.cn \
--cc=yang.shi@linux.alibaba.com \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).