* [PATCH 1/2] ARM: dts: keystone: align SPI NOR node name with dtschema @ 2022-04-07 14:31 Krzysztof Kozlowski 2022-04-07 14:31 ` [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible Krzysztof Kozlowski 2022-04-08 9:59 ` [PATCH 1/2] ARM: dts: keystone: align SPI NOR node name with dtschema Grygorii Strashko 0 siblings, 2 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-04-07 14:31 UTC (permalink / raw) To: Nishanth Menon, Santosh Shilimkar, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel Cc: Krzysztof Kozlowski The node names should be generic and SPI NOR dtschema expects "flash". Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2g-ice.dts | 2 +- arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/keystone-k2e-evm.dts b/arch/arm/boot/dts/keystone-k2e-evm.dts index 66fec5f5d081..8f49883a675e 100644 --- a/arch/arm/boot/dts/keystone-k2e-evm.dts +++ b/arch/arm/boot/dts/keystone-k2e-evm.dts @@ -137,7 +137,7 @@ partition@180000 { }; &spi0 { - nor_flash: n25q128a11@0 { + nor_flash: flash@0 { #address-cells = <1>; #size-cells = <1>; compatible = "Micron,n25q128a11"; diff --git a/arch/arm/boot/dts/keystone-k2g-evm.dts b/arch/arm/boot/dts/keystone-k2g-evm.dts index d800f26b6275..88be868cf71e 100644 --- a/arch/arm/boot/dts/keystone-k2g-evm.dts +++ b/arch/arm/boot/dts/keystone-k2g-evm.dts @@ -392,7 +392,7 @@ &qspi { pinctrl-0 = <&qspi_pins>; cdns,rclk-en; - flash0: m25p80@0 { + flash0: flash@0 { compatible = "s25fl512s", "jedec,spi-nor"; reg = <0>; spi-tx-bus-width = <1>; diff --git a/arch/arm/boot/dts/keystone-k2g-ice.dts b/arch/arm/boot/dts/keystone-k2g-ice.dts index 2a2d38cf0fff..bd84d7f0f2fe 100644 --- a/arch/arm/boot/dts/keystone-k2g-ice.dts +++ b/arch/arm/boot/dts/keystone-k2g-ice.dts @@ -325,7 +325,7 @@ &qspi { cdns,rclk-en; status = "okay"; - flash0: m25p80@0 { + flash0: flash@0 { compatible = "s25fl256s1", "jedec,spi-nor"; reg = <0>; spi-tx-bus-width = <1>; diff --git a/arch/arm/boot/dts/keystone-k2hk-evm.dts b/arch/arm/boot/dts/keystone-k2hk-evm.dts index ad4e22afe133..f968af0bfad3 100644 --- a/arch/arm/boot/dts/keystone-k2hk-evm.dts +++ b/arch/arm/boot/dts/keystone-k2hk-evm.dts @@ -161,7 +161,7 @@ dtt@50 { }; &spi0 { - nor_flash: n25q128a11@0 { + nor_flash: flash@0 { #address-cells = <1>; #size-cells = <1>; compatible = "Micron,n25q128a11"; diff --git a/arch/arm/boot/dts/keystone-k2l-evm.dts b/arch/arm/boot/dts/keystone-k2l-evm.dts index e200533d26a4..32619b3c5804 100644 --- a/arch/arm/boot/dts/keystone-k2l-evm.dts +++ b/arch/arm/boot/dts/keystone-k2l-evm.dts @@ -110,7 +110,7 @@ partition@180000 { }; &spi0 { - nor_flash: n25q128a11@0 { + nor_flash: flash@0 { #address-cells = <1>; #size-cells = <1>; compatible = "Micron,n25q128a11"; -- 2.32.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible 2022-04-07 14:31 [PATCH 1/2] ARM: dts: keystone: align SPI NOR node name with dtschema Krzysztof Kozlowski @ 2022-04-07 14:31 ` Krzysztof Kozlowski 2022-04-08 9:58 ` Grygorii Strashko 2022-04-15 18:54 ` Nishanth Menon 2022-04-08 9:59 ` [PATCH 1/2] ARM: dts: keystone: align SPI NOR node name with dtschema Grygorii Strashko 1 sibling, 2 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-04-07 14:31 UTC (permalink / raw) To: Nishanth Menon, Santosh Shilimkar, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel Cc: Krzysztof Kozlowski Vendor prefix in compatible should be lower-case. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +- arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/keystone-k2e-evm.dts b/arch/arm/boot/dts/keystone-k2e-evm.dts index 8f49883a675e..9e507293a8d7 100644 --- a/arch/arm/boot/dts/keystone-k2e-evm.dts +++ b/arch/arm/boot/dts/keystone-k2e-evm.dts @@ -140,7 +140,7 @@ &spi0 { nor_flash: flash@0 { #address-cells = <1>; #size-cells = <1>; - compatible = "Micron,n25q128a11"; + compatible = "micron,n25q128a11"; spi-max-frequency = <54000000>; m25p,fast-read; reg = <0>; diff --git a/arch/arm/boot/dts/keystone-k2hk-evm.dts b/arch/arm/boot/dts/keystone-k2hk-evm.dts index f968af0bfad3..1a1a49c19a19 100644 --- a/arch/arm/boot/dts/keystone-k2hk-evm.dts +++ b/arch/arm/boot/dts/keystone-k2hk-evm.dts @@ -164,7 +164,7 @@ &spi0 { nor_flash: flash@0 { #address-cells = <1>; #size-cells = <1>; - compatible = "Micron,n25q128a11"; + compatible = "micron,n25q128a11"; spi-max-frequency = <54000000>; m25p,fast-read; reg = <0>; diff --git a/arch/arm/boot/dts/keystone-k2l-evm.dts b/arch/arm/boot/dts/keystone-k2l-evm.dts index 32619b3c5804..06d55b89170d 100644 --- a/arch/arm/boot/dts/keystone-k2l-evm.dts +++ b/arch/arm/boot/dts/keystone-k2l-evm.dts @@ -113,7 +113,7 @@ &spi0 { nor_flash: flash@0 { #address-cells = <1>; #size-cells = <1>; - compatible = "Micron,n25q128a11"; + compatible = "micron,n25q128a11"; spi-max-frequency = <54000000>; m25p,fast-read; reg = <0>; -- 2.32.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible 2022-04-07 14:31 ` [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible Krzysztof Kozlowski @ 2022-04-08 9:58 ` Grygorii Strashko 2022-04-15 18:54 ` Nishanth Menon 1 sibling, 0 replies; 6+ messages in thread From: Grygorii Strashko @ 2022-04-08 9:58 UTC (permalink / raw) To: Krzysztof Kozlowski, Nishanth Menon, Santosh Shilimkar, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel Cc: Roger Quadros On 07/04/2022 17:31, Krzysztof Kozlowski wrote: > Vendor prefix in compatible should be lower-case. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/keystone-k2e-evm.dts b/arch/arm/boot/dts/keystone-k2e-evm.dts > index 8f49883a675e..9e507293a8d7 100644 > --- a/arch/arm/boot/dts/keystone-k2e-evm.dts > +++ b/arch/arm/boot/dts/keystone-k2e-evm.dts > @@ -140,7 +140,7 @@ &spi0 { > nor_flash: flash@0 { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "Micron,n25q128a11"; > + compatible = "micron,n25q128a11"; > spi-max-frequency = <54000000>; > m25p,fast-read; > reg = <0>; > diff --git a/arch/arm/boot/dts/keystone-k2hk-evm.dts b/arch/arm/boot/dts/keystone-k2hk-evm.dts > index f968af0bfad3..1a1a49c19a19 100644 > --- a/arch/arm/boot/dts/keystone-k2hk-evm.dts > +++ b/arch/arm/boot/dts/keystone-k2hk-evm.dts > @@ -164,7 +164,7 @@ &spi0 { > nor_flash: flash@0 { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "Micron,n25q128a11"; > + compatible = "micron,n25q128a11"; > spi-max-frequency = <54000000>; > m25p,fast-read; > reg = <0>; > diff --git a/arch/arm/boot/dts/keystone-k2l-evm.dts b/arch/arm/boot/dts/keystone-k2l-evm.dts > index 32619b3c5804..06d55b89170d 100644 > --- a/arch/arm/boot/dts/keystone-k2l-evm.dts > +++ b/arch/arm/boot/dts/keystone-k2l-evm.dts > @@ -113,7 +113,7 @@ &spi0 { > nor_flash: flash@0 { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "Micron,n25q128a11"; > + compatible = "micron,n25q128a11"; > spi-max-frequency = <54000000>; > m25p,fast-read; > reg = <0>; Thanks you. Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> -- Best regards, Grygorii, Ukraine ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible 2022-04-07 14:31 ` [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible Krzysztof Kozlowski 2022-04-08 9:58 ` Grygorii Strashko @ 2022-04-15 18:54 ` Nishanth Menon 2022-04-17 17:58 ` Krzysztof Kozlowski 1 sibling, 1 reply; 6+ messages in thread From: Nishanth Menon @ 2022-04-15 18:54 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Santosh Shilimkar, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel On 16:31-20220407, Krzysztof Kozlowski wrote: > Vendor prefix in compatible should be lower-case. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/keystone-k2e-evm.dts b/arch/arm/boot/dts/keystone-k2e-evm.dts > index 8f49883a675e..9e507293a8d7 100644 > --- a/arch/arm/boot/dts/keystone-k2e-evm.dts > +++ b/arch/arm/boot/dts/keystone-k2e-evm.dts > @@ -140,7 +140,7 @@ &spi0 { > nor_flash: flash@0 { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "Micron,n25q128a11"; > + compatible = "micron,n25q128a11"; > spi-max-frequency = <54000000>; > m25p,fast-read; > reg = <0>; > diff --git a/arch/arm/boot/dts/keystone-k2hk-evm.dts b/arch/arm/boot/dts/keystone-k2hk-evm.dts > index f968af0bfad3..1a1a49c19a19 100644 > --- a/arch/arm/boot/dts/keystone-k2hk-evm.dts > +++ b/arch/arm/boot/dts/keystone-k2hk-evm.dts > @@ -164,7 +164,7 @@ &spi0 { > nor_flash: flash@0 { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "Micron,n25q128a11"; > + compatible = "micron,n25q128a11"; > spi-max-frequency = <54000000>; > m25p,fast-read; > reg = <0>; > diff --git a/arch/arm/boot/dts/keystone-k2l-evm.dts b/arch/arm/boot/dts/keystone-k2l-evm.dts > index 32619b3c5804..06d55b89170d 100644 > --- a/arch/arm/boot/dts/keystone-k2l-evm.dts > +++ b/arch/arm/boot/dts/keystone-k2l-evm.dts > @@ -113,7 +113,7 @@ &spi0 { > nor_flash: flash@0 { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "Micron,n25q128a11"; > + compatible = "micron,n25q128a11"; > spi-max-frequency = <54000000>; > m25p,fast-read; > reg = <0>; I have no idea how this works. There is no documentation for the compatible, So I am guessing adding it to Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml is appropriate prior to replacing with "micron,n25q128a11", "jedec,spi-nor"; $ git grep micron,n25q128a11 . arch/arm/boot/dts/imx6qdl-aristainetos.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; arch/arm/boot/dts/keystone-k2e-evm.dts: compatible = "micron,n25q128a11"; arch/arm/boot/dts/keystone-k2hk-evm.dts: compatible = "micron,n25q128a11"; arch/arm/boot/dts/keystone-k2l-evm.dts: compatible = "micron,n25q128a11"; arch/powerpc/boot/dts/fsl/t1024qds.dts: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */ arch/powerpc/boot/dts/fsl/t104xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; arch/powerpc/boot/dts/fsl/t208xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */ -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible 2022-04-15 18:54 ` Nishanth Menon @ 2022-04-17 17:58 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-04-17 17:58 UTC (permalink / raw) To: Nishanth Menon Cc: Santosh Shilimkar, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel On 15/04/2022 20:54, Nishanth Menon wrote: > > I have no idea how this works. There is no documentation for the > compatible, So I am guessing adding it to Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > is appropriate prior to replacing with "micron,n25q128a11", "jedec,spi-nor"; Compatible is documented in jedec,spi-nor.yaml (through pattern), although it should be followed by "jedec,spi-nor", according to schema. I did not fix that missing compatible fallback, because I did not want to break any setup (I cannot test it), but adding the fallback seems harmless/safe. > > $ git grep micron,n25q128a11 . > arch/arm/boot/dts/imx6qdl-aristainetos.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; > arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; > arch/arm/boot/dts/keystone-k2e-evm.dts: compatible = "micron,n25q128a11"; > arch/arm/boot/dts/keystone-k2hk-evm.dts: compatible = "micron,n25q128a11"; > arch/arm/boot/dts/keystone-k2l-evm.dts: compatible = "micron,n25q128a11"; > arch/powerpc/boot/dts/fsl/t1024qds.dts: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */ > arch/powerpc/boot/dts/fsl/t104xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; > arch/powerpc/boot/dts/fsl/t208xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */ > > Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: dts: keystone: align SPI NOR node name with dtschema 2022-04-07 14:31 [PATCH 1/2] ARM: dts: keystone: align SPI NOR node name with dtschema Krzysztof Kozlowski 2022-04-07 14:31 ` [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible Krzysztof Kozlowski @ 2022-04-08 9:59 ` Grygorii Strashko 1 sibling, 0 replies; 6+ messages in thread From: Grygorii Strashko @ 2022-04-08 9:59 UTC (permalink / raw) To: Krzysztof Kozlowski, Nishanth Menon, Santosh Shilimkar, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel Cc: Roger Quadros On 07/04/2022 17:31, Krzysztof Kozlowski wrote: > The node names should be generic and SPI NOR dtschema expects "flash". > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2g-ice.dts | 2 +- > arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +- > arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/keystone-k2e-evm.dts b/arch/arm/boot/dts/keystone-k2e-evm.dts > index 66fec5f5d081..8f49883a675e 100644 > --- a/arch/arm/boot/dts/keystone-k2e-evm.dts > +++ b/arch/arm/boot/dts/keystone-k2e-evm.dts > @@ -137,7 +137,7 @@ partition@180000 { > }; > > &spi0 { > - nor_flash: n25q128a11@0 { > + nor_flash: flash@0 { > #address-cells = <1>; > #size-cells = <1>; > compatible = "Micron,n25q128a11"; > diff --git a/arch/arm/boot/dts/keystone-k2g-evm.dts b/arch/arm/boot/dts/keystone-k2g-evm.dts > index d800f26b6275..88be868cf71e 100644 > --- a/arch/arm/boot/dts/keystone-k2g-evm.dts > +++ b/arch/arm/boot/dts/keystone-k2g-evm.dts > @@ -392,7 +392,7 @@ &qspi { > pinctrl-0 = <&qspi_pins>; > cdns,rclk-en; > > - flash0: m25p80@0 { > + flash0: flash@0 { > compatible = "s25fl512s", "jedec,spi-nor"; > reg = <0>; > spi-tx-bus-width = <1>; > diff --git a/arch/arm/boot/dts/keystone-k2g-ice.dts b/arch/arm/boot/dts/keystone-k2g-ice.dts > index 2a2d38cf0fff..bd84d7f0f2fe 100644 > --- a/arch/arm/boot/dts/keystone-k2g-ice.dts > +++ b/arch/arm/boot/dts/keystone-k2g-ice.dts > @@ -325,7 +325,7 @@ &qspi { > cdns,rclk-en; > status = "okay"; > > - flash0: m25p80@0 { > + flash0: flash@0 { > compatible = "s25fl256s1", "jedec,spi-nor"; > reg = <0>; > spi-tx-bus-width = <1>; > diff --git a/arch/arm/boot/dts/keystone-k2hk-evm.dts b/arch/arm/boot/dts/keystone-k2hk-evm.dts > index ad4e22afe133..f968af0bfad3 100644 > --- a/arch/arm/boot/dts/keystone-k2hk-evm.dts > +++ b/arch/arm/boot/dts/keystone-k2hk-evm.dts > @@ -161,7 +161,7 @@ dtt@50 { > }; > > &spi0 { > - nor_flash: n25q128a11@0 { > + nor_flash: flash@0 { > #address-cells = <1>; > #size-cells = <1>; > compatible = "Micron,n25q128a11"; > diff --git a/arch/arm/boot/dts/keystone-k2l-evm.dts b/arch/arm/boot/dts/keystone-k2l-evm.dts > index e200533d26a4..32619b3c5804 100644 > --- a/arch/arm/boot/dts/keystone-k2l-evm.dts > +++ b/arch/arm/boot/dts/keystone-k2l-evm.dts > @@ -110,7 +110,7 @@ partition@180000 { > }; > > &spi0 { > - nor_flash: n25q128a11@0 { > + nor_flash: flash@0 { > #address-cells = <1>; > #size-cells = <1>; > compatible = "Micron,n25q128a11"; Thank you Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> -- Best regards, Grygorii, Ukraine ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-17 17:58 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-04-07 14:31 [PATCH 1/2] ARM: dts: keystone: align SPI NOR node name with dtschema Krzysztof Kozlowski 2022-04-07 14:31 ` [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible Krzysztof Kozlowski 2022-04-08 9:58 ` Grygorii Strashko 2022-04-15 18:54 ` Nishanth Menon 2022-04-17 17:58 ` Krzysztof Kozlowski 2022-04-08 9:59 ` [PATCH 1/2] ARM: dts: keystone: align SPI NOR node name with dtschema Grygorii Strashko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).