[PATCH v2 0/2] Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate")

[PATCH v2 0/2] Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate")

[matthias.bgg]

From: Matthias Brugger <matthias.bgg@gmail.com>


The mt8192-msdc clock is only a single clock gate. This gate is accessed
from the mmc driver directly. With
4a1d1379ebf6 ("arm64: dts: mt8192: Add mmc device nodes")
the only consumer of this binding was deleted. Delete the binding
decription and the clock driver bound to it.

Changes in v2:
- Delete compatible in binding descprition as well
- add Reviewed-by tag

Matthias Brugger (2):
  dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
  clk: mediatek: Delete MT8192 msdc gate

 .../arm/mediatek/mediatek,mt8192-clock.yaml   |  8 -------
 drivers/clk/mediatek/clk-mt8192-msdc.c        | 21 -------------------
 2 files changed, 29 deletions(-)

-- 
2.34.1

[PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock

[matthias.bgg]

From: Matthias Brugger <matthias.bgg@gmail.com>

The msdc gate is part of the MMC driver. Delete the binding description
of this node.

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>

---

Changes in v2:
- Delete compatible in binding descprition as well

 .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
index c8c67c033f8c..b57cc2e69efb 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
@@ -24,7 +24,6 @@ properties:
           - mediatek,mt8192-imp_iic_wrap_w
           - mediatek,mt8192-imp_iic_wrap_n
           - mediatek,mt8192-msdc_top
-          - mediatek,mt8192-msdc
           - mediatek,mt8192-mfgcfg
           - mediatek,mt8192-imgsys
           - mediatek,mt8192-imgsys2
@@ -107,13 +106,6 @@ examples:
         #clock-cells = <1>;
     };
 
-  - |
-    msdc: clock-controller@11f60000 {
-        compatible = "mediatek,mt8192-msdc";
-        reg = <0x11f60000 0x1000>;
-        #clock-cells = <1>;
-    };
-
   - |
     mfgcfg: clock-controller@13fbf000 {
         compatible = "mediatek,mt8192-mfgcfg";
-- 
2.34.1

Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock

[AngeloGioacchino Del Regno]

Il 29/04/22 14:31, matthias.bgg@kernel.org ha scritto:
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> The msdc gate is part of the MMC driver. Delete the binding description
> of this node.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock

[Miles Chen]

> The msdc gate is part of the MMC driver. Delete the binding description
> of this node.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>

Reviewed-by: Miles Chen <miles.chen@mediatek.com> 

Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock

[Rob Herring]

On Fri, Apr 29, 2022 at 02:31:31PM +0200, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> The msdc gate is part of the MMC driver. Delete the binding description
> of this node.

An ABI break is okay because ...?

> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> 
> ---
> 
> Changes in v2:
> - Delete compatible in binding descprition as well
> 
>  .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> index c8c67c033f8c..b57cc2e69efb 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> @@ -24,7 +24,6 @@ properties:
>            - mediatek,mt8192-imp_iic_wrap_w
>            - mediatek,mt8192-imp_iic_wrap_n
>            - mediatek,mt8192-msdc_top
> -          - mediatek,mt8192-msdc
>            - mediatek,mt8192-mfgcfg
>            - mediatek,mt8192-imgsys
>            - mediatek,mt8192-imgsys2
> @@ -107,13 +106,6 @@ examples:
>          #clock-cells = <1>;
>      };
>  
> -  - |
> -    msdc: clock-controller@11f60000 {
> -        compatible = "mediatek,mt8192-msdc";
> -        reg = <0x11f60000 0x1000>;
> -        #clock-cells = <1>;
> -    };
> -
>    - |
>      mfgcfg: clock-controller@13fbf000 {
>          compatible = "mediatek,mt8192-mfgcfg";
> -- 
> 2.34.1
> 
> 

Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock

[Miles Chen]

Hi Rob,

>> From: Matthias Brugger <matthias.bgg@gmail.com>
>> 
>> The msdc gate is part of the MMC driver. Delete the binding description
>> of this node.
> 
>An ABI break is okay because ...?

Sorry for that, 

If the mediatek,mt8192-msdc part is removed from the driver, 
Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or 
we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.

e.g.,
          - mediatek,mt8192-msdc # deprecated


thanks,
Miles

> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> 
> ---
> 
> Changes in v2:
> - Delete compatible in binding descprition as well
> 
>  .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> index c8c67c033f8c..b57cc2e69efb 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> @@ -24,7 +24,6 @@ properties:
>            - mediatek,mt8192-imp_iic_wrap_w
>            - mediatek,mt8192-imp_iic_wrap_n
>            - mediatek,mt8192-msdc_top
> -          - mediatek,mt8192-msdc
>            - mediatek,mt8192-mfgcfg
>            - mediatek,mt8192-imgsys
>            - mediatek,mt8192-imgsys2
> @@ -107,13 +106,6 @@ examples:
>          #clock-cells = <1>;
>      };
>  
> -  - |
> -    msdc: clock-controller@11f60000 {
> -        compatible = "mediatek,mt8192-msdc";
> -        reg = <0x11f60000 0x1000>;
> -        #clock-cells = <1>;
> -    };
> -
>    - |
>      mfgcfg: clock-controller@13fbf000 {
>          compatible = "mediatek,mt8192-mfgcfg";
> -- 
> 2.34.1
> 
> 

Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock

[Rob Herring]

On Thu, May 05, 2022 at 01:31:11PM +0800, Miles Chen wrote:
> Hi Rob,
> 
> >> From: Matthias Brugger <matthias.bgg@gmail.com>
> >> 
> >> The msdc gate is part of the MMC driver. Delete the binding description
> >> of this node.
> > 
> >An ABI break is okay because ...?
> 
> Sorry for that, 
> 
> If the mediatek,mt8192-msdc part is removed from the driver, 

That's an ABI break too. You just need to explain why as Matthias did in 
the commit message if the ABI break is okay.

> Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or 
> we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.

We do that sometimes, but depends on the situation.

Rob

Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock

[Miles Chen]

Hi Rob,

>On Thu, May 05, 2022 at 01:31:11PM +0800, Miles Chen wrote:
>> Hi Rob,
>> 
>> >> From: Matthias Brugger <matthias.bgg@gmail.com>
>> >> 
>> >> The msdc gate is part of the MMC driver. Delete the binding description
>> >> of this node.
>> > 
>> >An ABI break is okay because ...?
>> 
>> Sorry for that, 
>> 
>> If the mediatek,mt8192-msdc part is removed from the driver, 
>
>That's an ABI break too. You just need to explain why as Matthias did in 
>the commit message if the ABI break is okay.

Thanks for your explanation.

I would like to learn more about this. In this case
If there was a user (say xxx.c) but the user was removed, can I remove mediatek,mt8192-msdc?

thanks,
Miles

>
>> Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or 
>> we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.
>
>We do that sometimes, but depends on the situation.
>
>Rob

Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock

[Matthias Brugger]

On 03/05/2022 23:48, Rob Herring wrote:
> On Fri, Apr 29, 2022 at 02:31:31PM +0200, matthias.bgg@kernel.org wrote:
>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> The msdc gate is part of the MMC driver. Delete the binding description
>> of this node.
> 
> An ABI break is okay because ...?
> 

Because the code controlling the clock gate was moved to the consumer. This node 
did never ever represent any working implementation of a peripheral. Just a 
lonely clock gate that wasn't used.

Regards,
Matthias

>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - Delete compatible in binding descprition as well
>>
>>   .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
>>   1 file changed, 8 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> index c8c67c033f8c..b57cc2e69efb 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> @@ -24,7 +24,6 @@ properties:
>>             - mediatek,mt8192-imp_iic_wrap_w
>>             - mediatek,mt8192-imp_iic_wrap_n
>>             - mediatek,mt8192-msdc_top
>> -          - mediatek,mt8192-msdc
>>             - mediatek,mt8192-mfgcfg
>>             - mediatek,mt8192-imgsys
>>             - mediatek,mt8192-imgsys2
>> @@ -107,13 +106,6 @@ examples:
>>           #clock-cells = <1>;
>>       };
>>   
>> -  - |
>> -    msdc: clock-controller@11f60000 {
>> -        compatible = "mediatek,mt8192-msdc";
>> -        reg = <0x11f60000 0x1000>;
>> -        #clock-cells = <1>;
>> -    };
>> -
>>     - |
>>       mfgcfg: clock-controller@13fbf000 {
>>           compatible = "mediatek,mt8192-mfgcfg";
>> -- 
>> 2.34.1
>>
>>

Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock

[Stephen Boyd]

Quoting Matthias Brugger (2022-05-05 09:47:30)
> 
> 
> On 03/05/2022 23:48, Rob Herring wrote:
> > On Fri, Apr 29, 2022 at 02:31:31PM +0200, matthias.bgg@kernel.org wrote:
> >> From: Matthias Brugger <matthias.bgg@gmail.com>
> >>
> >> The msdc gate is part of the MMC driver. Delete the binding description
> >> of this node.
> > 
> > An ABI break is okay because ...?
> > 
> 
> Because the code controlling the clock gate was moved to the consumer. This node 
> did never ever represent any working implementation of a peripheral. Just a 
> lonely clock gate that wasn't used.

Can you add that to the description and resend?

[PATCH v2 2/2] clk: mediatek: Delete MT8192 msdc gate

[matthias.bgg]

From: Matthias Brugger <matthias.bgg@gmail.com>

The msdc gate is part of the MMC driver. Delete the not used code.

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

---

Changes in v2:
- add Reviewed-by tag

 drivers/clk/mediatek/clk-mt8192-msdc.c | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/drivers/clk/mediatek/clk-mt8192-msdc.c b/drivers/clk/mediatek/clk-mt8192-msdc.c
index 87c3b79b79cf..635f7a0b629a 100644
--- a/drivers/clk/mediatek/clk-mt8192-msdc.c
+++ b/drivers/clk/mediatek/clk-mt8192-msdc.c
@@ -12,28 +12,15 @@
 
 #include <dt-bindings/clock/mt8192-clk.h>
 
-static const struct mtk_gate_regs msdc_cg_regs = {
-	.set_ofs = 0xb4,
-	.clr_ofs = 0xb4,
-	.sta_ofs = 0xb4,
-};
-
 static const struct mtk_gate_regs msdc_top_cg_regs = {
 	.set_ofs = 0x0,
 	.clr_ofs = 0x0,
 	.sta_ofs = 0x0,
 };
 
-#define GATE_MSDC(_id, _name, _parent, _shift)	\
-	GATE_MTK(_id, _name, _parent, &msdc_cg_regs, _shift, &mtk_clk_gate_ops_no_setclr_inv)
-
 #define GATE_MSDC_TOP(_id, _name, _parent, _shift)	\
 	GATE_MTK(_id, _name, _parent, &msdc_top_cg_regs, _shift, &mtk_clk_gate_ops_no_setclr_inv)
 
-static const struct mtk_gate msdc_clks[] = {
-	GATE_MSDC(CLK_MSDC_AXI_WRAP, "msdc_axi_wrap", "axi_sel", 22),
-};
-
 static const struct mtk_gate msdc_top_clks[] = {
 	GATE_MSDC_TOP(CLK_MSDC_TOP_AES_0P, "msdc_top_aes_0p", "aes_msdcfde_sel", 0),
 	GATE_MSDC_TOP(CLK_MSDC_TOP_SRC_0P, "msdc_top_src_0p", "infra_msdc0_src", 1),
@@ -52,11 +39,6 @@ static const struct mtk_gate msdc_top_clks[] = {
 	GATE_MSDC_TOP(CLK_MSDC_TOP_AHB2AXI_BRG_AXI, "msdc_top_ahb2axi_brg_axi", "axi_sel", 14),
 };
 
-static const struct mtk_clk_desc msdc_desc = {
-	.clks = msdc_clks,
-	.num_clks = ARRAY_SIZE(msdc_clks),
-};
-
 static const struct mtk_clk_desc msdc_top_desc = {
 	.clks = msdc_top_clks,
 	.num_clks = ARRAY_SIZE(msdc_top_clks),
@@ -64,9 +46,6 @@ static const struct mtk_clk_desc msdc_top_desc = {
 
 static const struct of_device_id of_match_clk_mt8192_msdc[] = {
 	{
-		.compatible = "mediatek,mt8192-msdc",
-		.data = &msdc_desc,
-	}, {
 		.compatible = "mediatek,mt8192-msdc_top",
 		.data = &msdc_top_desc,
 	}, {
-- 
2.34.1

Re: [PATCH v2 2/2] clk: mediatek: Delete MT8192 msdc gate

[Miles Chen]

> The msdc gate is part of the MMC driver. Delete the not used code.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Reviewed-by: Miles Chen <miles.chen@mediatek.com>