From: "José Expósito" <jose.exposito89@gmail.com>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: davidgow@google.com, dlatypov@google.com, tzimmermann@suse.de,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com,
dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, Maxime Ripard <maxime@cerno.tech>
Subject: Re: [PATCH v3 3/3] drm/doc: Add KUnit documentation
Date: Tue, 14 Jun 2022 20:09:52 +0200 [thread overview]
Message-ID: <20220614180952.GA7067@elementary> (raw)
In-Reply-To: <c50e5c87-3198-08b7-1e32-d0959af1f296@redhat.com>
Hi Javier,
On Tue, Jun 14, 2022 at 02:58:29PM +0200, Javier Martinez Canillas wrote:
> Hello José,
>
> On 6/13/22 19:17, José Expósito wrote:
>
> [snip]
>
> > +KUnit (Kernel unit testing framework) provides a common framework for unit tests
> > +within the Linux kernel.
> > +
>
> I think that it will be useful to have a reference to the KUnit kernel doc here,
> something like the following:
>
> `KUnit <https://docs.kernel.org/dev-tools/kunit/index.html>`_ (Kernel Unit...
There is a link in the next paragraph. Once the documentation is
generated the path "Documentation/dev-tools/kunit/start.rst" is
transformed into a link.
> > +This section covers the specifics for the DRM subsystem. For general information
> > +about KUnit, please refer to Documentation/dev-tools/kunit/start.rst.
> > +
> > +How to run the tests?
> > +~~~~~~~~~~~~~~~~~~~~~
> > +
> > +In order to facilitate running the test suite, a configuration file is present
> > +in ``drivers/gpu/drm/kunit/.kunitconfig``. It can be used by ``kunit.py`` as
> > +follows:
> > +
> > +.. code-block:: bash
> > +
> > + $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/kunit \
> > + --kconfig_add CONFIG_VIRTIO_UML=y \
> > + --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y
> > +
> > +.. note::
> > + The configuration included in ``.kunitconfig`` should be as generic as
> > + possible.
> > + ``CONFIG_VIRTIO_UML`` and ``CONFIG_UML_PCI_OVER_VIRTIO`` are not
> > + included in it because they are only required for User Mode Linux.
> > +
> > +
>
> Maybe also add something like this ?
>
> For example, the following command can be used to run the test for x86_64:
>
> $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/kunit \
> --arch=x86_64
I didn't want to go into much detail because the KUnit docs are
a very good resource and already explain how to run the tests in your
favorite architecture.
Since running the test on x86_64 should not change the results, I'd
prefer to keep it simple and trust the KUnit docs for the "advanced"
options.
> Regardless, the patch looks good to me:
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Thanks a lot for taking the time to review it. I'll add the tag if a v4
is required after chatting with the guys working on the AMDGPU tests.
Jose
> --
> Best regards,
>
> Javier Martinez Canillas
> Linux Engineering
> Red Hat
>
next prev parent reply other threads:[~2022-06-14 18:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 17:17 [PATCH v3 0/3] KUnit tests for drm_format_helper José Expósito
2022-06-13 17:17 ` [PATCH v3 1/3] drm/rect: Add DRM_RECT_INIT() macro José Expósito
2022-06-13 18:31 ` Jani Nikula
2022-06-13 17:17 ` [PATCH v3 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332() José Expósito
2022-06-13 17:17 ` [PATCH v3 3/3] drm/doc: Add KUnit documentation José Expósito
2022-06-14 12:58 ` Javier Martinez Canillas
2022-06-14 18:09 ` José Expósito [this message]
2022-06-14 18:14 ` Javier Martinez Canillas
2022-06-24 21:01 ` Daniel Vetter
2022-06-24 21:18 ` Javier Martinez Canillas
2022-06-27 12:36 ` José Expósito
2022-06-27 12:53 ` Javier Martinez Canillas
2022-06-14 7:08 ` [PATCH v3 0/3] KUnit tests for drm_format_helper Thomas Zimmermann
2022-06-14 13:03 ` Javier Martinez Canillas
2022-06-16 14:44 ` David Gow
2022-06-16 18:38 ` José Expósito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614180952.GA7067@elementary \
--to=jose.exposito89@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=javierm@redhat.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).