From: Javier Martinez Canillas <javierm@redhat.com>
To: "José Expósito" <jose.exposito89@gmail.com>,
davidgow@google.com, dlatypov@google.com, tzimmermann@suse.de,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@linux.ie, jani.nikula@linux.intel.com,
dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, "Maxime Ripard" <maxime@cerno.tech>
Subject: Re: [PATCH v3 3/3] drm/doc: Add KUnit documentation
Date: Fri, 24 Jun 2022 23:18:40 +0200 [thread overview]
Message-ID: <b16eba9c-30cc-c71f-ad95-eb5398f84af8@redhat.com> (raw)
In-Reply-To: <YrYmR+aCdO3ldORB@phenom.ffwll.local>
Hello Daniel,
On 6/24/22 23:01, Daniel Vetter wrote:
> On Tue, Jun 14, 2022 at 02:58:29PM +0200, Javier Martinez Canillas wrote:
>> Hello José,
>>
>> On 6/13/22 19:17, José Expósito wrote:
>>
>> [snip]
>>
>>> +KUnit (Kernel unit testing framework) provides a common framework for unit tests
>>> +within the Linux kernel.
>>> +
>>
>> I think that it will be useful to have a reference to the KUnit kernel doc here,
>> something like the following:
>>
>> `KUnit <https://docs.kernel.org/dev-tools/kunit/index.html>`_ (Kernel Unit...
>>
>>> +This section covers the specifics for the DRM subsystem. For general information
>>> +about KUnit, please refer to Documentation/dev-tools/kunit/start.rst.
>>> +
>>> +How to run the tests?
>>> +~~~~~~~~~~~~~~~~~~~~~
>>> +
>>> +In order to facilitate running the test suite, a configuration file is present
>>> +in ``drivers/gpu/drm/kunit/.kunitconfig``. It can be used by ``kunit.py`` as
>>> +follows:
>>> +
>>> +.. code-block:: bash
>>> +
>>> + $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/kunit \
>>> + --kconfig_add CONFIG_VIRTIO_UML=y \
>>> + --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y
>>> +
>>> +.. note::
>>> + The configuration included in ``.kunitconfig`` should be as generic as
>>> + possible.
>>> + ``CONFIG_VIRTIO_UML`` and ``CONFIG_UML_PCI_OVER_VIRTIO`` are not
>>> + included in it because they are only required for User Mode Linux.
>>> +
>>> +
>>
>> Maybe also add something like this ?
>>
>> For example, the following command can be used to run the test for x86_64:
>>
>> $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/kunit \
>> --arch=x86_64
>>
>> Regardless, the patch looks good to me:
>>
>> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
>
> Hey so since you have a bunch of patches merged into drm already but seem
> to lack drm-misc commit rights to push these yourself I think it's time to
> get those:
>
> https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html#drm-misc
>
> And I guess Javier can help you with any questions you might have and make
> sure the request gets through by poking folks on #dri-devel irc?
>
Yes, he already requested commit access and got the acks, so I think is
just a matter of time until he has this sorted out.
José, please don't hesitate to ask if you need any help or clarification
once you have a setup to push your patches. The dim documentation [0] is
superb but I know that it can be somewhat stressful the first time :)
[0]: https://drm.pages.freedesktop.org/maintainer-tools/dim.html
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-06-24 21:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 17:17 [PATCH v3 0/3] KUnit tests for drm_format_helper José Expósito
2022-06-13 17:17 ` [PATCH v3 1/3] drm/rect: Add DRM_RECT_INIT() macro José Expósito
2022-06-13 18:31 ` Jani Nikula
2022-06-13 17:17 ` [PATCH v3 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332() José Expósito
2022-06-13 17:17 ` [PATCH v3 3/3] drm/doc: Add KUnit documentation José Expósito
2022-06-14 12:58 ` Javier Martinez Canillas
2022-06-14 18:09 ` José Expósito
2022-06-14 18:14 ` Javier Martinez Canillas
2022-06-24 21:01 ` Daniel Vetter
2022-06-24 21:18 ` Javier Martinez Canillas [this message]
2022-06-27 12:36 ` José Expósito
2022-06-27 12:53 ` Javier Martinez Canillas
2022-06-14 7:08 ` [PATCH v3 0/3] KUnit tests for drm_format_helper Thomas Zimmermann
2022-06-14 13:03 ` Javier Martinez Canillas
2022-06-16 14:44 ` David Gow
2022-06-16 18:38 ` José Expósito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b16eba9c-30cc-c71f-ad95-eb5398f84af8@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jose.exposito89@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).