From: Thomas Zimmermann <tzimmermann@suse.de>
To: "José Expósito" <jose.exposito89@gmail.com>, javierm@redhat.com
Cc: davidgow@google.com, dlatypov@google.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com,
dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] KUnit tests for drm_format_helper
Date: Tue, 14 Jun 2022 09:08:41 +0200 [thread overview]
Message-ID: <6b5172b5-ad81-36f9-9288-fd1db2fe0e17@suse.de> (raw)
In-Reply-To: <20220613171738.111013-1-jose.exposito89@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2484 bytes --]
Hi Jose,
for the whole patchset:
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
One small detail on licensing: drm_format_helper.c is licensed under
GPL2 or MIT. Maybe consider adding 'or MIT' to drm_format_helper_test.c
as well.
Best regards
Thomas
Am 13.06.22 um 19:17 schrieb José Expósito:
> Hello everyone,
>
> Here is the v3 of the series, including the documentation, previously
> sent as a standalone patch [1], and changes suggested during review.
>
> Thanks a lot,
> José Expósito
>
> RFC -> v1: https://lore.kernel.org/dri-devel/20220530102017.471865-1-jose.exposito89@gmail.com/T/
>
> - Add .kunitconfig (Maxime Ripard)
> - Fix memory leak (Daniel Latypov)
> - Make config option generic (Javier Martinez Canillas):
> DRM_FORMAR_HELPER_TEST -> DRM_KUNIT_TEST
> - Remove DISABLE_STRUCTLEAK_PLUGIN (Daniel Latypov)
>
> v1 -> v2: https://lore.kernel.org/dri-devel/20220606095516.938934-1-jose.exposito89@gmail.com/T/
>
> Thomas Zimmermann:
> - Add DRM_RECT_INIT() macro
> - Move tests to drivers/gpu/drm/kunit
> - Improve test documentation
>
> v2 -> v3: https://lore.kernel.org/dri-devel/20220612161248.271590-1-jose.exposito89@gmail.com/T/
>
> - Use designated initializer in DRM_RECT_INIT (Jani Nikula)
> - Simplify the "conversion_buf_size" helper
>
> [1] https://lore.kernel.org/dri-devel/20220606180940.43371-1-jose.exposito89@gmail.com/T/
>
> José Expósito (3):
> drm/rect: Add DRM_RECT_INIT() macro
> drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()
> drm/doc: Add KUnit documentation
>
> Documentation/gpu/drm-internals.rst | 32 ++++
> drivers/gpu/drm/Kconfig | 16 ++
> drivers/gpu/drm/Makefile | 1 +
> drivers/gpu/drm/kunit/.kunitconfig | 3 +
> drivers/gpu/drm/kunit/Makefile | 3 +
> .../gpu/drm/kunit/drm_format_helper_test.c | 160 ++++++++++++++++++
> include/drm/drm_rect.h | 16 ++
> 7 files changed, 231 insertions(+)
> create mode 100644 drivers/gpu/drm/kunit/.kunitconfig
> create mode 100644 drivers/gpu/drm/kunit/Makefile
> create mode 100644 drivers/gpu/drm/kunit/drm_format_helper_test.c
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2022-06-14 7:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 17:17 [PATCH v3 0/3] KUnit tests for drm_format_helper José Expósito
2022-06-13 17:17 ` [PATCH v3 1/3] drm/rect: Add DRM_RECT_INIT() macro José Expósito
2022-06-13 18:31 ` Jani Nikula
2022-06-13 17:17 ` [PATCH v3 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332() José Expósito
2022-06-13 17:17 ` [PATCH v3 3/3] drm/doc: Add KUnit documentation José Expósito
2022-06-14 12:58 ` Javier Martinez Canillas
2022-06-14 18:09 ` José Expósito
2022-06-14 18:14 ` Javier Martinez Canillas
2022-06-24 21:01 ` Daniel Vetter
2022-06-24 21:18 ` Javier Martinez Canillas
2022-06-27 12:36 ` José Expósito
2022-06-27 12:53 ` Javier Martinez Canillas
2022-06-14 7:08 ` Thomas Zimmermann [this message]
2022-06-14 13:03 ` [PATCH v3 0/3] KUnit tests for drm_format_helper Javier Martinez Canillas
2022-06-16 14:44 ` David Gow
2022-06-16 18:38 ` José Expósito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b5172b5-ad81-36f9-9288-fd1db2fe0e17@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=javierm@redhat.com \
--cc=jose.exposito89@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).