From: Tinghan Shen <tinghan.shen@mediatek.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
"Will Deacon" <will@kernel.org>, Rob Herring <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Tinghan Shen" <tinghan.shen@mediatek.com>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"MandyJH Liu" <mandyjh.liu@mediatek.com>,
Weiyi Lu <weiyi.lu@mediatek.com>
Cc: <iommu@lists.linux.dev>, <linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: [PATCH v2 02/19] dt-bindings: memory: mediatek: Update condition for mt8195 smi node
Date: Thu, 14 Jul 2022 20:28:20 +0800 [thread overview]
Message-ID: <20220714122837.20094-3-tinghan.shen@mediatek.com> (raw)
In-Reply-To: <20220714122837.20094-1-tinghan.shen@mediatek.com>
The max clock items for the dts node with compatible
'mediatek,mt8195-smi-sub-common' should be 3.
However, the dtbs_check of such node will get following message,
arch/arm64/boot/dts/mediatek/mt8195-evb.dtb: smi@14010000: clock-names: ['apb', 'smi', 'gals0'] is too long
From schema: Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
It's because the 'mediatek,mt8195-smi-sub-common' compatible incorrectly
matches the 'else' conditions for gen2 HW without gals.
Rewrite the 'else' condition to specifically identify the compatibles
that utilizing gen2 HW without gals.
Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
---
.../memory-controllers/mediatek,smi-common.yaml | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
index 71bc5cefb49c..4f5dd0a20109 100644
--- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
@@ -144,7 +144,16 @@ allOf:
- const: gals0
- const: gals1
- else: # for gen2 HW that don't have gals
+ - if: # for gen2 HW that don't have gals
+ properties:
+ compatible:
+ enum:
+ - mediatek,mt2712-smi-common
+ - mediatek,mt6795-smi-common
+ - mediatek,mt8167-smi-common
+ - mediatek,mt8173-smi-common
+
+ then:
properties:
clocks:
minItems: 2
--
2.18.0
next prev parent reply other threads:[~2022-07-14 12:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 12:28 [PATCH v2 00/19] Add driver nodes for MT8195 SoC Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 01/19] dt-bindings: iommu: mediatek: Increase max interrupt number Tinghan Shen
2022-07-15 7:34 ` Krzysztof Kozlowski
2022-07-14 12:28 ` Tinghan Shen [this message]
2022-07-14 12:36 ` [PATCH v2 02/19] dt-bindings: memory: mediatek: Update condition for mt8195 smi node AngeloGioacchino Del Regno
2022-07-15 7:35 ` Krzysztof Kozlowski
2022-07-14 12:28 ` [PATCH v2 03/19] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS Tinghan Shen
2022-07-14 13:38 ` Lee Jones
2022-07-15 7:57 ` Krzysztof Kozlowski
2022-07-19 8:17 ` Tinghan Shen
2022-07-19 8:50 ` Krzysztof Kozlowski
2022-07-18 21:15 ` Rob Herring
2022-07-14 12:28 ` [PATCH v2 04/19] dt-bindings: power: mediatek: Update example in dt-bindings Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 05/19] dt-bindings: power: mediatek: Refine multiple level power domain nodes Tinghan Shen
2022-07-15 8:07 ` Krzysztof Kozlowski
2022-07-15 8:15 ` Krzysztof Kozlowski
2022-07-19 7:55 ` Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 06/19] arm64: dts: mediatek: Update mt81xx scpsys node to align with dt-bindings Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 07/19] arm64: dts: mt8195: Disable watchdog external reset signal Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 08/19] arm64: dts: mt8195: Disable I2C0 node Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 09/19] arm64: dts: mt8195: Add cpufreq node Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 10/19] arm64: dts: mt8195: Add vdosys and vppsys clock nodes Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 11/19] arm64: dts: mt8195: Add power domains controller Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 12/19] arm64: dts: mt8195: Add spmi node Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 13/19] arm64: dts: mt8195: Add scp node Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 14/19] arm64: dts: mt8195: Add audio related nodes Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 15/19] arm64: dts: mt8195: Add adsp node and adsp mailbox nodes Tinghan Shen
2022-07-14 12:35 ` AngeloGioacchino Del Regno
2022-07-14 12:28 ` [PATCH v2 16/19] arm64: dts: mt8195: Specify audio reset controller Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 17/19] arm64: dts: mt8195: Add iommu and smi nodes Tinghan Shen
[not found] ` <20220714122837.20094-20-tinghan.shen@mediatek.com>
2022-07-14 12:36 ` [PATCH v2 19/19] arm64: dts: mt8195: Add display node for vdosys0 AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714122837.20094-3-tinghan.shen@mediatek.com \
--to=tinghan.shen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chun-jie.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mandyjh.liu@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=weiyi.lu@mediatek.com \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).