From: Lee Jones <lee.jones@linaro.org>
To: Tinghan Shen <tinghan.shen@mediatek.com>
Cc: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
MandyJH Liu <mandyjh.liu@mediatek.com>,
Weiyi Lu <weiyi.lu@mediatek.com>,
iommu@lists.linux.dev, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 03/19] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS
Date: Thu, 14 Jul 2022 14:38:20 +0100 [thread overview]
Message-ID: <YtAcTCUsy9I67L3V@google.com> (raw)
In-Reply-To: <20220714122837.20094-4-tinghan.shen@mediatek.com>
Subject line should be 'mfd', rather than 'power'.
On Thu, 14 Jul 2022, Tinghan Shen wrote:
> The System Control Processor System (SCPSYS) has several power
> management related tasks in the system. Add the bindings for it.
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> .../bindings/mfd/mediatek,scpsys.yaml | 62 +++++++++++++++++++
> 1 file changed, 62 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
> new file mode 100644
> index 000000000000..a8b9220f2f27
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/mediatek,scpsys.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek System Control Processor System
> +
> +maintainers:
> + - MandyJH Liu <mandyjh.liu@mediatek.com>
> +
> +description:
> + MediaTek System Control Processor System (SCPSYS) has several
> + power management tasks. The tasks include MTCMOS power
> + domain control, thermal measurement, DVFS, etc.
> +
> +properties:
> + compatible:
> + items:
> + - const: mediatek,scpsys
> + - const: syscon
> + - const: simple-mfd
> +
> + reg:
> + maxItems: 1
> +
> + power-controller:
> + $ref: /schemas/power/mediatek,power-controller.yaml#
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/mt8195-clk.h>
> + #include <dt-bindings/power/mt8195-power.h>
> +
> + syscon@10006000 {
> + compatible = "mediatek,scpsys", "syscon", "simple-mfd";
Not sure you need bindings for this. Seems overkill.
I'll let the DT guys have the final say though.
> + reg = <0x10006000 0x100>;
> +
> + spm: power-controller {
> + compatible = "mediatek,mt8195-power-controller";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #power-domain-cells = <1>;
> +
> + /* sample of power domain nodes */
> + power-domain@MT8195_POWER_DOMAIN_PCIE_PHY {
> + reg = <MT8195_POWER_DOMAIN_PCIE_PHY>;
> + #power-domain-cells = <0>;
> + };
> +
> + power-domain@MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY {
> + reg = <MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY>;
> + #power-domain-cells = <0>;
> + };
> + };
> + };
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2022-07-14 13:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 12:28 [PATCH v2 00/19] Add driver nodes for MT8195 SoC Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 01/19] dt-bindings: iommu: mediatek: Increase max interrupt number Tinghan Shen
2022-07-15 7:34 ` Krzysztof Kozlowski
2022-07-14 12:28 ` [PATCH v2 02/19] dt-bindings: memory: mediatek: Update condition for mt8195 smi node Tinghan Shen
2022-07-14 12:36 ` AngeloGioacchino Del Regno
2022-07-15 7:35 ` Krzysztof Kozlowski
2022-07-14 12:28 ` [PATCH v2 03/19] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS Tinghan Shen
2022-07-14 13:38 ` Lee Jones [this message]
2022-07-15 7:57 ` Krzysztof Kozlowski
2022-07-19 8:17 ` Tinghan Shen
2022-07-19 8:50 ` Krzysztof Kozlowski
2022-07-18 21:15 ` Rob Herring
2022-07-14 12:28 ` [PATCH v2 04/19] dt-bindings: power: mediatek: Update example in dt-bindings Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 05/19] dt-bindings: power: mediatek: Refine multiple level power domain nodes Tinghan Shen
2022-07-15 8:07 ` Krzysztof Kozlowski
2022-07-15 8:15 ` Krzysztof Kozlowski
2022-07-19 7:55 ` Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 06/19] arm64: dts: mediatek: Update mt81xx scpsys node to align with dt-bindings Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 07/19] arm64: dts: mt8195: Disable watchdog external reset signal Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 08/19] arm64: dts: mt8195: Disable I2C0 node Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 09/19] arm64: dts: mt8195: Add cpufreq node Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 10/19] arm64: dts: mt8195: Add vdosys and vppsys clock nodes Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 11/19] arm64: dts: mt8195: Add power domains controller Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 12/19] arm64: dts: mt8195: Add spmi node Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 13/19] arm64: dts: mt8195: Add scp node Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 14/19] arm64: dts: mt8195: Add audio related nodes Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 15/19] arm64: dts: mt8195: Add adsp node and adsp mailbox nodes Tinghan Shen
2022-07-14 12:35 ` AngeloGioacchino Del Regno
2022-07-14 12:28 ` [PATCH v2 16/19] arm64: dts: mt8195: Specify audio reset controller Tinghan Shen
2022-07-14 12:28 ` [PATCH v2 17/19] arm64: dts: mt8195: Add iommu and smi nodes Tinghan Shen
[not found] ` <20220714122837.20094-20-tinghan.shen@mediatek.com>
2022-07-14 12:36 ` [PATCH v2 19/19] arm64: dts: mt8195: Add display node for vdosys0 AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtAcTCUsy9I67L3V@google.com \
--to=lee.jones@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chun-jie.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mandyjh.liu@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tinghan.shen@mediatek.com \
--cc=weiyi.lu@mediatek.com \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).