* [PATCH] media: staging: media: zoran: Removed braces for single statement block
@ 2022-07-21 15:00 Abhijeet Srivastava
2022-07-22 4:54 ` Philipp Hortmann
2022-08-24 9:48 ` Hans Verkuil
0 siblings, 2 replies; 3+ messages in thread
From: Abhijeet Srivastava @ 2022-07-21 15:00 UTC (permalink / raw)
Cc: abhijeet.srivastava2308, Corentin Labbe, Mauro Carvalho Chehab,
Greg Kroah-Hartman, mjpeg-users, linux-media, linux-staging,
linux-kernel
Warning found by checkpatch.pl script.
Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
---
drivers/staging/media/zoran/zoran_card.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c b/drivers/staging/media/zoran/zoran_card.c
index 26f978a1cc72..0c138d47d0c3 100644
--- a/drivers/staging/media/zoran/zoran_card.c
+++ b/drivers/staging/media/zoran/zoran_card.c
@@ -1038,9 +1038,9 @@ static int zr36057_init(struct zoran *zr)
zr->stat_com = dma_alloc_coherent(&zr->pci_dev->dev,
BUZ_NUM_STAT_COM * sizeof(u32),
&zr->p_sc, GFP_KERNEL);
- if (!zr->stat_com) {
+ if (!zr->stat_com)
return -ENOMEM;
- }
+
for (j = 0; j < BUZ_NUM_STAT_COM; j++)
zr->stat_com[j] = cpu_to_le32(1); /* mark as unavailable to zr36057 */
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: staging: media: zoran: Removed braces for single statement block
2022-07-21 15:00 [PATCH] media: staging: media: zoran: Removed braces for single statement block Abhijeet Srivastava
@ 2022-07-22 4:54 ` Philipp Hortmann
2022-08-24 9:48 ` Hans Verkuil
1 sibling, 0 replies; 3+ messages in thread
From: Philipp Hortmann @ 2022-07-22 4:54 UTC (permalink / raw)
To: Abhijeet Srivastava
Cc: Corentin Labbe, Mauro Carvalho Chehab, Greg Kroah-Hartman,
mjpeg-users, linux-media, linux-staging, linux-kernel
On 7/21/22 17:00, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script.
>
> Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
> ---
> drivers/staging/media/zoran/zoran_card.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/zoran/zoran_card.c b/drivers/staging/media/zoran/zoran_card.c
> index 26f978a1cc72..0c138d47d0c3 100644
> --- a/drivers/staging/media/zoran/zoran_card.c
> +++ b/drivers/staging/media/zoran/zoran_card.c
> @@ -1038,9 +1038,9 @@ static int zr36057_init(struct zoran *zr)
> zr->stat_com = dma_alloc_coherent(&zr->pci_dev->dev,
> BUZ_NUM_STAT_COM * sizeof(u32),
> &zr->p_sc, GFP_KERNEL);
> - if (!zr->stat_com) {
> + if (!zr->stat_com)
> return -ENOMEM;
> - }
> +
> for (j = 0; j < BUZ_NUM_STAT_COM; j++)
> zr->stat_com[j] = cpu_to_le32(1); /* mark as unavailable to zr36057 */
>
Why does the subject line start with "media:" The subsystem is
"staging:" so the subject should start with "staging: media: ..."
I have no clue if this is accepted.
Regards,
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: staging: media: zoran: Removed braces for single statement block
2022-07-21 15:00 [PATCH] media: staging: media: zoran: Removed braces for single statement block Abhijeet Srivastava
2022-07-22 4:54 ` Philipp Hortmann
@ 2022-08-24 9:48 ` Hans Verkuil
1 sibling, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2022-08-24 9:48 UTC (permalink / raw)
To: Abhijeet Srivastava
Cc: Corentin Labbe, Mauro Carvalho Chehab, Greg Kroah-Hartman,
mjpeg-users, linux-media, linux-staging, linux-kernel
Hi Abhijeet,
Thank you for the zoran patches, unfortunately these are a duplicate of
https://patchwork.linuxtv.org/project/linux-media/patch/20220810115445.2302477-2-hverkuil-cisco@xs4all.nl/
I wish I'd noticed your patches earlier, it would have saved me some work :-(
I'm marking your patches Obsoleted in patchwork.
Regards,
Hans
On 21/07/2022 17:00, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script.
>
> Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
> ---
> drivers/staging/media/zoran/zoran_card.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/zoran/zoran_card.c b/drivers/staging/media/zoran/zoran_card.c
> index 26f978a1cc72..0c138d47d0c3 100644
> --- a/drivers/staging/media/zoran/zoran_card.c
> +++ b/drivers/staging/media/zoran/zoran_card.c
> @@ -1038,9 +1038,9 @@ static int zr36057_init(struct zoran *zr)
> zr->stat_com = dma_alloc_coherent(&zr->pci_dev->dev,
> BUZ_NUM_STAT_COM * sizeof(u32),
> &zr->p_sc, GFP_KERNEL);
> - if (!zr->stat_com) {
> + if (!zr->stat_com)
> return -ENOMEM;
> - }
> +
> for (j = 0; j < BUZ_NUM_STAT_COM; j++)
> zr->stat_com[j] = cpu_to_le32(1); /* mark as unavailable to zr36057 */
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-24 9:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-21 15:00 [PATCH] media: staging: media: zoran: Removed braces for single statement block Abhijeet Srivastava
2022-07-22 4:54 ` Philipp Hortmann
2022-08-24 9:48 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).