* [PATCH] media: staging: media: zoran: Deleted dead code
@ 2022-07-22 18:26 Abhijeet Srivastava
2022-07-22 18:52 ` Philipp Hortmann
0 siblings, 1 reply; 3+ messages in thread
From: Abhijeet Srivastava @ 2022-07-22 18:26 UTC (permalink / raw)
Cc: abhijeet.srivastava2308, Corentin Labbe, Mauro Carvalho Chehab,
Greg Kroah-Hartman, mjpeg-users, linux-media, linux-staging,
linux-kernel
Deleted part of code in block comment
Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
---
drivers/staging/media/zoran/zoran_driver.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
index b408c1d4e0a7..836edf623571 100644
--- a/drivers/staging/media/zoran/zoran_driver.c
+++ b/drivers/staging/media/zoran/zoran_driver.c
@@ -746,11 +746,6 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
.vidioc_enum_input = zoran_enum_input,
.vidioc_g_input = zoran_g_input,
.vidioc_s_input = zoran_s_input,
-
-/* .vidioc_enum_output = zoran_enum_output,
- * .vidioc_g_output = zoran_g_output,
- * .vidioc_s_output = zoran_s_output,
- */
.vidioc_g_std = zoran_g_std,
.vidioc_s_std = zoran_s_std,
.vidioc_create_bufs = vb2_ioctl_create_bufs,
@@ -762,13 +757,9 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
.vidioc_streamon = vb2_ioctl_streamon,
.vidioc_streamoff = vb2_ioctl_streamoff,
.vidioc_enum_fmt_vid_cap = zoran_enum_fmt_vid_cap,
-/* .vidioc_enum_fmt_vid_out = zoran_enum_fmt_vid_out,*/
.vidioc_g_fmt_vid_cap = zoran_g_fmt_vid_cap,
-/* .vidioc_g_fmt_vid_out = zoran_g_fmt_vid_out,*/
.vidioc_s_fmt_vid_cap = zoran_s_fmt_vid_cap,
-/* .vidioc_s_fmt_vid_out = zoran_s_fmt_vid_out,*/
.vidioc_try_fmt_vid_cap = zoran_try_fmt_vid_cap,
-/* .vidioc_try_fmt_vid_out = zoran_try_fmt_vid_out,*/
.vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
.vidioc_unsubscribe_event = v4l2_event_unsubscribe,
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] media: staging: media: zoran: Deleted dead code
2022-07-22 18:26 [PATCH] media: staging: media: zoran: Deleted dead code Abhijeet Srivastava
@ 2022-07-22 18:52 ` Philipp Hortmann
2022-07-22 19:25 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 3+ messages in thread
From: Philipp Hortmann @ 2022-07-22 18:52 UTC (permalink / raw)
To: Abhijeet Srivastava
Cc: Corentin Labbe, Mauro Carvalho Chehab, Greg Kroah-Hartman,
mjpeg-users, linux-media, linux-staging, linux-kernel
On 7/22/22 20:26, Abhijeet Srivastava wrote:
> Deleted part of code in block comment
>
> Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
> ---
> drivers/staging/media/zoran/zoran_driver.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
> index b408c1d4e0a7..836edf623571 100644
> --- a/drivers/staging/media/zoran/zoran_driver.c
> +++ b/drivers/staging/media/zoran/zoran_driver.c
> @@ -746,11 +746,6 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
> .vidioc_enum_input = zoran_enum_input,
> .vidioc_g_input = zoran_g_input,
> .vidioc_s_input = zoran_s_input,
> -
> -/* .vidioc_enum_output = zoran_enum_output,
> - * .vidioc_g_output = zoran_g_output,
> - * .vidioc_s_output = zoran_s_output,
> - */
> .vidioc_g_std = zoran_g_std,
> .vidioc_s_std = zoran_s_std,
> .vidioc_create_bufs = vb2_ioctl_create_bufs,
> @@ -762,13 +757,9 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
> .vidioc_streamon = vb2_ioctl_streamon,
> .vidioc_streamoff = vb2_ioctl_streamoff,
> .vidioc_enum_fmt_vid_cap = zoran_enum_fmt_vid_cap,
> -/* .vidioc_enum_fmt_vid_out = zoran_enum_fmt_vid_out,*/
> .vidioc_g_fmt_vid_cap = zoran_g_fmt_vid_cap,
> -/* .vidioc_g_fmt_vid_out = zoran_g_fmt_vid_out,*/
> .vidioc_s_fmt_vid_cap = zoran_s_fmt_vid_cap,
> -/* .vidioc_s_fmt_vid_out = zoran_s_fmt_vid_out,*/
> .vidioc_try_fmt_vid_cap = zoran_try_fmt_vid_cap,
> -/* .vidioc_try_fmt_vid_out = zoran_try_fmt_vid_out,*/
> .vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
> .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
> };
Why does the subject line start with "media:" The subsystem is
"staging:" so the subject should start with "staging: media: ..."
I have no clue if this is accepted.
Regards,
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: staging: media: zoran: Deleted dead code
2022-07-22 18:52 ` Philipp Hortmann
@ 2022-07-22 19:25 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2022-07-22 19:25 UTC (permalink / raw)
To: Philipp Hortmann
Cc: Abhijeet Srivastava, Corentin Labbe, Greg Kroah-Hartman,
mjpeg-users, linux-media, linux-staging, linux-kernel
Em Fri, 22 Jul 2022 20:52:29 +0200
Philipp Hortmann <philipp.g.hortmann@gmail.com> escreveu:
> On 7/22/22 20:26, Abhijeet Srivastava wrote:
> > Deleted part of code in block comment
> >
> > Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
> > ---
> > drivers/staging/media/zoran/zoran_driver.c | 9 ---------
> > 1 file changed, 9 deletions(-)
> >
> > diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
> > index b408c1d4e0a7..836edf623571 100644
> > --- a/drivers/staging/media/zoran/zoran_driver.c
> > +++ b/drivers/staging/media/zoran/zoran_driver.c
> > @@ -746,11 +746,6 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
> > .vidioc_enum_input = zoran_enum_input,
> > .vidioc_g_input = zoran_g_input,
> > .vidioc_s_input = zoran_s_input,
> > -
> > -/* .vidioc_enum_output = zoran_enum_output,
> > - * .vidioc_g_output = zoran_g_output,
> > - * .vidioc_s_output = zoran_s_output,
> > - */
> > .vidioc_g_std = zoran_g_std,
> > .vidioc_s_std = zoran_s_std,
> > .vidioc_create_bufs = vb2_ioctl_create_bufs,
> > @@ -762,13 +757,9 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
> > .vidioc_streamon = vb2_ioctl_streamon,
> > .vidioc_streamoff = vb2_ioctl_streamoff,
> > .vidioc_enum_fmt_vid_cap = zoran_enum_fmt_vid_cap,
> > -/* .vidioc_enum_fmt_vid_out = zoran_enum_fmt_vid_out,*/
> > .vidioc_g_fmt_vid_cap = zoran_g_fmt_vid_cap,
> > -/* .vidioc_g_fmt_vid_out = zoran_g_fmt_vid_out,*/
> > .vidioc_s_fmt_vid_cap = zoran_s_fmt_vid_cap,
> > -/* .vidioc_s_fmt_vid_out = zoran_s_fmt_vid_out,*/
> > .vidioc_try_fmt_vid_cap = zoran_try_fmt_vid_cap,
> > -/* .vidioc_try_fmt_vid_out = zoran_try_fmt_vid_out,*/
> > .vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
> > .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
> > };
>
> Why does the subject line start with "media:" The subsystem is
> "staging:" so the subject should start with "staging: media: ..."
>
> I have no clue if this is accepted.
The subsystem is media. The drivers for both drivers/media and
drivers/staging/media have the same maintainers. The "staging" is
just a place where we place stuff that are either not ready for
upstream or are under deprecation.
So, we expect that all subjects start with media:. I prefer if
they don't have "staging" at the subject, as makes the driver
logs more coherent when they're moved in/out staging dir.
Regards,
Mauro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-22 19:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-22 18:26 [PATCH] media: staging: media: zoran: Deleted dead code Abhijeet Srivastava
2022-07-22 18:52 ` Philipp Hortmann
2022-07-22 19:25 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).