[PATCH] drivers: android: binder: Fixed coding style issue

[PATCH] drivers: android: binder: Fixed coding style issue

[Alix Dixon]

Fixed issue with comments on multiple lines not being aligned correctly + multiline comments not being on multiple lines

Signed-off-by: Alix Dixon <notdixon.alix@gmail.com>
---
 drivers/android/binder.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index c964d7c8c..5a6da6765 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -5289,8 +5289,10 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 	unsigned int size = _IOC_SIZE(cmd);
 	void __user *ubuf = (void __user *)arg;
 
-	/*pr_info("binder_ioctl: %d:%d %x %lx\n",
-			proc->pid, current->pid, cmd, arg);*/
+	/*
+	 * pr_info("binder_ioctl: %d:%d %x %lx\n",
+	 *		proc->pid, current->pid, cmd, arg);
+	 */
 
 	binder_selftest_alloc(&proc->alloc);
 
@@ -6544,8 +6546,8 @@ static int __init binder_init(void)
 	if (!IS_ENABLED(CONFIG_ANDROID_BINDERFS) &&
 	    strcmp(binder_devices_param, "") != 0) {
 		/*
-		* Copy the module_parameter string, because we don't want to
-		* tokenize it in-place.
+		 * Copy the module_parameter string, because we don't want to
+		 * tokenize it in-place.
 		 */
 		device_names = kstrdup(binder_devices_param, GFP_KERNEL);
 		if (!device_names) {
-- 
2.34.1

Re: [PATCH] drivers: android: binder: Fixed coding style issue

[Greg KH]

On Fri, Aug 05, 2022 at 02:06:11PM +0100, Alix Dixon wrote:
> Fixed issue with comments on multiple lines not being aligned correctly + multiline comments not being on multiple lines

The irony of a changelog about not wrapping lines properly having an
inproper wrapped line is not lost on me :)

> 
> Signed-off-by: Alix Dixon <notdixon.alix@gmail.com>

Any reason you didn't cc: all of the proper people that
scripts/get_maintainer.pl told you to cc?  This driver does have very
active maintainers.

> ---
>  drivers/android/binder.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index c964d7c8c..5a6da6765 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -5289,8 +5289,10 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>  	unsigned int size = _IOC_SIZE(cmd);
>  	void __user *ubuf = (void __user *)arg;
>  
> -	/*pr_info("binder_ioctl: %d:%d %x %lx\n",
> -			proc->pid, current->pid, cmd, arg);*/
> +	/*
> +	 * pr_info("binder_ioctl: %d:%d %x %lx\n",
> +	 *		proc->pid, current->pid, cmd, arg);
> +	 */

There's nothing wrong with the original code here.

Please fix up and resend.

thanks,

greg k-h