From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Marcus Folkesson <marcus.folkesson@gmail.com>,
Kent Gustavsson <kent@minoris.se>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-iio <linux-iio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 4/9] iio: adc: mcp3911: use resource-managed version of iio_device_register
Date: Sun, 14 Aug 2022 15:27:19 +0100 [thread overview]
Message-ID: <20220814152719.17597442@jic23-huawei> (raw)
In-Reply-To: <CAHp75VdhdpKasyYrb1tkhL6yjfZwMcbWJYNc9bw8LDr7KLT6jw@mail.gmail.com>
On Tue, 9 Aug 2022 11:40:55 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Tue, Aug 9, 2022 at 11:39 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>
> ...
>
> > You may rather switch to devm_clk_get_enabled() and drop this.
>
> While doing this I would recommend to split the regulator case and clock case.
>
Hi Andy,
I read this and wasn't quite sure what you meant. Do you mean splitting
it into multiple patches?
If so I think that is probably taking "one thing one patch" a step too far.
I wouldn't object it if were presented as separate patches, but I'm not
sure I'd bother splitting them.
Definitely good to switch to devm_clk_get_enabled() now that's available.
There is another go at adding devm_regulator_enable() under review at the
moment, but we can tidy that up as a follow on patch (along with the 100s of
other cases in IIO!)
Jonathan
next prev parent reply other threads:[~2022-08-14 14:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 7:36 [PATCH v5 0/9] Improve MCP3911 driver Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 1/9] iio: adc: mcp3911: make use of the sign bit Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 2/9] iio: adc: mcp3911: correct "microchip,device-addr" property Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 3/9] iio: adc: mcp3911: use correct formula for AD conversion Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 4/9] iio: adc: mcp3911: use resource-managed version of iio_device_register Marcus Folkesson
2022-08-09 9:39 ` Andy Shevchenko
2022-08-09 9:40 ` Andy Shevchenko
2022-08-14 14:27 ` Jonathan Cameron [this message]
2022-08-09 7:36 ` [PATCH v5 5/9] iio: adc: mcp3911: add support for buffers Marcus Folkesson
2022-08-09 9:52 ` Andy Shevchenko
2022-08-14 14:31 ` Jonathan Cameron
2022-08-09 7:36 ` [PATCH v5 6/9] iio: adc: mcp3911: add support for interrupts Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 7/9] dt-bindings: iio: adc: mcp3911: add microchip,data-ready-hiz entry Marcus Folkesson
2022-08-09 9:57 ` Andy Shevchenko
2022-08-15 6:07 ` Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 8/9] iio: adc: mcp3911: add support for oversampling ratio Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 9/9] iio: adc: mcp3911: add support to set PGA Marcus Folkesson
2022-08-14 14:34 ` [PATCH v5 0/9] Improve MCP3911 driver Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220814152719.17597442@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kent@minoris.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).