From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Kent Gustavsson <kent@minoris.se>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-iio <linux-iio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v5 7/9] dt-bindings: iio: adc: mcp3911: add microchip,data-ready-hiz entry
Date: Tue, 9 Aug 2022 11:57:19 +0200 [thread overview]
Message-ID: <CAHp75VerfFgNKRbE=f0LnpRBr1o=qNwSnUkzq69BeECJFY9Vvw@mail.gmail.com> (raw)
In-Reply-To: <20220809073648.167821-8-marcus.folkesson@gmail.com>
On Tue, Aug 9, 2022 at 9:32 AM Marcus Folkesson
<marcus.folkesson@gmail.com> wrote:
>
> The Data Ready Output Pin is either hard wired to work as high
> impedance or push-pull. Make it configurable.
...
> + description:
> + Data Ready Pin Inactive State Control
> + true = The DR pin state is high-impedance when data are NOT ready
> + false = The DR pin state is a logic high when data are NOT ready
Wouldn't be better to move " when data are NOT ready" to the main
description text:
Data Ready Pin Inactive State Control when data are NOT ready
In this case it unloads the list and moves focus from the part of "NOT
ready" to the real part of what you pointed out here --
"high-impedance" or "high".
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-08-09 9:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 7:36 [PATCH v5 0/9] Improve MCP3911 driver Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 1/9] iio: adc: mcp3911: make use of the sign bit Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 2/9] iio: adc: mcp3911: correct "microchip,device-addr" property Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 3/9] iio: adc: mcp3911: use correct formula for AD conversion Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 4/9] iio: adc: mcp3911: use resource-managed version of iio_device_register Marcus Folkesson
2022-08-09 9:39 ` Andy Shevchenko
2022-08-09 9:40 ` Andy Shevchenko
2022-08-14 14:27 ` Jonathan Cameron
2022-08-09 7:36 ` [PATCH v5 5/9] iio: adc: mcp3911: add support for buffers Marcus Folkesson
2022-08-09 9:52 ` Andy Shevchenko
2022-08-14 14:31 ` Jonathan Cameron
2022-08-09 7:36 ` [PATCH v5 6/9] iio: adc: mcp3911: add support for interrupts Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 7/9] dt-bindings: iio: adc: mcp3911: add microchip,data-ready-hiz entry Marcus Folkesson
2022-08-09 9:57 ` Andy Shevchenko [this message]
2022-08-15 6:07 ` Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 8/9] iio: adc: mcp3911: add support for oversampling ratio Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 9/9] iio: adc: mcp3911: add support to set PGA Marcus Folkesson
2022-08-14 14:34 ` [PATCH v5 0/9] Improve MCP3911 driver Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VerfFgNKRbE=f0LnpRBr1o=qNwSnUkzq69BeECJFY9Vvw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kent@minoris.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).