From: Jonathan Cameron <jic23@kernel.org>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Kent Gustavsson <kent@minoris.se>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/9] Improve MCP3911 driver
Date: Sun, 14 Aug 2022 15:34:47 +0100 [thread overview]
Message-ID: <20220814153447.2e9b512a@jic23-huawei> (raw)
In-Reply-To: <20220809073648.167821-1-marcus.folkesson@gmail.com>
On Tue, 9 Aug 2022 09:36:39 +0200
Marcus Folkesson <marcus.folkesson@gmail.com> wrote:
> Hi,
>
> This patch series intend to fix bugs and improve functionality of the MCP3911 driver.
> The main features added are
> - Support for buffers
> - Interrupt driven readings
> - Support for oversampling ratio
> - Support for set scale values (Gain)
>
> Among the bug fixes, there are changes in the formula for calculate raw value and a fix for mismatch in the devicetree property.
>
> Another general improvement for the driver is to use managed resources for all allocated resources.
>
Given requested changes from Andy and I were all small, I would normally
have just made them whilst applying. However, patches 1-3 still need
to work their way through as fixes to be upstream so we can't merge the
rest yet anyway.
Looks good to me in general, just those little things to tidy up in a v6.
Thanks,
Jonathan
> General changes for the series:
>
> v3:
> - Drop Phase patch
> - Add Fixes tags for those patches that are fixes
> - Move Fixes patches to the beginning of the patchset
>
> v4:
> - Split up devm-cleanup functions
> - Cosmetic cleanups
> - Add
> select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> To Kconfig
> - Add .endianness = IIO_BE
>
> v5:
> - Drop remove function
> - Split tx&rx transfers in mcp3911_trigger_handler()
> - Moved Kconfig changes to right patch
>
>
> Best regards,
> Marcus Folkesson
>
>
prev parent reply other threads:[~2022-08-14 14:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 7:36 [PATCH v5 0/9] Improve MCP3911 driver Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 1/9] iio: adc: mcp3911: make use of the sign bit Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 2/9] iio: adc: mcp3911: correct "microchip,device-addr" property Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 3/9] iio: adc: mcp3911: use correct formula for AD conversion Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 4/9] iio: adc: mcp3911: use resource-managed version of iio_device_register Marcus Folkesson
2022-08-09 9:39 ` Andy Shevchenko
2022-08-09 9:40 ` Andy Shevchenko
2022-08-14 14:27 ` Jonathan Cameron
2022-08-09 7:36 ` [PATCH v5 5/9] iio: adc: mcp3911: add support for buffers Marcus Folkesson
2022-08-09 9:52 ` Andy Shevchenko
2022-08-14 14:31 ` Jonathan Cameron
2022-08-09 7:36 ` [PATCH v5 6/9] iio: adc: mcp3911: add support for interrupts Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 7/9] dt-bindings: iio: adc: mcp3911: add microchip,data-ready-hiz entry Marcus Folkesson
2022-08-09 9:57 ` Andy Shevchenko
2022-08-15 6:07 ` Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 8/9] iio: adc: mcp3911: add support for oversampling ratio Marcus Folkesson
2022-08-09 7:36 ` [PATCH v5 9/9] iio: adc: mcp3911: add support to set PGA Marcus Folkesson
2022-08-14 14:34 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220814153447.2e9b512a@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kent@minoris.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).