* [PATCH v1 00/19] Fix dma_map_sg error check
@ 2022-08-19 6:07 Jack Wang
2022-08-19 6:07 ` [PATCH v1 01/19] mailbox: bcm-ferxrm-mailbox: Fix error check for dma_map_sg Jack Wang
` (18 more replies)
0 siblings, 19 replies; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel
Hi, all,
While working on a bugfix on RTRS[1], I noticed there are quite a few other
drivers have the same problem, due to the fact dma_map_sg return 0 on error,
not like most of the cases, return negative value for error.
I "grep -A 5 dma_map_sg' in kernel tree, and audit/fix the one I feel is buggy,
hence this serry. All the patch are independent, so can go either through the
maintainer tree once it is reviewed.
Thanks!
[1] https://lore.kernel.org/linux-rdma/20220818105355.110344-1-haris.iqbal@ionos.com/T/#t
Jack Wang (19):
mailbox: bcm-ferxrm-mailbox: Fix error check for dma_map_sg
infiniband/mthca: Fix dma_map_sg error check
HSI: omap_ssi_port: Fix dma_map_sg error check
mtd: rawnand: stm32_fmc2: Fix dma_map_sg error check
mtd: rawnand: marvell: Fix error handle regarding dma_map_sg
usb/hcd: Fix dma_map_sg error check
crypto: gemin: Fix error check for dma_map_sg
crypto: sahara: Fix error check for dma_map_sg
crypto: qce: Fix dma_map_sg error check
crypto: amlogic: Fix dma_map_sg error check
crypto: allwinner: Fix dma_map_sg error check
crypto: ccree: Fix dma_map_sg error check
intel_th: Fix dma_map_sg error check
nvme-rdma: Fix error check for ib_dma_map_sg
nvme-fc: Fix the error check for dma_map_sg
scsi/qlogicpti: Fix dma_map_sg check
mmc: meson-mx-sdhc: Fix error check for dma_map_sg
mmc: jz4740_mmc: Fix error check for dma_map_sg
net/mlx4: Fix error check for dma_map_sg
drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 6 +++---
drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c | 2 +-
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 4 ++--
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 2 +-
drivers/crypto/amlogic/amlogic-gxl-cipher.c | 6 +++---
drivers/crypto/ccree/cc_buffer_mgr.c | 2 +-
drivers/crypto/gemini/sl3516-ce-cipher.c | 6 +++---
drivers/crypto/qce/aead.c | 4 ++--
drivers/crypto/qce/sha.c | 8 +++++---
drivers/crypto/qce/skcipher.c | 8 ++++----
drivers/crypto/sahara.c | 4 ++--
drivers/hsi/controllers/omap_ssi_port.c | 8 ++++----
drivers/hwtracing/intel_th/msu.c | 2 +-
drivers/infiniband/hw/mthca/mthca_memfree.c | 7 ++++---
drivers/mailbox/bcm-flexrm-mailbox.c | 8 ++++----
drivers/mmc/host/jz4740_mmc.c | 2 +-
drivers/mmc/host/meson-mx-sdhc-mmc.c | 2 +-
drivers/mtd/nand/raw/marvell_nand.c | 8 +++++++-
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 8 +++++---
drivers/net/ethernet/mellanox/mlx4/icm.c | 4 ++--
drivers/nvme/host/fc.c | 2 +-
drivers/nvme/host/rdma.c | 4 ++--
drivers/nvme/target/fc.c | 5 +++++
drivers/scsi/qlogicpti.c | 3 ++-
drivers/usb/core/hcd.c | 2 +-
25 files changed, 67 insertions(+), 50 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 43+ messages in thread
* [PATCH v1 01/19] mailbox: bcm-ferxrm-mailbox: Fix error check for dma_map_sg
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-22 5:07 ` Dan Carpenter
2022-08-19 6:07 ` [PATCH v1 02/19] infiniband/mthca: Fix dma_map_sg error check Jack Wang
` (17 subsequent siblings)
18 siblings, 1 reply; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel; +Cc: Jassi Brar
dma_map_sg return 0 on error, fix the error check, and return -EIO
to caller.
Cc: Jassi Brar <jassisinghbrar@gmail.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/mailbox/bcm-flexrm-mailbox.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
index fda16f76401e..bf6e86b0ed09 100644
--- a/drivers/mailbox/bcm-flexrm-mailbox.c
+++ b/drivers/mailbox/bcm-flexrm-mailbox.c
@@ -622,15 +622,15 @@ static int flexrm_spu_dma_map(struct device *dev, struct brcm_message *msg)
rc = dma_map_sg(dev, msg->spu.src, sg_nents(msg->spu.src),
DMA_TO_DEVICE);
- if (rc < 0)
- return rc;
+ if (!rc)
+ return -EIO;
rc = dma_map_sg(dev, msg->spu.dst, sg_nents(msg->spu.dst),
DMA_FROM_DEVICE);
- if (rc < 0) {
+ if (!rc) {
dma_unmap_sg(dev, msg->spu.src, sg_nents(msg->spu.src),
DMA_TO_DEVICE);
- return rc;
+ return -EIO;
}
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 02/19] infiniband/mthca: Fix dma_map_sg error check
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
2022-08-19 6:07 ` [PATCH v1 01/19] mailbox: bcm-ferxrm-mailbox: Fix error check for dma_map_sg Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-19 22:19 ` Kees Cook
` (2 more replies)
2022-08-19 6:07 ` [PATCH v1 03/19] HSI: omap_ssi_port: " Jack Wang
` (16 subsequent siblings)
18 siblings, 3 replies; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel
Cc: Jason Gunthorpe, Leon Romanovsky, Christophe JAILLET, Kees Cook,
Håkon Bugge, linux-rdma
dma_map_sg return 0 on error, in case of error set
EIO as return code.
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Kees Cook <keescook@chromium.org>
Cc: "Håkon Bugge" <haakon.bugge@oracle.com>
Cc: linux-rdma@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/infiniband/hw/mthca/mthca_memfree.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/mthca/mthca_memfree.c b/drivers/infiniband/hw/mthca/mthca_memfree.c
index f2734a5c5f26..44fd5fdf64d5 100644
--- a/drivers/infiniband/hw/mthca/mthca_memfree.c
+++ b/drivers/infiniband/hw/mthca/mthca_memfree.c
@@ -189,7 +189,7 @@ struct mthca_icm *mthca_alloc_icm(struct mthca_dev *dev, int npages,
chunk->npages,
DMA_BIDIRECTIONAL);
- if (chunk->nsg <= 0)
+ if (!chunk->nsg)
goto fail;
}
@@ -208,7 +208,7 @@ struct mthca_icm *mthca_alloc_icm(struct mthca_dev *dev, int npages,
chunk->nsg = dma_map_sg(&dev->pdev->dev, chunk->mem,
chunk->npages, DMA_BIDIRECTIONAL);
- if (chunk->nsg <= 0)
+ if (!chunk->nsg)
goto fail;
}
@@ -482,8 +482,9 @@ int mthca_map_user_db(struct mthca_dev *dev, struct mthca_uar *uar,
ret = dma_map_sg(&dev->pdev->dev, &db_tab->page[i].mem, 1,
DMA_TO_DEVICE);
- if (ret < 0) {
+ if (!ret) {
unpin_user_page(pages[0]);
+ ret = -EIO;
goto out;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 03/19] HSI: omap_ssi_port: Fix dma_map_sg error check
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
2022-08-19 6:07 ` [PATCH v1 01/19] mailbox: bcm-ferxrm-mailbox: Fix error check for dma_map_sg Jack Wang
2022-08-19 6:07 ` [PATCH v1 02/19] infiniband/mthca: Fix dma_map_sg error check Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-19 6:07 ` [PATCH v1 04/19] mtd: rawnand: stm32_fmc2: " Jack Wang
` (15 subsequent siblings)
18 siblings, 0 replies; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel; +Cc: Sebastian Reichel
dma_map_sg return 0 on error, in case of error return -EIO
to caller.
Cc: Sebastian Reichel <sre@kernel.org>
Cc: linux-kernel@vger.kernel.org (open list)
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/hsi/controllers/omap_ssi_port.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_port.c
index a0cb5be246e1..b9495b720f1b 100644
--- a/drivers/hsi/controllers/omap_ssi_port.c
+++ b/drivers/hsi/controllers/omap_ssi_port.c
@@ -230,10 +230,10 @@ static int ssi_start_dma(struct hsi_msg *msg, int lch)
if (msg->ttype == HSI_MSG_READ) {
err = dma_map_sg(&ssi->device, msg->sgt.sgl, msg->sgt.nents,
DMA_FROM_DEVICE);
- if (err < 0) {
+ if (!err) {
dev_dbg(&ssi->device, "DMA map SG failed !\n");
pm_runtime_put_autosuspend(omap_port->pdev);
- return err;
+ return -EIO;
}
csdp = SSI_DST_BURST_4x32_BIT | SSI_DST_MEMORY_PORT |
SSI_SRC_SINGLE_ACCESS0 | SSI_SRC_PERIPHERAL_PORT |
@@ -247,10 +247,10 @@ static int ssi_start_dma(struct hsi_msg *msg, int lch)
} else {
err = dma_map_sg(&ssi->device, msg->sgt.sgl, msg->sgt.nents,
DMA_TO_DEVICE);
- if (err < 0) {
+ if (!err) {
dev_dbg(&ssi->device, "DMA map SG failed !\n");
pm_runtime_put_autosuspend(omap_port->pdev);
- return err;
+ return -EIO;
}
csdp = SSI_SRC_BURST_4x32_BIT | SSI_SRC_MEMORY_PORT |
SSI_DST_SINGLE_ACCESS0 | SSI_DST_PERIPHERAL_PORT |
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 04/19] mtd: rawnand: stm32_fmc2: Fix dma_map_sg error check
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (2 preceding siblings ...)
2022-08-19 6:07 ` [PATCH v1 03/19] HSI: omap_ssi_port: " Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-23 7:49 ` Christophe Kerello
2022-09-20 8:34 ` Miquel Raynal
2022-08-19 6:07 ` [PATCH v1 05/19] mtd: rawnand: marvell: Fix error handle regarding dma_map_sg Jack Wang
` (14 subsequent siblings)
18 siblings, 2 replies; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Maxime Coquelin, Alexandre Torgue, Philipp Zabel,
Christophe Kerello, Cai Huoqing, linux-mtd, linux-stm32,
linux-arm-kernel
dma_map_sg return 0 on error, in case of error return -EIO.
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Christophe Kerello <christophe.kerello@foss.st.com>
Cc: Cai Huoqing <cai.huoqing@linux.dev>
Cc: linux-mtd@lists.infradead.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
index 87c1c7dd97eb..a0c825af19fa 100644
--- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
+++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
@@ -862,8 +862,8 @@ static int stm32_fmc2_nfc_xfer(struct nand_chip *chip, const u8 *buf,
ret = dma_map_sg(nfc->dev, nfc->dma_data_sg.sgl,
eccsteps, dma_data_dir);
- if (ret < 0)
- return ret;
+ if (!ret)
+ return -EIO;
desc_data = dmaengine_prep_slave_sg(dma_ch, nfc->dma_data_sg.sgl,
eccsteps, dma_transfer_dir,
@@ -893,8 +893,10 @@ static int stm32_fmc2_nfc_xfer(struct nand_chip *chip, const u8 *buf,
ret = dma_map_sg(nfc->dev, nfc->dma_ecc_sg.sgl,
eccsteps, dma_data_dir);
- if (ret < 0)
+ if (!ret) {
+ ret = -EIO;
goto err_unmap_data;
+ }
desc_ecc = dmaengine_prep_slave_sg(nfc->dma_ecc_ch,
nfc->dma_ecc_sg.sgl,
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 05/19] mtd: rawnand: marvell: Fix error handle regarding dma_map_sg
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (3 preceding siblings ...)
2022-08-19 6:07 ` [PATCH v1 04/19] mtd: rawnand: stm32_fmc2: " Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-09-20 8:34 ` Miquel Raynal
2022-08-19 6:07 ` [PATCH v1 06/19] usb/hcd: Fix dma_map_sg error check Jack Wang
` (13 subsequent siblings)
18 siblings, 1 reply; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Maxime Coquelin, Alexandre Torgue, Philipp Zabel,
Christophe Kerello, Cai Huoqing, linux-mtd, linux-stm32,
linux-arm-kernel
dma_map_sg return 0 on error, in case of error return -EIO,
also add the dma_unmap_sg as rollback on the following error.
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Christophe Kerello <christophe.kerello@foss.st.com>
Cc: Cai Huoqing <cai.huoqing@linux.dev>
Cc: linux-mtd@lists.infradead.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/mtd/nand/raw/marvell_nand.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
index 2455a581fd70..d9f2f1d0b5ef 100644
--- a/drivers/mtd/nand/raw/marvell_nand.c
+++ b/drivers/mtd/nand/raw/marvell_nand.c
@@ -865,13 +865,19 @@ static int marvell_nfc_xfer_data_dma(struct marvell_nfc *nfc,
marvell_nfc_enable_dma(nfc);
/* Prepare the DMA transfer */
sg_init_one(&sg, nfc->dma_buf, dma_len);
- dma_map_sg(nfc->dma_chan->device->dev, &sg, 1, direction);
+ ret = dma_map_sg(nfc->dma_chan->device->dev, &sg, 1, direction);
+ if (!ret) {
+ dev_err(nfc->dev, "Could not map DMA S/G list\n");
+ return -ENXIO;
+ }
+
tx = dmaengine_prep_slave_sg(nfc->dma_chan, &sg, 1,
direction == DMA_FROM_DEVICE ?
DMA_DEV_TO_MEM : DMA_MEM_TO_DEV,
DMA_PREP_INTERRUPT);
if (!tx) {
dev_err(nfc->dev, "Could not prepare DMA S/G list\n");
+ dma_unmap_sg(nfc->dma_chan->device->dev, &sg, 1, direction);
return -ENXIO;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 06/19] usb/hcd: Fix dma_map_sg error check
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (4 preceding siblings ...)
2022-08-19 6:07 ` [PATCH v1 05/19] mtd: rawnand: marvell: Fix error handle regarding dma_map_sg Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-19 6:07 ` [PATCH v1 07/19] crypto: gemin: Fix error check for dma_map_sg Jack Wang
` (12 subsequent siblings)
18 siblings, 0 replies; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, Alan Stern, Kishon Vijay Abraham I,
Alexey Sheplyakov, Stephen Boyd, Weitao Wang, Matthias Kaehlcke,
Arnd Bergmann, linux-usb
dma_map_sg return 0 on error.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Alexey Sheplyakov <asheplyakov@basealt.ru>
Cc: Stephen Boyd <swboyd@chromium.org>
Cc: Weitao Wang <WeitaoWang-oc@zhaoxin.com>
Cc: Matthias Kaehlcke <mka@chromium.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/usb/core/hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 94b305bbd621..90dd32a24e5b 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -1474,7 +1474,7 @@ int usb_hcd_map_urb_for_dma(struct usb_hcd *hcd, struct urb *urb,
urb->sg,
urb->num_sgs,
dir);
- if (n <= 0)
+ if (!n)
ret = -EAGAIN;
else
urb->transfer_flags |= URB_DMA_MAP_SG;
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 07/19] crypto: gemin: Fix error check for dma_map_sg
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (5 preceding siblings ...)
2022-08-19 6:07 ` [PATCH v1 06/19] usb/hcd: Fix dma_map_sg error check Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-26 8:13 ` Linus Walleij
` (2 more replies)
2022-08-19 6:07 ` [PATCH v1 08/19] crypto: sahara: " Jack Wang
` (11 subsequent siblings)
18 siblings, 3 replies; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel
Cc: Corentin Labbe, Hans Ulli Kroll, Linus Walleij, Herbert Xu,
David S. Miller, linux-crypto, linux-arm-kernel
dma_map_sg return 0 on error.
Cc: Corentin Labbe <clabbe@baylibre.com>
Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/crypto/gemini/sl3516-ce-cipher.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/gemini/sl3516-ce-cipher.c b/drivers/crypto/gemini/sl3516-ce-cipher.c
index 14d0d83d388d..34fea8aa91b6 100644
--- a/drivers/crypto/gemini/sl3516-ce-cipher.c
+++ b/drivers/crypto/gemini/sl3516-ce-cipher.c
@@ -149,7 +149,7 @@ static int sl3516_ce_cipher(struct skcipher_request *areq)
if (areq->src == areq->dst) {
nr_sgs = dma_map_sg(ce->dev, areq->src, sg_nents(areq->src),
DMA_BIDIRECTIONAL);
- if (nr_sgs <= 0 || nr_sgs > MAXDESC / 2) {
+ if (!nr_sgs || nr_sgs > MAXDESC / 2) {
dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs);
err = -EINVAL;
goto theend;
@@ -158,14 +158,14 @@ static int sl3516_ce_cipher(struct skcipher_request *areq)
} else {
nr_sgs = dma_map_sg(ce->dev, areq->src, sg_nents(areq->src),
DMA_TO_DEVICE);
- if (nr_sgs <= 0 || nr_sgs > MAXDESC / 2) {
+ if (!nr_sgs || nr_sgs > MAXDESC / 2) {
dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs);
err = -EINVAL;
goto theend;
}
nr_sgd = dma_map_sg(ce->dev, areq->dst, sg_nents(areq->dst),
DMA_FROM_DEVICE);
- if (nr_sgd <= 0 || nr_sgd > MAXDESC) {
+ if (!nr_sgd || nr_sgd > MAXDESC) {
dev_err(ce->dev, "Invalid sg number %d\n", nr_sgd);
err = -EINVAL;
goto theend_sgs;
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 08/19] crypto: sahara: Fix error check for dma_map_sg
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (6 preceding siblings ...)
2022-08-19 6:07 ` [PATCH v1 07/19] crypto: gemin: Fix error check for dma_map_sg Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-19 6:07 ` [PATCH v1 09/19] crypto: qce: Fix dma_map_sg error check Jack Wang
` (10 subsequent siblings)
18 siblings, 0 replies; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel; +Cc: Herbert Xu, David S. Miller, linux-crypto
dma_map_sg return 0 on error, it returns the number of
DMA address segments mapped (this may be shorter
than <nents> passed in if some elements of the scatter/gather
list are physically or virtually adjacent and an IOMMU maps
them with a single entry).
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/crypto/sahara.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
index 457084b344c1..bb71aac30e2c 100644
--- a/drivers/crypto/sahara.c
+++ b/drivers/crypto/sahara.c
@@ -487,13 +487,13 @@ static int sahara_hw_descriptor_create(struct sahara_dev *dev)
ret = dma_map_sg(dev->device, dev->in_sg, dev->nb_in_sg,
DMA_TO_DEVICE);
- if (ret != dev->nb_in_sg) {
+ if (!ret) {
dev_err(dev->device, "couldn't map in sg\n");
goto unmap_in;
}
ret = dma_map_sg(dev->device, dev->out_sg, dev->nb_out_sg,
DMA_FROM_DEVICE);
- if (ret != dev->nb_out_sg) {
+ if (!ret) {
dev_err(dev->device, "couldn't map out sg\n");
goto unmap_out;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 09/19] crypto: qce: Fix dma_map_sg error check
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (7 preceding siblings ...)
2022-08-19 6:07 ` [PATCH v1 08/19] crypto: sahara: " Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-19 6:07 ` [PATCH v1 10/19] crypto: amlogic: " Jack Wang
` (9 subsequent siblings)
18 siblings, 0 replies; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel
Cc: Thara Gopinath, Herbert Xu, David S. Miller, linux-crypto, linux-arm-msm
dma_map_sg return 0 on error, fix the error check and return -EIO to
caller.
Cc: Thara Gopinath <thara.gopinath@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/crypto/qce/aead.c | 4 ++--
drivers/crypto/qce/sha.c | 8 +++++---
drivers/crypto/qce/skcipher.c | 8 ++++----
3 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/crypto/qce/aead.c b/drivers/crypto/qce/aead.c
index 97a530171f07..6eb4d2e35629 100644
--- a/drivers/crypto/qce/aead.c
+++ b/drivers/crypto/qce/aead.c
@@ -450,8 +450,8 @@ qce_aead_async_req_handle(struct crypto_async_request *async_req)
if (ret)
return ret;
dst_nents = dma_map_sg(qce->dev, rctx->dst_sg, rctx->dst_nents, dir_dst);
- if (dst_nents < 0) {
- ret = dst_nents;
+ if (!dst_nents) {
+ ret = -EIO;
goto error_free;
}
diff --git a/drivers/crypto/qce/sha.c b/drivers/crypto/qce/sha.c
index 59159f5e64e5..37bafd7aeb79 100644
--- a/drivers/crypto/qce/sha.c
+++ b/drivers/crypto/qce/sha.c
@@ -97,14 +97,16 @@ static int qce_ahash_async_req_handle(struct crypto_async_request *async_req)
}
ret = dma_map_sg(qce->dev, req->src, rctx->src_nents, DMA_TO_DEVICE);
- if (ret < 0)
- return ret;
+ if (!ret)
+ return -EIO;
sg_init_one(&rctx->result_sg, qce->dma.result_buf, QCE_RESULT_BUF_SZ);
ret = dma_map_sg(qce->dev, &rctx->result_sg, 1, DMA_FROM_DEVICE);
- if (ret < 0)
+ if (!ret) {
+ ret = -EIO;
goto error_unmap_src;
+ }
ret = qce_dma_prep_sgs(&qce->dma, req->src, rctx->src_nents,
&rctx->result_sg, 1, qce_ahash_done, async_req);
diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c
index 3d27cd5210ef..5b493fdc1e74 100644
--- a/drivers/crypto/qce/skcipher.c
+++ b/drivers/crypto/qce/skcipher.c
@@ -124,15 +124,15 @@ qce_skcipher_async_req_handle(struct crypto_async_request *async_req)
rctx->dst_sg = rctx->dst_tbl.sgl;
dst_nents = dma_map_sg(qce->dev, rctx->dst_sg, rctx->dst_nents, dir_dst);
- if (dst_nents < 0) {
- ret = dst_nents;
+ if (!dst_nents) {
+ ret = -EIO;
goto error_free;
}
if (diff_dst) {
src_nents = dma_map_sg(qce->dev, req->src, rctx->src_nents, dir_src);
- if (src_nents < 0) {
- ret = src_nents;
+ if (!src_nents) {
+ ret = -EIO;
goto error_unmap_dst;
}
rctx->src_sg = req->src;
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 10/19] crypto: amlogic: Fix dma_map_sg error check
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (8 preceding siblings ...)
2022-08-19 6:07 ` [PATCH v1 09/19] crypto: qce: Fix dma_map_sg error check Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-26 12:46 ` LABBE Corentin
2022-08-19 6:07 ` [PATCH v1 11/19] crypto: allwinner: " Jack Wang
` (8 subsequent siblings)
18 siblings, 1 reply; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel
Cc: Corentin Labbe, Herbert Xu, David S. Miller, linux-crypto, linux-amlogic
dma_map_sg return 0 on error.
Cc: Corentin Labbe <clabbe@baylibre.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Cc: linux-amlogic@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/crypto/amlogic/amlogic-gxl-cipher.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
index e79514fce731..af017a087ebf 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-cipher.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
@@ -177,7 +177,7 @@ static int meson_cipher(struct skcipher_request *areq)
if (areq->src == areq->dst) {
nr_sgs = dma_map_sg(mc->dev, areq->src, sg_nents(areq->src),
DMA_BIDIRECTIONAL);
- if (nr_sgs < 0) {
+ if (!nr_sgs) {
dev_err(mc->dev, "Invalid SG count %d\n", nr_sgs);
err = -EINVAL;
goto theend;
@@ -186,14 +186,14 @@ static int meson_cipher(struct skcipher_request *areq)
} else {
nr_sgs = dma_map_sg(mc->dev, areq->src, sg_nents(areq->src),
DMA_TO_DEVICE);
- if (nr_sgs < 0 || nr_sgs > MAXDESC - 3) {
+ if (!nr_sgs || nr_sgs > MAXDESC - 3) {
dev_err(mc->dev, "Invalid SG count %d\n", nr_sgs);
err = -EINVAL;
goto theend;
}
nr_sgd = dma_map_sg(mc->dev, areq->dst, sg_nents(areq->dst),
DMA_FROM_DEVICE);
- if (nr_sgd < 0 || nr_sgd > MAXDESC - 3) {
+ if (!nr_sgd || nr_sgd > MAXDESC - 3) {
dev_err(mc->dev, "Invalid SG count %d\n", nr_sgd);
err = -EINVAL;
goto theend;
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 11/19] crypto: allwinner: Fix dma_map_sg error check
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (9 preceding siblings ...)
2022-08-19 6:07 ` [PATCH v1 10/19] crypto: amlogic: " Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-19 6:07 ` [PATCH v1 12/19] crypto: ccree: " Jack Wang
` (7 subsequent siblings)
18 siblings, 0 replies; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel
Cc: Corentin Labbe, Herbert Xu, David S. Miller, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Dan Carpenter, Minghao Chi,
Peng Wu, Alexey Khoroshilov, linux-crypto, linux-arm-kernel,
linux-sunxi
dma_map_sg return 0 on error.
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Samuel Holland <samuel@sholland.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Minghao Chi <chi.minghao@zte.com.cn>
Cc: Peng Wu <wupeng58@huawei.com>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: linux-crypto@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-sunxi@lists.linux.dev
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 6 +++---
drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c | 2 +-
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 4 ++--
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
index 74b4e910a38d..be7f46faef7e 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
@@ -208,7 +208,7 @@ static int sun8i_ce_cipher_prepare(struct crypto_engine *engine, void *async_req
if (areq->src == areq->dst) {
nr_sgs = dma_map_sg(ce->dev, areq->src, ns, DMA_BIDIRECTIONAL);
- if (nr_sgs <= 0 || nr_sgs > MAX_SG) {
+ if (!nr_sgs || nr_sgs > MAX_SG) {
dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs);
err = -EINVAL;
goto theend_iv;
@@ -216,13 +216,13 @@ static int sun8i_ce_cipher_prepare(struct crypto_engine *engine, void *async_req
nr_sgd = nr_sgs;
} else {
nr_sgs = dma_map_sg(ce->dev, areq->src, ns, DMA_TO_DEVICE);
- if (nr_sgs <= 0 || nr_sgs > MAX_SG) {
+ if (!nr_sgs || nr_sgs > MAX_SG) {
dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs);
err = -EINVAL;
goto theend_iv;
}
nr_sgd = dma_map_sg(ce->dev, areq->dst, nd, DMA_FROM_DEVICE);
- if (nr_sgd <= 0 || nr_sgd > MAX_SG) {
+ if (!nr_sgd || nr_sgd > MAX_SG) {
dev_err(ce->dev, "Invalid sg number %d\n", nr_sgd);
err = -EINVAL;
goto theend_sgs;
diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c
index 8b5b9b9d04c3..0e6843ec197f 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c
@@ -389,7 +389,7 @@ int sun8i_ce_hash_run(struct crypto_engine *engine, void *breq)
cet->t_asym_ctl = 0;
nr_sgs = dma_map_sg(ce->dev, areq->src, ns, DMA_TO_DEVICE);
- if (nr_sgs <= 0 || nr_sgs > MAX_SG) {
+ if (!nr_sgs || nr_sgs > MAX_SG) {
dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs);
err = -EINVAL;
goto theend;
diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c
index 910d6751644c..fdcc98cdecaa 100644
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c
@@ -232,13 +232,13 @@ static int sun8i_ss_cipher(struct skcipher_request *areq)
nr_sgd = nr_sgs;
} else {
nr_sgs = dma_map_sg(ss->dev, areq->src, nsgs, DMA_TO_DEVICE);
- if (nr_sgs <= 0 || nr_sgs > 8) {
+ if (!nr_sgs || nr_sgs > 8) {
dev_err(ss->dev, "Invalid sg number %d\n", nr_sgs);
err = -EINVAL;
goto theend_iv;
}
nr_sgd = dma_map_sg(ss->dev, areq->dst, nsgd, DMA_FROM_DEVICE);
- if (nr_sgd <= 0 || nr_sgd > 8) {
+ if (!nr_sgd || nr_sgd > 8) {
dev_err(ss->dev, "Invalid sg number %d\n", nr_sgd);
err = -EINVAL;
goto theend_sgs;
diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
index 36a82b22953c..fcb8c41cc957 100644
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
@@ -527,7 +527,7 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq)
rctx->method = ss->variant->alg_hash[algt->ss_algo_id];
nr_sgs = dma_map_sg(ss->dev, areq->src, sg_nents(areq->src), DMA_TO_DEVICE);
- if (nr_sgs <= 0 || nr_sgs > MAX_SG) {
+ if (!nr_sgs || nr_sgs > MAX_SG) {
dev_err(ss->dev, "Invalid sg number %d\n", nr_sgs);
err = -EINVAL;
goto theend;
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 12/19] crypto: ccree: Fix dma_map_sg error check
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (10 preceding siblings ...)
2022-08-19 6:07 ` [PATCH v1 11/19] crypto: allwinner: " Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-21 9:44 ` Gilad Ben-Yossef
2022-08-19 6:07 ` [PATCH v1 13/19] intel_th: " Jack Wang
` (6 subsequent siblings)
18 siblings, 1 reply; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel; +Cc: Gilad Ben-Yossef, Herbert Xu, David S. Miller, linux-crypto
dma_map_sg return 0 on error, and dma_map_error is not supposed to use
here.
Cc: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/crypto/ccree/cc_buffer_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/ccree/cc_buffer_mgr.c b/drivers/crypto/ccree/cc_buffer_mgr.c
index 6140e4927322..9efd88f871d1 100644
--- a/drivers/crypto/ccree/cc_buffer_mgr.c
+++ b/drivers/crypto/ccree/cc_buffer_mgr.c
@@ -274,7 +274,7 @@ static int cc_map_sg(struct device *dev, struct scatterlist *sg,
}
ret = dma_map_sg(dev, sg, *nents, direction);
- if (dma_mapping_error(dev, ret)) {
+ if (!ret) {
*nents = 0;
dev_err(dev, "dma_map_sg() sg buffer failed %d\n", ret);
return -ENOMEM;
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 13/19] intel_th: Fix dma_map_sg error check
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (11 preceding siblings ...)
2022-08-19 6:07 ` [PATCH v1 12/19] crypto: ccree: " Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-19 6:07 ` [PATCH v1 14/19] nvme-rdma: Fix error check for ib_dma_map_sg Jack Wang
` (5 subsequent siblings)
18 siblings, 0 replies; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel; +Cc: Alexander Shishkin
dma_map_sg return 0 on error.
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/hwtracing/intel_th/msu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
index 6c8215a47a60..b49237d56a60 100644
--- a/drivers/hwtracing/intel_th/msu.c
+++ b/drivers/hwtracing/intel_th/msu.c
@@ -931,7 +931,7 @@ static int msc_buffer_contig_alloc(struct msc *msc, unsigned long size)
ret = dma_map_sg(msc_dev(msc)->parent->parent, msc->single_sgt.sgl, 1,
DMA_FROM_DEVICE);
- if (ret < 0)
+ if (!ret)
goto err_free_pages;
msc->nr_pages = nr_pages;
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 14/19] nvme-rdma: Fix error check for ib_dma_map_sg
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (12 preceding siblings ...)
2022-08-19 6:07 ` [PATCH v1 13/19] intel_th: " Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-21 5:57 ` Christoph Hellwig
2022-08-19 6:07 ` [PATCH v1 15/19] nvme-fc: Fix the error check for dma_map_sg Jack Wang
` (4 subsequent siblings)
18 siblings, 1 reply; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, linux-nvme
ib_dma_map_sg return 0 on error.
Cc: Keith Busch <kbusch@kernel.org>
Cc: Jens Axboe <axboe@fb.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/nvme/host/rdma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 3100643be299..d70bccbcba3e 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1551,7 +1551,7 @@ static int nvme_rdma_dma_map_req(struct ib_device *ibdev, struct request *rq,
*count = ib_dma_map_sg(ibdev, req->data_sgl.sg_table.sgl,
req->data_sgl.nents, rq_dma_dir(rq));
- if (unlikely(*count <= 0)) {
+ if (unlikely(!*count)) {
ret = -EIO;
goto out_free_table;
}
@@ -1574,7 +1574,7 @@ static int nvme_rdma_dma_map_req(struct ib_device *ibdev, struct request *rq,
req->metadata_sgl->sg_table.sgl,
req->metadata_sgl->nents,
rq_dma_dir(rq));
- if (unlikely(*pi_count <= 0)) {
+ if (unlikely(!*pi_count)) {
ret = -EIO;
goto out_free_pi_table;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 15/19] nvme-fc: Fix the error check for dma_map_sg
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (13 preceding siblings ...)
2022-08-19 6:07 ` [PATCH v1 14/19] nvme-rdma: Fix error check for ib_dma_map_sg Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-19 6:07 ` [PATCH v1 16/19] scsi/qlogicpti: Fix dma_map_sg check Jack Wang
` (3 subsequent siblings)
18 siblings, 0 replies; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel
Cc: James Smart, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, linux-nvme
dma_map_sg return 0 on error, add missing check.
Cc: James Smart <james.smart@broadcom.com>
Cc: Keith Busch <kbusch@kernel.org>
Cc: Jens Axboe <axboe@fb.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/nvme/host/fc.c | 2 +-
drivers/nvme/target/fc.c | 5 +++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index 127abaf9ba5d..95050f2e0a06 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -2616,7 +2616,7 @@ nvme_fc_map_data(struct nvme_fc_ctrl *ctrl, struct request *rq,
WARN_ON(op->nents > blk_rq_nr_phys_segments(rq));
freq->sg_cnt = fc_dma_map_sg(ctrl->lport->dev, freq->sg_table.sgl,
op->nents, rq_dma_dir(rq));
- if (unlikely(freq->sg_cnt <= 0)) {
+ if (unlikely(!freq->sg_cnt)) {
sg_free_table_chained(&freq->sg_table, NVME_INLINE_SG_CNT);
freq->sg_cnt = 0;
return -EFAULT;
diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index ab2627e17bb9..3749ca28860b 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -2089,6 +2089,11 @@ nvmet_fc_alloc_tgt_pgs(struct nvmet_fc_fcp_iod *fod)
((fod->io_dir == NVMET_FCP_WRITE) ?
DMA_FROM_DEVICE : DMA_TO_DEVICE));
/* note: write from initiator perspective */
+ if (!fod->data_sg_cnt) {
+ sgl_free(fod->data_sg);
+ fod->data_sg = NULL;
+ goto out;
+ }
fod->next_sg = fod->data_sg;
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 16/19] scsi/qlogicpti: Fix dma_map_sg check
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (14 preceding siblings ...)
2022-08-19 6:07 ` [PATCH v1 15/19] nvme-fc: Fix the error check for dma_map_sg Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-19 6:07 ` [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg Jack Wang
` (2 subsequent siblings)
18 siblings, 0 replies; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel; +Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi
Add the missing error check for dma_map_sg.
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/scsi/qlogicpti.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
index 57f2f4135a06..8c961ff03fcd 100644
--- a/drivers/scsi/qlogicpti.c
+++ b/drivers/scsi/qlogicpti.c
@@ -909,7 +909,8 @@ static inline int load_cmd(struct scsi_cmnd *Cmnd, struct Command_Entry *cmd,
sg_count = dma_map_sg(&qpti->op->dev, sg,
scsi_sg_count(Cmnd),
Cmnd->sc_data_direction);
-
+ if (!sg_count)
+ return -1;
ds = cmd->dataseg;
cmd->segment_cnt = sg_count;
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (15 preceding siblings ...)
2022-08-19 6:07 ` [PATCH v1 16/19] scsi/qlogicpti: Fix dma_map_sg check Jack Wang
@ 2022-08-19 6:07 ` Jack Wang
2022-08-20 17:25 ` Martin Blumenstingl
2022-08-19 6:08 ` [PATCH v1 18/19] mmc: jz4740_mmc: " Jack Wang
2022-08-19 6:08 ` [PATCH v1 19/19] net/mlx4: " Jack Wang
18 siblings, 1 reply; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:07 UTC (permalink / raw)
To: linux-kernel
Cc: Ulf Hansson, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, linux-mmc, linux-arm-kernel, linux-amlogic
dma_map_sg return 0 on error.
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-mmc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-amlogic@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/mmc/host/meson-mx-sdhc-mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/meson-mx-sdhc-mmc.c b/drivers/mmc/host/meson-mx-sdhc-mmc.c
index e92e63cb5641..b32364f20c32 100644
--- a/drivers/mmc/host/meson-mx-sdhc-mmc.c
+++ b/drivers/mmc/host/meson-mx-sdhc-mmc.c
@@ -388,7 +388,7 @@ static int meson_mx_sdhc_map_dma(struct mmc_host *mmc, struct mmc_request *mrq)
dma_len = dma_map_sg(mmc_dev(mmc), data->sg, data->sg_len,
mmc_get_dma_dir(data));
- if (dma_len <= 0) {
+ if (!dma_len) {
dev_err(mmc_dev(mmc), "dma_map_sg failed\n");
return -ENOMEM;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 18/19] mmc: jz4740_mmc: Fix error check for dma_map_sg
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (16 preceding siblings ...)
2022-08-19 6:07 ` [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg Jack Wang
@ 2022-08-19 6:08 ` Jack Wang
2022-08-19 6:08 ` [PATCH v1 19/19] net/mlx4: " Jack Wang
18 siblings, 0 replies; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:08 UTC (permalink / raw)
To: linux-kernel; +Cc: Paul Cercueil, Ulf Hansson, linux-mips, linux-mmc
dma_map_sg return 0 on error.
Cc: Paul Cercueil <paul@crapouillou.net>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mips@vger.kernel.org
Cc: linux-mmc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/mmc/host/jz4740_mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc/host/jz4740_mmc.c
index b1d563b2ed1b..666600055b06 100644
--- a/drivers/mmc/host/jz4740_mmc.c
+++ b/drivers/mmc/host/jz4740_mmc.c
@@ -308,7 +308,7 @@ static int jz4740_mmc_prepare_dma_data(struct jz4740_mmc_host *host,
data->sg_len,
dir);
- if (sg_count <= 0) {
+ if (!sg_count) {
dev_err(mmc_dev(host->mmc),
"Failed to map scatterlist for DMA operation\n");
return -EINVAL;
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* [PATCH v1 19/19] net/mlx4: Fix error check for dma_map_sg
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
` (17 preceding siblings ...)
2022-08-19 6:08 ` [PATCH v1 18/19] mmc: jz4740_mmc: " Jack Wang
@ 2022-08-19 6:08 ` Jack Wang
2022-08-21 11:42 ` Leon Romanovsky
2022-08-22 18:20 ` Jakub Kicinski
18 siblings, 2 replies; 43+ messages in thread
From: Jack Wang @ 2022-08-19 6:08 UTC (permalink / raw)
To: linux-kernel
Cc: Tariq Toukan, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, linux-rdma
dma_map_sg return 0 on error.
Cc: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
Cc: linux-rdma@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/net/ethernet/mellanox/mlx4/icm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/icm.c b/drivers/net/ethernet/mellanox/mlx4/icm.c
index d89a3da89e5a..59b8b3c73582 100644
--- a/drivers/net/ethernet/mellanox/mlx4/icm.c
+++ b/drivers/net/ethernet/mellanox/mlx4/icm.c
@@ -208,7 +208,7 @@ struct mlx4_icm *mlx4_alloc_icm(struct mlx4_dev *dev, int npages,
chunk->sg, chunk->npages,
DMA_BIDIRECTIONAL);
- if (chunk->nsg <= 0)
+ if (!chunk->nsg)
goto fail;
}
@@ -222,7 +222,7 @@ struct mlx4_icm *mlx4_alloc_icm(struct mlx4_dev *dev, int npages,
chunk->nsg = dma_map_sg(&dev->persist->pdev->dev, chunk->sg,
chunk->npages, DMA_BIDIRECTIONAL);
- if (chunk->nsg <= 0)
+ if (!chunk->nsg)
goto fail;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 43+ messages in thread
* Re: [PATCH v1 02/19] infiniband/mthca: Fix dma_map_sg error check
2022-08-19 6:07 ` [PATCH v1 02/19] infiniband/mthca: Fix dma_map_sg error check Jack Wang
@ 2022-08-19 22:19 ` Kees Cook
2022-08-21 11:46 ` Leon Romanovsky
2022-08-22 5:11 ` Dan Carpenter
2 siblings, 0 replies; 43+ messages in thread
From: Kees Cook @ 2022-08-19 22:19 UTC (permalink / raw)
To: Jack Wang
Cc: linux-kernel, Jason Gunthorpe, Leon Romanovsky,
Christophe JAILLET, Håkon Bugge, linux-rdma
On Fri, Aug 19, 2022 at 08:07:44AM +0200, Jack Wang wrote:
> dma_map_sg return 0 on error, in case of error set
> EIO as return code.
>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: "Håkon Bugge" <haakon.bugge@oracle.com>
> Cc: linux-rdma@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg
2022-08-19 6:07 ` [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg Jack Wang
@ 2022-08-20 17:25 ` Martin Blumenstingl
2022-08-22 5:15 ` Jinpu Wang
0 siblings, 1 reply; 43+ messages in thread
From: Martin Blumenstingl @ 2022-08-20 17:25 UTC (permalink / raw)
To: Jack Wang
Cc: linux-kernel, Ulf Hansson, Neil Armstrong, Kevin Hilman,
Jerome Brunet, linux-mmc, linux-arm-kernel, linux-amlogic
Hello Jack,
first of all: thank you for this patch!
On Fri, Aug 19, 2022 at 8:08 AM Jack Wang <jinpu.wang@ionos.com> wrote:
[...]
> @@ -388,7 +388,7 @@ static int meson_mx_sdhc_map_dma(struct mmc_host *mmc, struct mmc_request *mrq)
>
> dma_len = dma_map_sg(mmc_dev(mmc), data->sg, data->sg_len,
Does it also make sense to change the type of the dma_len variable
from (signed) int to "unsigned int" (a few lines above)?
Best regards,
Martin
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 14/19] nvme-rdma: Fix error check for ib_dma_map_sg
2022-08-19 6:07 ` [PATCH v1 14/19] nvme-rdma: Fix error check for ib_dma_map_sg Jack Wang
@ 2022-08-21 5:57 ` Christoph Hellwig
2022-08-22 5:12 ` Jinpu Wang
0 siblings, 1 reply; 43+ messages in thread
From: Christoph Hellwig @ 2022-08-21 5:57 UTC (permalink / raw)
To: Jack Wang
Cc: linux-kernel, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, linux-nvme
Please don't send me just two random patches out of a series, as I
have no way to review them. If the patches are independent, send them
independently and if they depend on common prep work send the entire
series to everyone.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 12/19] crypto: ccree: Fix dma_map_sg error check
2022-08-19 6:07 ` [PATCH v1 12/19] crypto: ccree: " Jack Wang
@ 2022-08-21 9:44 ` Gilad Ben-Yossef
0 siblings, 0 replies; 43+ messages in thread
From: Gilad Ben-Yossef @ 2022-08-21 9:44 UTC (permalink / raw)
To: Jack Wang
Cc: Linux kernel mailing list, Herbert Xu, David S. Miller,
Linux Crypto Mailing List
Hi Jack,
On Fri, Aug 19, 2022 at 9:08 AM Jack Wang <jinpu.wang@ionos.com> wrote:
>
> dma_map_sg return 0 on error, and dma_map_error is not supposed to use
> here.
>
> Cc: Gilad Ben-Yossef <gilad@benyossef.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
>
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> ---
> drivers/crypto/ccree/cc_buffer_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccree/cc_buffer_mgr.c b/drivers/crypto/ccree/cc_buffer_mgr.c
> index 6140e4927322..9efd88f871d1 100644
> --- a/drivers/crypto/ccree/cc_buffer_mgr.c
> +++ b/drivers/crypto/ccree/cc_buffer_mgr.c
> @@ -274,7 +274,7 @@ static int cc_map_sg(struct device *dev, struct scatterlist *sg,
> }
>
> ret = dma_map_sg(dev, sg, *nents, direction);
> - if (dma_mapping_error(dev, ret)) {
> + if (!ret) {
> *nents = 0;
> dev_err(dev, "dma_map_sg() sg buffer failed %d\n", ret);
> return -ENOMEM;
> --
> 2.34.1
>
Good catch!
Thank you for the patch.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
values of β will give rise to dom!
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 19/19] net/mlx4: Fix error check for dma_map_sg
2022-08-19 6:08 ` [PATCH v1 19/19] net/mlx4: " Jack Wang
@ 2022-08-21 11:42 ` Leon Romanovsky
2022-08-22 18:20 ` Jakub Kicinski
1 sibling, 0 replies; 43+ messages in thread
From: Leon Romanovsky @ 2022-08-21 11:42 UTC (permalink / raw)
To: Jack Wang
Cc: linux-kernel, Tariq Toukan, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, linux-rdma
On Fri, Aug 19, 2022 at 08:08:01AM +0200, Jack Wang wrote:
> dma_map_sg return 0 on error.
>
> Cc: Tariq Toukan <tariqt@nvidia.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-rdma@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
>
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/icm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 02/19] infiniband/mthca: Fix dma_map_sg error check
2022-08-19 6:07 ` [PATCH v1 02/19] infiniband/mthca: Fix dma_map_sg error check Jack Wang
2022-08-19 22:19 ` Kees Cook
@ 2022-08-21 11:46 ` Leon Romanovsky
2022-08-22 5:11 ` Dan Carpenter
2 siblings, 0 replies; 43+ messages in thread
From: Leon Romanovsky @ 2022-08-21 11:46 UTC (permalink / raw)
To: Jack Wang
Cc: linux-kernel, Jason Gunthorpe, Christophe JAILLET, Kees Cook,
Håkon Bugge, linux-rdma
On Fri, Aug 19, 2022 at 08:07:44AM +0200, Jack Wang wrote:
> dma_map_sg return 0 on error, in case of error set
> EIO as return code.
>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: "Håkon Bugge" <haakon.bugge@oracle.com>
> Cc: linux-rdma@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> ---
> drivers/infiniband/hw/mthca/mthca_memfree.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mthca/mthca_memfree.c b/drivers/infiniband/hw/mthca/mthca_memfree.c
> index f2734a5c5f26..44fd5fdf64d5 100644
> --- a/drivers/infiniband/hw/mthca/mthca_memfree.c
> +++ b/drivers/infiniband/hw/mthca/mthca_memfree.c
> @@ -189,7 +189,7 @@ struct mthca_icm *mthca_alloc_icm(struct mthca_dev *dev, int npages,
> chunk->npages,
> DMA_BIDIRECTIONAL);
>
> - if (chunk->nsg <= 0)
> + if (!chunk->nsg)
> goto fail;
> }
>
> @@ -208,7 +208,7 @@ struct mthca_icm *mthca_alloc_icm(struct mthca_dev *dev, int npages,
> chunk->nsg = dma_map_sg(&dev->pdev->dev, chunk->mem,
> chunk->npages, DMA_BIDIRECTIONAL);
>
> - if (chunk->nsg <= 0)
> + if (!chunk->nsg)
> goto fail;
> }
>
> @@ -482,8 +482,9 @@ int mthca_map_user_db(struct mthca_dev *dev, struct mthca_uar *uar,
>
> ret = dma_map_sg(&dev->pdev->dev, &db_tab->page[i].mem, 1,
> DMA_TO_DEVICE);
> - if (ret < 0) {
> + if (!ret) {
This code is not equivalent to original code. mthca didn't count ret == 0
as an error. Most likely, it is a bug, but I don't want to change old and
unmaintained driver without any real need.
Thanks
> unpin_user_page(pages[0]);
> + ret = -EIO;
> goto out;
> }
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 01/19] mailbox: bcm-ferxrm-mailbox: Fix error check for dma_map_sg
2022-08-19 6:07 ` [PATCH v1 01/19] mailbox: bcm-ferxrm-mailbox: Fix error check for dma_map_sg Jack Wang
@ 2022-08-22 5:07 ` Dan Carpenter
2022-08-22 9:58 ` Jinpu Wang
0 siblings, 1 reply; 43+ messages in thread
From: Dan Carpenter @ 2022-08-22 5:07 UTC (permalink / raw)
To: Jack Wang; +Cc: linux-kernel, Jassi Brar
On Fri, Aug 19, 2022 at 08:07:43AM +0200, Jack Wang wrote:
> dma_map_sg return 0 on error, fix the error check, and return -EIO
> to caller.
>
> Cc: Jassi Brar <jassisinghbrar@gmail.com>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
This needs a Fixes tag.
Fixes: dbc049eee730 ("mailbox: Add driver for Broadcom FlexRM ring manager")
regards,
dan carpenter
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 02/19] infiniband/mthca: Fix dma_map_sg error check
2022-08-19 6:07 ` [PATCH v1 02/19] infiniband/mthca: Fix dma_map_sg error check Jack Wang
2022-08-19 22:19 ` Kees Cook
2022-08-21 11:46 ` Leon Romanovsky
@ 2022-08-22 5:11 ` Dan Carpenter
2 siblings, 0 replies; 43+ messages in thread
From: Dan Carpenter @ 2022-08-22 5:11 UTC (permalink / raw)
To: Jack Wang
Cc: linux-kernel, Jason Gunthorpe, Leon Romanovsky,
Christophe JAILLET, Kees Cook, Håkon Bugge, linux-rdma
On Fri, Aug 19, 2022 at 08:07:44AM +0200, Jack Wang wrote:
> dma_map_sg return 0 on error, in case of error set
> EIO as return code.
>
The first two chunks are just cleanups but the third one is a bug fix
so it needs a Fixes tag.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 14/19] nvme-rdma: Fix error check for ib_dma_map_sg
2022-08-21 5:57 ` Christoph Hellwig
@ 2022-08-22 5:12 ` Jinpu Wang
2022-08-22 6:25 ` Christoph Hellwig
0 siblings, 1 reply; 43+ messages in thread
From: Jinpu Wang @ 2022-08-22 5:12 UTC (permalink / raw)
To: Christoph Hellwig
Cc: linux-kernel, Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme
On Sun, Aug 21, 2022 at 7:57 AM Christoph Hellwig <hch@lst.de> wrote:
>
> Please don't send me just two random patches out of a series, as I
> have no way to review them. If the patches are independent, send them
> independently and if they depend on common prep work send the entire
> series to everyone.
Hi Christoph,
As mentioned in the cover letter, the bugfixes are all independent,
for each of the drivers.
I will wait a bit to see if there is other comments, resend as you
suggested later.
Thx!
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg
2022-08-20 17:25 ` Martin Blumenstingl
@ 2022-08-22 5:15 ` Jinpu Wang
0 siblings, 0 replies; 43+ messages in thread
From: Jinpu Wang @ 2022-08-22 5:15 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: linux-kernel, Ulf Hansson, Neil Armstrong, Kevin Hilman,
Jerome Brunet, linux-mmc, linux-arm-kernel, linux-amlogic
Hi Martin,
On Sat, Aug 20, 2022 at 7:26 PM Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Hello Jack,
>
> first of all: thank you for this patch!
welcome.
>
> On Fri, Aug 19, 2022 at 8:08 AM Jack Wang <jinpu.wang@ionos.com> wrote:
> [...]
> > @@ -388,7 +388,7 @@ static int meson_mx_sdhc_map_dma(struct mmc_host *mmc, struct mmc_request *mrq)
> >
> > dma_len = dma_map_sg(mmc_dev(mmc), data->sg, data->sg_len,
> Does it also make sense to change the type of the dma_len variable
> from (signed) int to "unsigned int" (a few lines above)?
I double checked, it seems a good idea, I will do it in v2.
>
>
> Best regards,
> Martin
Thx!
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 14/19] nvme-rdma: Fix error check for ib_dma_map_sg
2022-08-22 5:12 ` Jinpu Wang
@ 2022-08-22 6:25 ` Christoph Hellwig
2022-08-22 7:10 ` Jinpu Wang
0 siblings, 1 reply; 43+ messages in thread
From: Christoph Hellwig @ 2022-08-22 6:25 UTC (permalink / raw)
To: Jinpu Wang
Cc: Christoph Hellwig, linux-kernel, Keith Busch, Jens Axboe,
Sagi Grimberg, linux-nvme
On Mon, Aug 22, 2022 at 07:12:23AM +0200, Jinpu Wang wrote:
> On Sun, Aug 21, 2022 at 7:57 AM Christoph Hellwig <hch@lst.de> wrote:
> >
> > Please don't send me just two random patches out of a series, as I
> > have no way to review them. If the patches are independent, send them
> > independently and if they depend on common prep work send the entire
> > series to everyone.
> Hi Christoph,
>
> As mentioned in the cover letter, the bugfixes are all independent,
> for each of the drivers.
I still haven't seen the cover letter as it was never sent to me.
But if patches are independent please send a series per subsystem
as that makes that very clear.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 14/19] nvme-rdma: Fix error check for ib_dma_map_sg
2022-08-22 6:25 ` Christoph Hellwig
@ 2022-08-22 7:10 ` Jinpu Wang
0 siblings, 0 replies; 43+ messages in thread
From: Jinpu Wang @ 2022-08-22 7:10 UTC (permalink / raw)
To: Christoph Hellwig
Cc: linux-kernel, Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme
On Mon, Aug 22, 2022 at 8:25 AM Christoph Hellwig <hch@lst.de> wrote:
>
> On Mon, Aug 22, 2022 at 07:12:23AM +0200, Jinpu Wang wrote:
> > On Sun, Aug 21, 2022 at 7:57 AM Christoph Hellwig <hch@lst.de> wrote:
> > >
> > > Please don't send me just two random patches out of a series, as I
> > > have no way to review them. If the patches are independent, send them
> > > independently and if they depend on common prep work send the entire
> > > series to everyone.
> > Hi Christoph,
> >
> > As mentioned in the cover letter, the bugfixes are all independent,
> > for each of the drivers.
>
> I still haven't seen the cover letter as it was never sent to me.
> But if patches are independent please send a series per subsystem
> as that makes that very clear.
Thanks for the hint, this definitely helps the subsystem maintainer to
get a clear background.
I'll do it in the future.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 01/19] mailbox: bcm-ferxrm-mailbox: Fix error check for dma_map_sg
2022-08-22 5:07 ` Dan Carpenter
@ 2022-08-22 9:58 ` Jinpu Wang
0 siblings, 0 replies; 43+ messages in thread
From: Jinpu Wang @ 2022-08-22 9:58 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-kernel, Jassi Brar
On Mon, Aug 22, 2022 at 7:07 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Fri, Aug 19, 2022 at 08:07:43AM +0200, Jack Wang wrote:
> > dma_map_sg return 0 on error, fix the error check, and return -EIO
> > to caller.
> >
> > Cc: Jassi Brar <jassisinghbrar@gmail.com>
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
>
> This needs a Fixes tag.
>
> Fixes: dbc049eee730 ("mailbox: Add driver for Broadcom FlexRM ring manager")
Will add in the next version.
Thank you!
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 19/19] net/mlx4: Fix error check for dma_map_sg
2022-08-19 6:08 ` [PATCH v1 19/19] net/mlx4: " Jack Wang
2022-08-21 11:42 ` Leon Romanovsky
@ 2022-08-22 18:20 ` Jakub Kicinski
2022-08-24 14:39 ` Jinpu Wang
1 sibling, 1 reply; 43+ messages in thread
From: Jakub Kicinski @ 2022-08-22 18:20 UTC (permalink / raw)
To: Jack Wang
Cc: linux-kernel, Tariq Toukan, David S. Miller, Eric Dumazet,
Paolo Abeni, netdev, linux-rdma
On Fri, 19 Aug 2022 08:08:01 +0200 Jack Wang wrote:
> dma_map_sg return 0 on error.
You need to resend it as an individual patch, not part of a series if
you want it to be applied to the networking tree. Please keep Leon's
review tag.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 04/19] mtd: rawnand: stm32_fmc2: Fix dma_map_sg error check
2022-08-19 6:07 ` [PATCH v1 04/19] mtd: rawnand: stm32_fmc2: " Jack Wang
@ 2022-08-23 7:49 ` Christophe Kerello
2022-09-20 8:34 ` Miquel Raynal
1 sibling, 0 replies; 43+ messages in thread
From: Christophe Kerello @ 2022-08-23 7:49 UTC (permalink / raw)
To: Jack Wang, linux-kernel
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Maxime Coquelin, Alexandre Torgue, Philipp Zabel, Cai Huoqing,
linux-mtd, linux-stm32, linux-arm-kernel
Hi Jack,
On 8/19/22 08:07, Jack Wang wrote:
> dma_map_sg return 0 on error, in case of error return -EIO.
>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Christophe Kerello <christophe.kerello@foss.st.com>
> Cc: Cai Huoqing <cai.huoqing@linux.dev>
> Cc: linux-mtd@lists.infradead.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> ---
> drivers/mtd/nand/raw/stm32_fmc2_nand.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> index 87c1c7dd97eb..a0c825af19fa 100644
> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> @@ -862,8 +862,8 @@ static int stm32_fmc2_nfc_xfer(struct nand_chip *chip, const u8 *buf,
>
> ret = dma_map_sg(nfc->dev, nfc->dma_data_sg.sgl,
> eccsteps, dma_data_dir);
> - if (ret < 0)
> - return ret;
> + if (!ret)
> + return -EIO;
>
> desc_data = dmaengine_prep_slave_sg(dma_ch, nfc->dma_data_sg.sgl,
> eccsteps, dma_transfer_dir,
> @@ -893,8 +893,10 @@ static int stm32_fmc2_nfc_xfer(struct nand_chip *chip, const u8 *buf,
>
> ret = dma_map_sg(nfc->dev, nfc->dma_ecc_sg.sgl,
> eccsteps, dma_data_dir);
> - if (ret < 0)
> + if (!ret) {
> + ret = -EIO;
> goto err_unmap_data;
> + }
>
> desc_ecc = dmaengine_prep_slave_sg(nfc->dma_ecc_ch,
> nfc->dma_ecc_sg.sgl,
Reviewed-by: Christophe Kerello <christophe.kerello@foss.st.com>
Regards,
Christophe Kerello.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 19/19] net/mlx4: Fix error check for dma_map_sg
2022-08-22 18:20 ` Jakub Kicinski
@ 2022-08-24 14:39 ` Jinpu Wang
0 siblings, 0 replies; 43+ messages in thread
From: Jinpu Wang @ 2022-08-24 14:39 UTC (permalink / raw)
To: Jakub Kicinski
Cc: linux-kernel, Tariq Toukan, David S. Miller, Eric Dumazet,
Paolo Abeni, netdev, linux-rdma
On Mon, Aug 22, 2022 at 8:20 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Fri, 19 Aug 2022 08:08:01 +0200 Jack Wang wrote:
> > dma_map_sg return 0 on error.
>
> You need to resend it as an individual patch, not part of a series if
> you want it to be applied to the networking tree. Please keep Leon's
> review tag.
Got it. Will do
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 07/19] crypto: gemin: Fix error check for dma_map_sg
2022-08-19 6:07 ` [PATCH v1 07/19] crypto: gemin: Fix error check for dma_map_sg Jack Wang
@ 2022-08-26 8:13 ` Linus Walleij
2022-08-26 11:06 ` Herbert Xu
2022-08-26 12:04 ` LABBE Corentin
2 siblings, 0 replies; 43+ messages in thread
From: Linus Walleij @ 2022-08-26 8:13 UTC (permalink / raw)
To: Jack Wang
Cc: linux-kernel, Corentin Labbe, Hans Ulli Kroll, Herbert Xu,
David S. Miller, linux-crypto, linux-arm-kernel
On Fri, Aug 19, 2022 at 8:08 AM Jack Wang <jinpu.wang@ionos.com> wrote:
> dma_map_sg return 0 on error.
>
> Cc: Corentin Labbe <clabbe@baylibre.com>
> Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Good catch!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 07/19] crypto: gemin: Fix error check for dma_map_sg
2022-08-19 6:07 ` [PATCH v1 07/19] crypto: gemin: Fix error check for dma_map_sg Jack Wang
2022-08-26 8:13 ` Linus Walleij
@ 2022-08-26 11:06 ` Herbert Xu
2022-08-26 12:04 ` LABBE Corentin
2 siblings, 0 replies; 43+ messages in thread
From: Herbert Xu @ 2022-08-26 11:06 UTC (permalink / raw)
To: Jack Wang
Cc: linux-kernel, Corentin Labbe, Hans Ulli Kroll, Linus Walleij,
David S. Miller, linux-crypto, linux-arm-kernel
On Fri, Aug 19, 2022 at 08:07:49AM +0200, Jack Wang wrote:
> dma_map_sg return 0 on error.
>
> Cc: Corentin Labbe <clabbe@baylibre.com>
> Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> ---
> drivers/crypto/gemini/sl3516-ce-cipher.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Patches 7-12 applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 07/19] crypto: gemin: Fix error check for dma_map_sg
2022-08-19 6:07 ` [PATCH v1 07/19] crypto: gemin: Fix error check for dma_map_sg Jack Wang
2022-08-26 8:13 ` Linus Walleij
2022-08-26 11:06 ` Herbert Xu
@ 2022-08-26 12:04 ` LABBE Corentin
2022-08-26 12:08 ` Jinpu Wang
2 siblings, 1 reply; 43+ messages in thread
From: LABBE Corentin @ 2022-08-26 12:04 UTC (permalink / raw)
To: Jack Wang
Cc: linux-kernel, Hans Ulli Kroll, Linus Walleij, Herbert Xu,
David S. Miller, linux-crypto, linux-arm-kernel
Le Fri, Aug 19, 2022 at 08:07:49AM +0200, Jack Wang a écrit :
> dma_map_sg return 0 on error.
>
> Cc: Corentin Labbe <clabbe@baylibre.com>
> Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> ---
> drivers/crypto/gemini/sl3516-ce-cipher.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Hello
There is a typo in subject gemin -> gemini.
Acked-by: Corentin Labbe <clabbe@baylibre.com>
Tested-by: Corentin Labbe <clabbe@baylibre.com>
Thanks
Regards
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 07/19] crypto: gemin: Fix error check for dma_map_sg
2022-08-26 12:04 ` LABBE Corentin
@ 2022-08-26 12:08 ` Jinpu Wang
0 siblings, 0 replies; 43+ messages in thread
From: Jinpu Wang @ 2022-08-26 12:08 UTC (permalink / raw)
To: LABBE Corentin, Herbert Xu
Cc: linux-kernel, Hans Ulli Kroll, Linus Walleij, David S. Miller,
linux-crypto, linux-arm-kernel
On Fri, Aug 26, 2022 at 2:04 PM LABBE Corentin <clabbe@baylibre.com> wrote:
>
> Le Fri, Aug 19, 2022 at 08:07:49AM +0200, Jack Wang a écrit :
> > dma_map_sg return 0 on error.
> >
> > Cc: Corentin Labbe <clabbe@baylibre.com>
> > Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: linux-crypto@vger.kernel.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> > ---
> > drivers/crypto/gemini/sl3516-ce-cipher.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
>
> Hello
>
> There is a typo in subject gemin -> gemini.
indeed, maybe Herbert can fix the subject in his tree.
>
> Acked-by: Corentin Labbe <clabbe@baylibre.com>
> Tested-by: Corentin Labbe <clabbe@baylibre.com>
>
> Thanks
> Regards
Thx!
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 10/19] crypto: amlogic: Fix dma_map_sg error check
2022-08-19 6:07 ` [PATCH v1 10/19] crypto: amlogic: " Jack Wang
@ 2022-08-26 12:46 ` LABBE Corentin
0 siblings, 0 replies; 43+ messages in thread
From: LABBE Corentin @ 2022-08-26 12:46 UTC (permalink / raw)
To: Jack Wang
Cc: linux-kernel, Herbert Xu, David S. Miller, linux-crypto, linux-amlogic
Le Fri, Aug 19, 2022 at 08:07:52AM +0200, Jack Wang a écrit :
> dma_map_sg return 0 on error.
>
> Cc: Corentin Labbe <clabbe@baylibre.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-amlogic@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
>
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> ---
> drivers/crypto/amlogic/amlogic-gxl-cipher.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Hello
Tested-by: Corentin Labbe <clabbe@baylibre.com>
Acked-by: Corentin Labbe <clabbe@baylibre.com>
Thanks
Regards
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 05/19] mtd: rawnand: marvell: Fix error handle regarding dma_map_sg
2022-08-19 6:07 ` [PATCH v1 05/19] mtd: rawnand: marvell: Fix error handle regarding dma_map_sg Jack Wang
@ 2022-09-20 8:34 ` Miquel Raynal
0 siblings, 0 replies; 43+ messages in thread
From: Miquel Raynal @ 2022-09-20 8:34 UTC (permalink / raw)
To: Jack Wang, linux-kernel
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Maxime Coquelin, Alexandre Torgue, Philipp Zabel,
Christophe Kerello, Cai Huoqing, linux-mtd, linux-stm32,
linux-arm-kernel
On Fri, 2022-08-19 at 06:07:47 UTC, Jack Wang wrote:
> dma_map_sg return 0 on error, in case of error return -EIO,
> also add the dma_unmap_sg as rollback on the following error.
>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Christophe Kerello <christophe.kerello@foss.st.com>
> Cc: Cai Huoqing <cai.huoqing@linux.dev>
> Cc: linux-mtd@lists.infradead.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
>
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PATCH v1 04/19] mtd: rawnand: stm32_fmc2: Fix dma_map_sg error check
2022-08-19 6:07 ` [PATCH v1 04/19] mtd: rawnand: stm32_fmc2: " Jack Wang
2022-08-23 7:49 ` Christophe Kerello
@ 2022-09-20 8:34 ` Miquel Raynal
1 sibling, 0 replies; 43+ messages in thread
From: Miquel Raynal @ 2022-09-20 8:34 UTC (permalink / raw)
To: Jack Wang, linux-kernel
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Maxime Coquelin, Alexandre Torgue, Philipp Zabel,
Christophe Kerello, Cai Huoqing, linux-mtd, linux-stm32,
linux-arm-kernel
On Fri, 2022-08-19 at 06:07:46 UTC, Jack Wang wrote:
> dma_map_sg return 0 on error, in case of error return -EIO.
>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Christophe Kerello <christophe.kerello@foss.st.com>
> Cc: Cai Huoqing <cai.huoqing@linux.dev>
> Cc: linux-mtd@lists.infradead.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> Reviewed-by: Christophe Kerello <christophe.kerello@foss.st.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 43+ messages in thread
end of thread, other threads:[~2022-09-20 8:35 UTC | newest]
Thread overview: 43+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-19 6:07 [PATCH v1 00/19] Fix dma_map_sg error check Jack Wang
2022-08-19 6:07 ` [PATCH v1 01/19] mailbox: bcm-ferxrm-mailbox: Fix error check for dma_map_sg Jack Wang
2022-08-22 5:07 ` Dan Carpenter
2022-08-22 9:58 ` Jinpu Wang
2022-08-19 6:07 ` [PATCH v1 02/19] infiniband/mthca: Fix dma_map_sg error check Jack Wang
2022-08-19 22:19 ` Kees Cook
2022-08-21 11:46 ` Leon Romanovsky
2022-08-22 5:11 ` Dan Carpenter
2022-08-19 6:07 ` [PATCH v1 03/19] HSI: omap_ssi_port: " Jack Wang
2022-08-19 6:07 ` [PATCH v1 04/19] mtd: rawnand: stm32_fmc2: " Jack Wang
2022-08-23 7:49 ` Christophe Kerello
2022-09-20 8:34 ` Miquel Raynal
2022-08-19 6:07 ` [PATCH v1 05/19] mtd: rawnand: marvell: Fix error handle regarding dma_map_sg Jack Wang
2022-09-20 8:34 ` Miquel Raynal
2022-08-19 6:07 ` [PATCH v1 06/19] usb/hcd: Fix dma_map_sg error check Jack Wang
2022-08-19 6:07 ` [PATCH v1 07/19] crypto: gemin: Fix error check for dma_map_sg Jack Wang
2022-08-26 8:13 ` Linus Walleij
2022-08-26 11:06 ` Herbert Xu
2022-08-26 12:04 ` LABBE Corentin
2022-08-26 12:08 ` Jinpu Wang
2022-08-19 6:07 ` [PATCH v1 08/19] crypto: sahara: " Jack Wang
2022-08-19 6:07 ` [PATCH v1 09/19] crypto: qce: Fix dma_map_sg error check Jack Wang
2022-08-19 6:07 ` [PATCH v1 10/19] crypto: amlogic: " Jack Wang
2022-08-26 12:46 ` LABBE Corentin
2022-08-19 6:07 ` [PATCH v1 11/19] crypto: allwinner: " Jack Wang
2022-08-19 6:07 ` [PATCH v1 12/19] crypto: ccree: " Jack Wang
2022-08-21 9:44 ` Gilad Ben-Yossef
2022-08-19 6:07 ` [PATCH v1 13/19] intel_th: " Jack Wang
2022-08-19 6:07 ` [PATCH v1 14/19] nvme-rdma: Fix error check for ib_dma_map_sg Jack Wang
2022-08-21 5:57 ` Christoph Hellwig
2022-08-22 5:12 ` Jinpu Wang
2022-08-22 6:25 ` Christoph Hellwig
2022-08-22 7:10 ` Jinpu Wang
2022-08-19 6:07 ` [PATCH v1 15/19] nvme-fc: Fix the error check for dma_map_sg Jack Wang
2022-08-19 6:07 ` [PATCH v1 16/19] scsi/qlogicpti: Fix dma_map_sg check Jack Wang
2022-08-19 6:07 ` [PATCH v1 17/19] mmc: meson-mx-sdhc: Fix error check for dma_map_sg Jack Wang
2022-08-20 17:25 ` Martin Blumenstingl
2022-08-22 5:15 ` Jinpu Wang
2022-08-19 6:08 ` [PATCH v1 18/19] mmc: jz4740_mmc: " Jack Wang
2022-08-19 6:08 ` [PATCH v1 19/19] net/mlx4: " Jack Wang
2022-08-21 11:42 ` Leon Romanovsky
2022-08-22 18:20 ` Jakub Kicinski
2022-08-24 14:39 ` Jinpu Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).