* [PATCH 1/2] ACPI: pfr_telemetry: use ACPI_FREE() to free acpi_object
2022-11-18 6:32 [PATCH 0/2] change to use ACPI_FREE() to free the ACPI memory Wang ShaoBo
@ 2022-11-18 6:32 ` Wang ShaoBo
2022-11-18 11:21 ` Chen Yu
2022-11-18 6:32 ` [PATCH 2/2] ACPI: pfr_update: " Wang ShaoBo
2022-11-23 18:30 ` [PATCH 0/2] change to use ACPI_FREE() to free the ACPI memory Rafael J. Wysocki
2 siblings, 1 reply; 6+ messages in thread
From: Wang ShaoBo @ 2022-11-18 6:32 UTC (permalink / raw)
Cc: rafael.j.wysocki, rafael, lenb, yu.c.chen, linux-acpi, guohanjun,
liwei391, linux-kernel
acpi_evaluate_dsm_typed()/acpi_evaluate_dsm() should be coupled
with ACPI_FREE() to free the ACPI memory, because we need to
track the allocation of acpi_object when ACPI_DBG_TRACK_ALLOCATIONS
enabled, so use ACPI_FREE() instead of kfree().
Fixes: b0013e037a8b ("ACPI: Introduce Platform Firmware Runtime Telemetry driver")
Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
---
drivers/acpi/pfr_telemetry.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/pfr_telemetry.c b/drivers/acpi/pfr_telemetry.c
index 9abf350bd7a5..27fb6cdad75f 100644
--- a/drivers/acpi/pfr_telemetry.c
+++ b/drivers/acpi/pfr_telemetry.c
@@ -144,7 +144,7 @@ static int get_pfrt_log_data_info(struct pfrt_log_data_info *data_info,
ret = 0;
free_acpi_buffer:
- kfree(out_obj);
+ ACPI_FREE(out_obj);
return ret;
}
@@ -180,7 +180,7 @@ static int set_pfrt_log_level(int level, struct pfrt_log_device *pfrt_log_dev)
ret = -EBUSY;
}
- kfree(out_obj);
+ ACPI_FREE(out_obj);
return ret;
}
@@ -218,7 +218,7 @@ static int get_pfrt_log_level(struct pfrt_log_device *pfrt_log_dev)
ret = obj->integer.value;
free_acpi_buffer:
- kfree(out_obj);
+ ACPI_FREE(out_obj);
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] ACPI: pfr_telemetry: use ACPI_FREE() to free acpi_object
2022-11-18 6:32 ` [PATCH 1/2] ACPI: pfr_telemetry: use ACPI_FREE() to free acpi_object Wang ShaoBo
@ 2022-11-18 11:21 ` Chen Yu
0 siblings, 0 replies; 6+ messages in thread
From: Chen Yu @ 2022-11-18 11:21 UTC (permalink / raw)
To: Wang ShaoBo
Cc: rafael.j.wysocki, rafael, lenb, linux-acpi, guohanjun, liwei391,
linux-kernel
On 2022-11-18 at 14:32:18 +0800, Wang ShaoBo wrote:
> acpi_evaluate_dsm_typed()/acpi_evaluate_dsm() should be coupled
> with ACPI_FREE() to free the ACPI memory, because we need to
> track the allocation of acpi_object when ACPI_DBG_TRACK_ALLOCATIONS
> enabled, so use ACPI_FREE() instead of kfree().
>
> Fixes: b0013e037a8b ("ACPI: Introduce Platform Firmware Runtime Telemetry driver")
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
Reviewed-by: Chen Yu <yu.c.chen@intel.com>
thanks,
Chenyu
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] ACPI: pfr_update: use ACPI_FREE() to free acpi_object
2022-11-18 6:32 [PATCH 0/2] change to use ACPI_FREE() to free the ACPI memory Wang ShaoBo
2022-11-18 6:32 ` [PATCH 1/2] ACPI: pfr_telemetry: use ACPI_FREE() to free acpi_object Wang ShaoBo
@ 2022-11-18 6:32 ` Wang ShaoBo
2022-11-18 11:23 ` Chen Yu
2022-11-23 18:30 ` [PATCH 0/2] change to use ACPI_FREE() to free the ACPI memory Rafael J. Wysocki
2 siblings, 1 reply; 6+ messages in thread
From: Wang ShaoBo @ 2022-11-18 6:32 UTC (permalink / raw)
Cc: rafael.j.wysocki, rafael, lenb, yu.c.chen, linux-acpi, guohanjun,
liwei391, linux-kernel
acpi_evaluate_dsm_typed()/acpi_evaluate_dsm() should be coupled with
ACPI_FREE() to free the ACPI memory, because we need to track the
allocation of acpi_object when ACPI_DBG_TRACK_ALLOCATIONS enabled,
so use ACPI_FREE() instead of kfree().
Fixes: 0db89fa243e5 ("ACPI: Introduce Platform Firmware Runtime Update device driver")
Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
---
drivers/acpi/pfr_update.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/pfr_update.c b/drivers/acpi/pfr_update.c
index 6bb0b778b5da..9d2bdc13253a 100644
--- a/drivers/acpi/pfr_update.c
+++ b/drivers/acpi/pfr_update.c
@@ -178,7 +178,7 @@ static int query_capability(struct pfru_update_cap_info *cap_hdr,
ret = 0;
free_acpi_buffer:
- kfree(out_obj);
+ ACPI_FREE(out_obj);
return ret;
}
@@ -224,7 +224,7 @@ static int query_buffer(struct pfru_com_buf_info *info,
ret = 0;
free_acpi_buffer:
- kfree(out_obj);
+ ACPI_FREE(out_obj);
return ret;
}
@@ -385,7 +385,7 @@ static int start_update(int action, struct pfru_device *pfru_dev)
ret = 0;
free_acpi_buffer:
- kfree(out_obj);
+ ACPI_FREE(out_obj);
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] ACPI: pfr_update: use ACPI_FREE() to free acpi_object
2022-11-18 6:32 ` [PATCH 2/2] ACPI: pfr_update: " Wang ShaoBo
@ 2022-11-18 11:23 ` Chen Yu
0 siblings, 0 replies; 6+ messages in thread
From: Chen Yu @ 2022-11-18 11:23 UTC (permalink / raw)
To: Wang ShaoBo
Cc: rafael.j.wysocki, rafael, lenb, linux-acpi, guohanjun, liwei391,
linux-kernel, rui.zhang
On 2022-11-18 at 14:32:19 +0800, Wang ShaoBo wrote:
> acpi_evaluate_dsm_typed()/acpi_evaluate_dsm() should be coupled with
> ACPI_FREE() to free the ACPI memory, because we need to track the
> allocation of acpi_object when ACPI_DBG_TRACK_ALLOCATIONS enabled,
> so use ACPI_FREE() instead of kfree().
>
> Fixes: 0db89fa243e5 ("ACPI: Introduce Platform Firmware Runtime Update device driver")
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
Reviewed-by: Chen Yu <yu.c.chen@intel.com>
thanks,
Chenyu
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] change to use ACPI_FREE() to free the ACPI memory
2022-11-18 6:32 [PATCH 0/2] change to use ACPI_FREE() to free the ACPI memory Wang ShaoBo
2022-11-18 6:32 ` [PATCH 1/2] ACPI: pfr_telemetry: use ACPI_FREE() to free acpi_object Wang ShaoBo
2022-11-18 6:32 ` [PATCH 2/2] ACPI: pfr_update: " Wang ShaoBo
@ 2022-11-23 18:30 ` Rafael J. Wysocki
2 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2022-11-23 18:30 UTC (permalink / raw)
To: Wang ShaoBo
Cc: rafael.j.wysocki, rafael, lenb, yu.c.chen, linux-acpi, guohanjun,
liwei391, linux-kernel
On Fri, Nov 18, 2022 at 7:33 AM Wang ShaoBo <bobo.shaobowang@huawei.com> wrote:
>
> acpi_evaluate_dsm_typed()/acpi_evaluate_dsm() should be coupled with
> ACPI_FREE() to free the ACPI memory, because we need to track the
> allocation of acpi_object when ACPI_DBG_TRACK_ALLOCATIONS enabled,
> so use ACPI_FREE() instead of kfree().
>
> Wang ShaoBo (2):
> ACPI: pfr_telemetry: use ACPI_FREE() to free acpi_object
> ACPI: pfr_update: use ACPI_FREE() to free acpi_object
>
> drivers/acpi/pfr_telemetry.c | 6 +++---
> drivers/acpi/pfr_update.c | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> --
Both applied as 6.2 material, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread