* [PATCH] arm64: dts: amlogic: align LED node names with dtschema @ 2022-11-25 14:41 Krzysztof Kozlowski 2022-11-25 17:16 ` Neil Armstrong ` (2 more replies) 0 siblings, 3 replies; 11+ messages in thread From: Krzysztof Kozlowski @ 2022-11-25 14:41 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel Cc: Krzysztof Kozlowski The node names should be generic and DT schema expects certain pattern: amlogic/meson-sm1-bananapi-m5.dtb: leds: 'blue' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts index cadba194b149..028220ed45ad 100644 --- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts @@ -81,13 +81,13 @@ hdmi_connector_in: endpoint { leds { compatible = "gpio-leds"; - green { + led-green { color = <LED_COLOR_ID_GREEN>; function = LED_FUNCTION_STATUS; gpios = <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>; }; - blue { + led-blue { color = <LED_COLOR_ID_BLUE>; function = LED_FUNCTION_STATUS; gpios = <&gpio_ao GPIOAO_11 GPIO_ACTIVE_LOW>; -- 2.34.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema 2022-11-25 14:41 [PATCH] arm64: dts: amlogic: align LED node names with dtschema Krzysztof Kozlowski @ 2022-11-25 17:16 ` Neil Armstrong 2022-11-26 14:16 ` Krzysztof Kozlowski 2022-11-25 22:55 ` Martin Blumenstingl 2023-01-02 9:45 ` Neil Armstrong 2 siblings, 1 reply; 11+ messages in thread From: Neil Armstrong @ 2022-11-25 17:16 UTC (permalink / raw) To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel On 25/11/2022 15:41, Krzysztof Kozlowski wrote: > The node names should be generic and DT schema expects certain pattern: > > amlogic/meson-sm1-bananapi-m5.dtb: leds: 'blue' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > <snip> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema 2022-11-25 17:16 ` Neil Armstrong @ 2022-11-26 14:16 ` Krzysztof Kozlowski 2022-11-26 14:24 ` Krzysztof Kozlowski 0 siblings, 1 reply; 11+ messages in thread From: Krzysztof Kozlowski @ 2022-11-26 14:16 UTC (permalink / raw) To: neil.armstrong, Rob Herring, Krzysztof Kozlowski, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel On 25/11/2022 18:16, Neil Armstrong wrote: > On 25/11/2022 15:41, Krzysztof Kozlowski wrote: >> The node names should be generic and DT schema expects certain pattern: >> >> amlogic/meson-sm1-bananapi-m5.dtb: leds: 'blue' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> > > > <snip> > > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Aren't you maintainer of the platform? This means I should take care of this patch? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema 2022-11-26 14:16 ` Krzysztof Kozlowski @ 2022-11-26 14:24 ` Krzysztof Kozlowski 2022-11-26 16:03 ` Neil Armstrong 0 siblings, 1 reply; 11+ messages in thread From: Krzysztof Kozlowski @ 2022-11-26 14:24 UTC (permalink / raw) To: neil.armstrong, Rob Herring, Krzysztof Kozlowski, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel On 26/11/2022 15:16, Krzysztof Kozlowski wrote: > On 25/11/2022 18:16, Neil Armstrong wrote: >> On 25/11/2022 15:41, Krzysztof Kozlowski wrote: >>> The node names should be generic and DT schema expects certain pattern: >>> >>> amlogic/meson-sm1-bananapi-m5.dtb: leds: 'blue' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >>> arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >> >> >> <snip> >> >> >> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> > > Aren't you maintainer of the platform? This means I should take care of > this patch? Ah, this will be picked up by Kevin or Jerome? So this tag means only Reviewer's statement of oversight, right? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema 2022-11-26 14:24 ` Krzysztof Kozlowski @ 2022-11-26 16:03 ` Neil Armstrong 2022-11-27 12:25 ` Krzysztof Kozlowski 0 siblings, 1 reply; 11+ messages in thread From: Neil Armstrong @ 2022-11-26 16:03 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Rob Herring, Krzysztof Kozlowski, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel On Sat, 26 Nov 2022 at 15:24, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 26/11/2022 15:16, Krzysztof Kozlowski wrote: > > On 25/11/2022 18:16, Neil Armstrong wrote: > >> On 25/11/2022 15:41, Krzysztof Kozlowski wrote: > >>> The node names should be generic and DT schema expects certain pattern: > >>> > >>> amlogic/meson-sm1-bananapi-m5.dtb: leds: 'blue' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' > >>> > >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>> --- > >>> arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >> > >> > >> <snip> > >> > >> > >> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> > > > > Aren't you maintainer of the platform? This means I should take care of > > this patch? > > Ah, this will be picked up by Kevin or Jerome? So this tag means only > Reviewer's statement of oversight, right? Of course I'll pick it. Neil > > Best regards, > Krzysztof > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema 2022-11-26 16:03 ` Neil Armstrong @ 2022-11-27 12:25 ` Krzysztof Kozlowski 2022-11-27 13:33 ` Neil Armstrong 0 siblings, 1 reply; 11+ messages in thread From: Krzysztof Kozlowski @ 2022-11-27 12:25 UTC (permalink / raw) To: Neil Armstrong Cc: Rob Herring, Krzysztof Kozlowski, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel On 26/11/2022 17:03, Neil Armstrong wrote: >>>> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> >>> >>> Aren't you maintainer of the platform? This means I should take care of >>> this patch? >> >> Ah, this will be picked up by Kevin or Jerome? So this tag means only >> Reviewer's statement of oversight, right? > > Of course I'll pick it. > So that's confusing to see Review which does not mean review, but maintainer pick... Reviewed-by means, I should take your tag and add to v2 or the maintainer will add it when picking up. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema 2022-11-27 12:25 ` Krzysztof Kozlowski @ 2022-11-27 13:33 ` Neil Armstrong 2022-11-27 19:07 ` Krzysztof Kozlowski 0 siblings, 1 reply; 11+ messages in thread From: Neil Armstrong @ 2022-11-27 13:33 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Rob Herring, Krzysztof Kozlowski, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel Le 27/11/2022 à 13:25, Krzysztof Kozlowski a écrit : > On 26/11/2022 17:03, Neil Armstrong wrote: >>>>> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> >>>> Aren't you maintainer of the platform? This means I should take care of >>>> this patch? >>> Ah, this will be picked up by Kevin or Jerome? So this tag means only >>> Reviewer's statement of oversight, right? >> Of course I'll pick it. >> > So that's confusing to see Review which does not mean review, but > maintainer pick... Reviewed-by means reviewed, there's no confusion here, the significance is clearly documented on https://docs.kernel.org/process/submitting-patches.html > > Reviewed-by means, I should take your tag and add to v2 or the > maintainer will add it when picking up. Reviewed-by means reviewed, fully reviewed patches are ready to be picked unless a change is asked by a reviewer. Decision to pick or not a patch does not depend on any tags, but is the sole decision of the maintainer adding it's Signed-off-by. While I use Acked-by to signify acceptance to other maintainers on files I authored or files I maintain but cannot pick, here I don't need to signify acceptance to myself. Neil > > Best regards, > Krzysztof > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema 2022-11-27 13:33 ` Neil Armstrong @ 2022-11-27 19:07 ` Krzysztof Kozlowski 2022-11-28 7:17 ` Neil Armstrong 0 siblings, 1 reply; 11+ messages in thread From: Krzysztof Kozlowski @ 2022-11-27 19:07 UTC (permalink / raw) To: Neil Armstrong Cc: Rob Herring, Krzysztof Kozlowski, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel On 27/11/2022 14:33, Neil Armstrong wrote: > > Le 27/11/2022 à 13:25, Krzysztof Kozlowski a écrit : >> On 26/11/2022 17:03, Neil Armstrong wrote: >>>>>> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> >>>>> Aren't you maintainer of the platform? This means I should take care of >>>>> this patch? >>>> Ah, this will be picked up by Kevin or Jerome? So this tag means only >>>> Reviewer's statement of oversight, right? >>> Of course I'll pick it. >>> >> So that's confusing to see Review which does not mean review, but >> maintainer pick... > > Reviewed-by means reviewed, there's no confusion here, the significance > is clearly documented on https://docs.kernel.org/process/submitting-patches.html > >> >> Reviewed-by means, I should take your tag and add to v2 or the >> maintainer will add it when picking up. > > Reviewed-by means reviewed, fully reviewed patches are ready to > be picked unless a change is asked by a reviewer. > > Decision to pick or not a patch does not depend on any tags, but > is the sole decision of the maintainer adding it's Signed-off-by. Then why giving review tag and not notifying about the pick, while the pick actually happens? This is confusing. When the maintainer, which is supposed to pick patch, gives reviewed it means always the same as acked, so the patch is expected to go other way. Not through that maintainer's tree. If you just apply it, say you apply it. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema 2022-11-27 19:07 ` Krzysztof Kozlowski @ 2022-11-28 7:17 ` Neil Armstrong 0 siblings, 0 replies; 11+ messages in thread From: Neil Armstrong @ 2022-11-28 7:17 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Rob Herring, Krzysztof Kozlowski, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel Hi Krzysztof, Le 27/11/2022 à 20:07, Krzysztof Kozlowski a écrit : > On 27/11/2022 14:33, Neil Armstrong wrote: >> >> Le 27/11/2022 à 13:25, Krzysztof Kozlowski a écrit : >>> On 26/11/2022 17:03, Neil Armstrong wrote: >>>>>>> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> >>>>>> Aren't you maintainer of the platform? This means I should take care of >>>>>> this patch? >>>>> Ah, this will be picked up by Kevin or Jerome? So this tag means only >>>>> Reviewer's statement of oversight, right? >>>> Of course I'll pick it. >>>> >>> So that's confusing to see Review which does not mean review, but >>> maintainer pick... >> >> Reviewed-by means reviewed, there's no confusion here, the significance >> is clearly documented on https://docs.kernel.org/process/submitting-patches.html >> >>> >>> Reviewed-by means, I should take your tag and add to v2 or the >>> maintainer will add it when picking up. >> >> Reviewed-by means reviewed, fully reviewed patches are ready to >> be picked unless a change is asked by a reviewer. >> >> Decision to pick or not a patch does not depend on any tags, but >> is the sole decision of the maintainer adding it's Signed-off-by. > > Then why giving review tag and not notifying about the pick, while the > pick actually happens? This is confusing. When the maintainer, which is > supposed to pick patch, gives reviewed it means always the same as > acked, so the patch is expected to go other way. Not through that > maintainer's tree. > > If you just apply it, say you apply it. This last reply goes beyond acceptability on my side, this thread went too far and I'll stop replying further after this. If your goal was to kindly ask me to use Acked-by to notify you I'll pick the patch in the future, while this "rule" is only implicit, the actual form is far from it. Concerning this patch, since I already sent the ARM64 DT PR for v6.2, and I usually don't take new changes except urgent ones after rc6, I'll pick this patch and "20221125144120.476933-1-krzysztof.kozlowski@linaro.org" after the next merge window and you'll be notified as I always do. > > Best regards, > Krzysztof > Neil ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema 2022-11-25 14:41 [PATCH] arm64: dts: amlogic: align LED node names with dtschema Krzysztof Kozlowski 2022-11-25 17:16 ` Neil Armstrong @ 2022-11-25 22:55 ` Martin Blumenstingl 2023-01-02 9:45 ` Neil Armstrong 2 siblings, 0 replies; 11+ messages in thread From: Martin Blumenstingl @ 2022-11-25 22:55 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Rob Herring, Krzysztof Kozlowski, Neil Armstrong, Kevin Hilman, Jerome Brunet, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel On Fri, Nov 25, 2022 at 3:41 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > The node names should be generic and DT schema expects certain pattern: > > amlogic/meson-sm1-bananapi-m5.dtb: leds: 'blue' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thank you for this patch! It's: Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema 2022-11-25 14:41 [PATCH] arm64: dts: amlogic: align LED node names with dtschema Krzysztof Kozlowski 2022-11-25 17:16 ` Neil Armstrong 2022-11-25 22:55 ` Martin Blumenstingl @ 2023-01-02 9:45 ` Neil Armstrong 2 siblings, 0 replies; 11+ messages in thread From: Neil Armstrong @ 2023-01-02 9:45 UTC (permalink / raw) To: Martin Blumenstingl, Krzysztof Kozlowski, Kevin Hilman, Krzysztof Kozlowski, linux-amlogic, linux-kernel, Rob Herring, Jerome Brunet, devicetree, linux-arm-kernel Hi, On Fri, 25 Nov 2022 15:41:41 +0100, Krzysztof Kozlowski wrote: > The node names should be generic and DT schema expects certain pattern: > > amlogic/meson-sm1-bananapi-m5.dtb: leds: 'blue' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' > > Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.3/arm64-dt) [1/1] arm64: dts: amlogic: align LED node names with dtschema https://git.kernel.org/amlogic/c/ac7f40c28bce2fd1a771e634531ca4b0dd9576f7 These changes has been applied on the intermediate git tree [1]. The v6.3/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers for inclusion in their intermediate git branches in order to be sent to Linus during the next merge window, or sooner if it's a set of fixes. In the cases of fixes, those will be merged in the current release candidate kernel and as soon they appear on the Linux master branch they will be backported to the previous Stable and Long-Stable kernels [2]. The intermediate git branches are merged daily in the linux-next tree [3], people are encouraged testing these pre-release kernels and report issues on the relevant mailing-lists. If problems are discovered on those changes, please submit a signed-off-by revert patch followed by a corrective changeset. [1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git [3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git -- Neil ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-01-02 9:46 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-11-25 14:41 [PATCH] arm64: dts: amlogic: align LED node names with dtschema Krzysztof Kozlowski 2022-11-25 17:16 ` Neil Armstrong 2022-11-26 14:16 ` Krzysztof Kozlowski 2022-11-26 14:24 ` Krzysztof Kozlowski 2022-11-26 16:03 ` Neil Armstrong 2022-11-27 12:25 ` Krzysztof Kozlowski 2022-11-27 13:33 ` Neil Armstrong 2022-11-27 19:07 ` Krzysztof Kozlowski 2022-11-28 7:17 ` Neil Armstrong 2022-11-25 22:55 ` Martin Blumenstingl 2023-01-02 9:45 ` Neil Armstrong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).