From: Rob Herring <robh@kernel.org>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic
Date: Wed, 7 Dec 2022 09:35:53 -0600 [thread overview]
Message-ID: <20221207153553.GA2269092-robh@kernel.org> (raw)
In-Reply-To: <20221207055405.30940-10-hayashi.kunihiko@socionext.com>
On Wed, Dec 07, 2022 at 02:53:58PM +0900, Kunihiko Hayashi wrote:
> Add devicetree binding schema for the SoC-glue logic implemented on
> Socionext Uniphier SoCs.
>
> This SoC-glue logic is a set of miscellaneous function registers
> handling signals for specific devices outside system components,
> and also has multiple functions such as I/O pinmux, usb-phy, debug,
> clock-mux for a specific SoC, and so on.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext,uniphier-soc-glue.yaml | 113 ++++++++++++++++++
> 1 file changed, 113 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
> new file mode 100644
> index 000000000000..6fc790963660
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
> @@ -0,0 +1,113 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-soc-glue.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Socionext UniPhier SoC-glue logic
> +
> +maintainers:
> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> +
> +description: |+
> + SoC-glue logic implemented on Socionext UniPhier SoCs is a collection of
> + miscellaneous function registers handling signals outside system components.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - socionext,uniphier-ld4-soc-glue
> + - socionext,uniphier-pro4-soc-glue
> + - socionext,uniphier-pro5-soc-glue
> + - socionext,uniphier-pxs2-soc-glue
> + - socionext,uniphier-sld8-soc-glue
> + - socionext,uniphier-ld11-soc-glue
> + - socionext,uniphier-ld20-soc-glue
> + - socionext,uniphier-pxs3-soc-glue
> + - socionext,uniphier-nx1-soc-glue
> + - const: simple-mfd
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + "^pinctrl(@[0-9a-f]+)?$":
> + $ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml#
> +
> + "^usb-hub(@[0-9a-f]+)?$":
> + $ref: /schemas/phy/socionext,uniphier-usb2-phy.yaml#
> +
> + "^clock-controller(@[0-9a-f]+)?$":
> + $ref: /schemas/clock/socionext,uniphier-clock.yaml#
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - socionext,uniphier-pro4-soc-glue
> + - socionext,uniphier-ld11-soc-glue
> + else:
> + patternProperties:
> + "^usb-hub(@[0-9a-f]+)?$": false
While just if and else is valid json-schema, we require 'then'. Can you
change this to 'if: { not: {...}, then: {}'.
You should be getting a warning for this. The rest of the warnings from
the bot look like false positives you can ignore.
Rob
next prev parent reply other threads:[~2022-12-07 15:35 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 01/16] dt-bindings: clock: Fix node descriptions in uniphier-clock example Kunihiko Hayashi
2022-12-08 8:06 ` Krzysztof Kozlowski
2022-12-08 15:09 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 02/16] dt-bindings: reset: Fix node descriptions in uniphier-reset example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example Kunihiko Hayashi
2022-12-08 8:07 ` Krzysztof Kozlowski
2022-12-08 15:09 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 04/16] dt-bindings: watchdog: Fix node descriptions in uniphier-wdt example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 05/16] dt-bindings: thermal: Fix node descriptions in uniphier-thermal example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 06/16] dt-bindings: phy: Fix node descriptions in uniphier-phy example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 07/16] dt-bindings: nvmem: Fix node descriptions in uniphier-efuse example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 08/16] dt-bindings: soc: socionext: Add UniPhier system controller Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 6:37 ` Kunihiko Hayashi
2022-12-08 8:15 ` Krzysztof Kozlowski
2022-12-08 15:09 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic Kunihiko Hayashi
2022-12-07 15:35 ` Rob Herring [this message]
2022-12-08 6:37 ` Kunihiko Hayashi
2022-12-08 8:16 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 10/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 8:18 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
2022-12-07 5:54 ` [PATCH v2 11/16] dt-bindings: soc: socionext: Add UniPhier peripheral block Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-07 5:54 ` [PATCH v2 12/16] dt-bindings: soc: socionext: Add UniPhier media I/O block Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-07 5:54 ` [PATCH v2 13/16] dt-bindings: soc: socionext: Add UniPhier SD interface block Kunihiko Hayashi
2022-12-07 5:54 ` [PATCH v2 14/16] dt-bindings: soc: socionext: Add UniPhier ADAMV block Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-07 5:54 ` [PATCH v2 15/16] dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 8:23 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
2022-12-07 5:54 ` [PATCH v2 16/16] dt-bindings: soc: socionext: Add UniPhier AHCI " Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 8:24 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207153553.GA2269092-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).