Re: [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic

[Kunihiko Hayashi <hayashi.kunihiko@socionext.com>]

On 2022/12/08 17:16, Krzysztof Kozlowski wrote:> On 07/12/2022 06:53, Kunihiko Hayashi wrote:
 >> Add devicetree binding schema for the SoC-glue logic implemented on
 >> Socionext Uniphier SoCs.
 >>
 >> This SoC-glue logic is a set of miscellaneous function registers
 >> handling signals for specific devices outside system components,
 >> and also has multiple functions such as I/O pinmux, usb-phy, debug,
 >> clock-mux for a specific SoC, and so on.
 >>
 >> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
 >> ---
 >>   .../socionext,uniphier-soc-glue.yaml          | 113 ++++++++++++++++++
 >>   1 file changed, 113 insertions(+)
 >>   create mode 100644
 >> Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
 >>
 >> diff --git
 >> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
 >> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
 >> new file mode 100644
 >> index 000000000000..6fc790963660
 >> --- /dev/null
 >> +++
 >> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
 >> @@ -0,0 +1,113 @@
 >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 >> +%YAML 1.2
 >> +---
 >> +$id:
 >> http://devicetree.org/schemas/soc/socionext/socionext,uniphier-soc-glue.yaml#
 >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
 >> +
 >> +title: Socionext UniPhier SoC-glue logic
 >> +
 >> +maintainers:
 >> +  - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
 >> +
 >> +description: |+
 >> +  SoC-glue logic implemented on Socionext UniPhier SoCs is a collection
 >> of
 >> +  miscellaneous function registers handling signals outside system
 >> components.
 >> +
 >> +properties:
 >> +  compatible:
 >> +    items:
 >> +      - enum:
 >> +          - socionext,uniphier-ld4-soc-glue
 >> +          - socionext,uniphier-pro4-soc-glue
 >> +          - socionext,uniphier-pro5-soc-glue
 >> +          - socionext,uniphier-pxs2-soc-glue
 >> +          - socionext,uniphier-sld8-soc-glue
 >> +          - socionext,uniphier-ld11-soc-glue
 >> +          - socionext,uniphier-ld20-soc-glue
 >> +          - socionext,uniphier-pxs3-soc-glue
 >> +          - socionext,uniphier-nx1-soc-glue
 >> +      - const: simple-mfd
 >> +      - const: syscon
 >> +
 >> +  reg:
 >> +    maxItems: 1
 >> +
 >> +patternProperties:
 >> +  "^pinctrl(@[0-9a-f]+)?$":
 >
 > Your children cannot have unit address in this binding (not mentioning
 > that children schema has in example statement that unit address is
 > invalid: "must be a child of syscon node").

Same as uniphier-sysctrl, I'll drop the address patterns.

Thank you,

---
Best Regards
Kunihiko Hayashi