From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/16] dt-bindings: clock: Fix node descriptions in uniphier-clock example
Date: Fri, 9 Dec 2022 00:09:41 +0900 [thread overview]
Message-ID: <8d29ddb9-359c-df91-abb6-acdb6927fa95@socionext.com> (raw)
In-Reply-To: <c2782196-6dae-522a-50d5-5e5223e66e56@linaro.org>
On 2022/12/08 17:06, Krzysztof Kozlowski wrote:
> On 07/12/2022 06:53, Kunihiko Hayashi wrote:
>> Prior to adding dt-bindings for SoC-dependent controllers, rename the
>> clock nodes their parent nodes to the generic names in the example.
>>
>> And also fix the missing compatible string.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>> .../clock/socionext,uniphier-clock.yaml | 21 +++++++++++--------
>> 1 file changed, 12 insertions(+), 9 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml
>> b/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml
>> index 9a0cc7341630..672450a1ecda 100644
>> ---
>> a/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml
>> +++
>> b/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml
>> @@ -61,11 +61,12 @@ required:
>>
>> examples:
>> - |
>> - sysctrl@61840000 {
>> - compatible = "socionext,uniphier-sysctrl", "simple-mfd",
>> "syscon";
>> + syscon@61840000 {
>> + compatible = "socionext,uniphier-ld11-sysctrl",
>> + "simple-mfd", "syscon";
>> reg = <0x61840000 0x4000>;
>>
>> - clock {
>> + clock-controller {
>> compatible = "socionext,uniphier-ld11-clock";
>> #clock-cells = <1>;
>> };
>> @@ -74,11 +75,12 @@ examples:
>> };
>>
>> - |
>> - mioctrl@59810000 {
>> - compatible = "socionext,uniphier-mioctrl", "simple-mfd",
>> "syscon";
>> + syscon@59810000 {
>> + compatible = "socionext,uniphier-ld11-mioctrl",
>> + "simple-mfd", "syscon";
>> reg = <0x59810000 0x800>;
>>
>> - clock {
>> + clock-controller {
>> compatible = "socionext,uniphier-ld11-mio-clock";
>> #clock-cells = <1>;
>> };
>> @@ -87,11 +89,12 @@ examples:
>> };
>>
>> - |
>> - perictrl@59820000 {
>> - compatible = "socionext,uniphier-perictrl", "simple-mfd",
>> "syscon";
>> + syscon@59820000 {
>> + compatible = "socionext,uniphier-ld11-perictrl",
>> + "simple-mfd", "syscon";
>> reg = <0x59820000 0x200>;
>>
>> - clock {
>
> These are all three same examples (no differences except compatibles),
> so you can as well keep only one. You can also skip parent node,
> otherwise you might keep getting warnings for this schema. The parent is
> not that relevant here and its bindings (e.g.
> socionext,uniphier-sysctrl.yaml) should include complete example -
> parent with all the children.
I understand.
I'll keep one and drop the parent node from the example.
Thank you,
---
Best Regards
Kunihiko Hayashi
next prev parent reply other threads:[~2022-12-08 15:09 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 5:53 [PATCH v2 00/16] dt-bindings: soc: Introduce UniPhier miscellaneous register blocks and fix examples Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 01/16] dt-bindings: clock: Fix node descriptions in uniphier-clock example Kunihiko Hayashi
2022-12-08 8:06 ` Krzysztof Kozlowski
2022-12-08 15:09 ` Kunihiko Hayashi [this message]
2022-12-07 5:53 ` [PATCH v2 02/16] dt-bindings: reset: Fix node descriptions in uniphier-reset example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example Kunihiko Hayashi
2022-12-08 8:07 ` Krzysztof Kozlowski
2022-12-08 15:09 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 04/16] dt-bindings: watchdog: Fix node descriptions in uniphier-wdt example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 05/16] dt-bindings: thermal: Fix node descriptions in uniphier-thermal example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 06/16] dt-bindings: phy: Fix node descriptions in uniphier-phy example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 07/16] dt-bindings: nvmem: Fix node descriptions in uniphier-efuse example Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 08/16] dt-bindings: soc: socionext: Add UniPhier system controller Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 6:37 ` Kunihiko Hayashi
2022-12-08 8:15 ` Krzysztof Kozlowski
2022-12-08 15:09 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic Kunihiko Hayashi
2022-12-07 15:35 ` Rob Herring
2022-12-08 6:37 ` Kunihiko Hayashi
2022-12-08 8:16 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
2022-12-07 5:53 ` [PATCH v2 10/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic debug part Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 8:18 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
2022-12-07 5:54 ` [PATCH v2 11/16] dt-bindings: soc: socionext: Add UniPhier peripheral block Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-07 5:54 ` [PATCH v2 12/16] dt-bindings: soc: socionext: Add UniPhier media I/O block Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-07 5:54 ` [PATCH v2 13/16] dt-bindings: soc: socionext: Add UniPhier SD interface block Kunihiko Hayashi
2022-12-07 5:54 ` [PATCH v2 14/16] dt-bindings: soc: socionext: Add UniPhier ADAMV block Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-07 5:54 ` [PATCH v2 15/16] dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 8:23 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
2022-12-07 5:54 ` [PATCH v2 16/16] dt-bindings: soc: socionext: Add UniPhier AHCI " Kunihiko Hayashi
2022-12-07 14:19 ` Rob Herring
2022-12-08 8:24 ` Krzysztof Kozlowski
2022-12-08 15:11 ` Kunihiko Hayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d29ddb9-359c-df91-abb6-acdb6927fa95@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).