* [PATCH RESEND 3/4] backlight: ipaq_micro: Use backlight helper
@ 2023-01-06 16:48 Stephen Kitt
2023-01-06 18:26 ` Sam Ravnborg
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stephen Kitt @ 2023-01-06 16:48 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han
Cc: Sam Ravnborg, Stephen Kitt, Helge Deller, dri-devel, linux-fbdev,
linux-kernel
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt <steve@sk2.org>
---
drivers/video/backlight/ipaq_micro_bl.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/video/backlight/ipaq_micro_bl.c b/drivers/video/backlight/ipaq_micro_bl.c
index 85b16cc82878..f595b8c8cbb2 100644
--- a/drivers/video/backlight/ipaq_micro_bl.c
+++ b/drivers/video/backlight/ipaq_micro_bl.c
@@ -16,17 +16,12 @@
static int micro_bl_update_status(struct backlight_device *bd)
{
struct ipaq_micro *micro = dev_get_drvdata(&bd->dev);
- int intensity = bd->props.brightness;
+ int intensity = backlight_get_brightness(bd);
struct ipaq_micro_msg msg = {
.id = MSG_BACKLIGHT,
.tx_len = 3,
};
- if (bd->props.power != FB_BLANK_UNBLANK)
- intensity = 0;
- if (bd->props.state & (BL_CORE_FBBLANK | BL_CORE_SUSPENDED))
- intensity = 0;
-
/*
* Message format:
* Byte 0: backlight instance (usually 1)
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND 3/4] backlight: ipaq_micro: Use backlight helper
2023-01-06 16:48 [PATCH RESEND 3/4] backlight: ipaq_micro: Use backlight helper Stephen Kitt
@ 2023-01-06 18:26 ` Sam Ravnborg
2023-01-09 10:17 ` Daniel Thompson
2023-01-19 21:39 ` Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2023-01-06 18:26 UTC (permalink / raw)
To: Stephen Kitt
Cc: Lee Jones, Daniel Thompson, Jingoo Han, linux-fbdev,
Helge Deller, linux-kernel, dri-devel
On Fri, Jan 06, 2023 at 05:48:54PM +0100, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/video/backlight/ipaq_micro_bl.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/video/backlight/ipaq_micro_bl.c b/drivers/video/backlight/ipaq_micro_bl.c
> index 85b16cc82878..f595b8c8cbb2 100644
> --- a/drivers/video/backlight/ipaq_micro_bl.c
> +++ b/drivers/video/backlight/ipaq_micro_bl.c
> @@ -16,17 +16,12 @@
> static int micro_bl_update_status(struct backlight_device *bd)
> {
> struct ipaq_micro *micro = dev_get_drvdata(&bd->dev);
> - int intensity = bd->props.brightness;
> + int intensity = backlight_get_brightness(bd);
> struct ipaq_micro_msg msg = {
> .id = MSG_BACKLIGHT,
> .tx_len = 3,
> };
>
> - if (bd->props.power != FB_BLANK_UNBLANK)
> - intensity = 0;
> - if (bd->props.state & (BL_CORE_FBBLANK | BL_CORE_SUSPENDED))
> - intensity = 0;
> -
> /*
> * Message format:
> * Byte 0: backlight instance (usually 1)
> --
> 2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND 3/4] backlight: ipaq_micro: Use backlight helper
2023-01-06 16:48 [PATCH RESEND 3/4] backlight: ipaq_micro: Use backlight helper Stephen Kitt
2023-01-06 18:26 ` Sam Ravnborg
@ 2023-01-09 10:17 ` Daniel Thompson
2023-01-19 21:39 ` Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Thompson @ 2023-01-09 10:17 UTC (permalink / raw)
To: Stephen Kitt
Cc: Lee Jones, Jingoo Han, Sam Ravnborg, Helge Deller, dri-devel,
linux-fbdev, linux-kernel
On Fri, Jan 06, 2023 at 05:48:54PM +0100, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
For the tools:
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
D.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND 3/4] backlight: ipaq_micro: Use backlight helper
2023-01-06 16:48 [PATCH RESEND 3/4] backlight: ipaq_micro: Use backlight helper Stephen Kitt
2023-01-06 18:26 ` Sam Ravnborg
2023-01-09 10:17 ` Daniel Thompson
@ 2023-01-19 21:39 ` Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2023-01-19 21:39 UTC (permalink / raw)
To: Stephen Kitt
Cc: Daniel Thompson, Jingoo Han, Sam Ravnborg, Helge Deller,
dri-devel, linux-fbdev, linux-kernel
On Fri, 06 Jan 2023, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> ---
> drivers/video/backlight/ipaq_micro_bl.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-20 5:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-06 16:48 [PATCH RESEND 3/4] backlight: ipaq_micro: Use backlight helper Stephen Kitt
2023-01-06 18:26 ` Sam Ravnborg
2023-01-09 10:17 ` Daniel Thompson
2023-01-19 21:39 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).