* [PATCH] trap: Fix warning comparing pointer to 0
@ 2023-01-28 9:39 Jiapeng Chong
2023-01-30 16:43 ` Brian Cain
0 siblings, 1 reply; 4+ messages in thread
From: Jiapeng Chong @ 2023-01-28 9:39 UTC (permalink / raw)
To: bcain; +Cc: linux-hexagon, linux-kernel, Jiapeng Chong, Abaci Robot
Avoid pointer type value compared with 0 to make code clear.
./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3860
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
arch/hexagon/kernel/traps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c
index 6447763ce5a9..fdbbf78b4ce0 100644
--- a/arch/hexagon/kernel/traps.c
+++ b/arch/hexagon/kernel/traps.c
@@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task, unsigned long *fp,
}
/* Attempt to continue past exception. */
- if (0 == newfp) {
+ if (!newfp) {
struct pt_regs *regs = (struct pt_regs *) (((void *)fp)
+ 8);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] trap: Fix warning comparing pointer to 0
2023-01-28 9:39 [PATCH] trap: Fix warning comparing pointer to 0 Jiapeng Chong
@ 2023-01-30 16:43 ` Brian Cain
0 siblings, 0 replies; 4+ messages in thread
From: Brian Cain @ 2023-01-30 16:43 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: linux-hexagon, linux-kernel, Abaci Robot
> -----Original Message-----
> From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
...
>
> Avoid pointer type value compared with 0 to make code clear.
>
> ./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3860
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> arch/hexagon/kernel/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c
> index 6447763ce5a9..fdbbf78b4ce0 100644
> --- a/arch/hexagon/kernel/traps.c
> +++ b/arch/hexagon/kernel/traps.c
> @@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task,
> unsigned long *fp,
> }
>
> /* Attempt to continue past exception. */
> - if (0 == newfp) {
> + if (!newfp) {
> struct pt_regs *regs = (struct pt_regs *) (((void *)fp)
> + 8);
>
> --
> 2.20.1.7.g153144c
Acked-by: Brian Cain <bcain@quicinc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] trap: Fix warning comparing pointer to 0
@ 2021-09-06 9:33 Jiapeng Chong
2021-09-07 2:23 ` Brian Cain
0 siblings, 1 reply; 4+ messages in thread
From: Jiapeng Chong @ 2021-09-06 9:33 UTC (permalink / raw)
To: bcain; +Cc: linux-hexagon, linux-kernel, chongjiapeng
From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
Fix the following coccicheck warning:
./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
---
arch/hexagon/kernel/traps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c
index edfc35d..3b6e0de 100644
--- a/arch/hexagon/kernel/traps.c
+++ b/arch/hexagon/kernel/traps.c
@@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task, unsigned long *fp,
}
/* Attempt to continue past exception. */
- if (0 == newfp) {
+ if (!newfp) {
struct pt_regs *regs = (struct pt_regs *) (((void *)fp)
+ 8);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] trap: Fix warning comparing pointer to 0
2021-09-06 9:33 Jiapeng Chong
@ 2021-09-07 2:23 ` Brian Cain
0 siblings, 0 replies; 4+ messages in thread
From: Brian Cain @ 2021-09-07 2:23 UTC (permalink / raw)
To: 'Jiapeng Chong'; +Cc: linux-hexagon, linux-kernel
> -----Original Message-----
> From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Sent: Monday, September 6, 2021 4:33 AM
> To: bcain@codeaurora.org
> Cc: linux-hexagon@vger.kernel.org; linux-kernel@vger.kernel.org;
> chongjiapeng <jiapeng.chong@linux.alibaba.com>
> Subject: [PATCH] trap: Fix warning comparing pointer to 0
>
> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>
> Fix the following coccicheck warning:
>
> ./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
> ---
> arch/hexagon/kernel/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c
> index edfc35d..3b6e0de 100644
> --- a/arch/hexagon/kernel/traps.c
> +++ b/arch/hexagon/kernel/traps.c
> @@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task,
> unsigned long *fp,
> }
>
> /* Attempt to continue past exception. */
> - if (0 == newfp) {
> + if (!newfp) {
> struct pt_regs *regs = (struct pt_regs *) (((void
*)fp)
> + 8);
>
Reviewed-by: Brian Cain <bcain@codeaurora.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-30 16:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-28 9:39 [PATCH] trap: Fix warning comparing pointer to 0 Jiapeng Chong
2023-01-30 16:43 ` Brian Cain
-- strict thread matches above, loose matches on Subject: below --
2021-09-06 9:33 Jiapeng Chong
2021-09-07 2:23 ` Brian Cain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).