From: Serge Semin <fancer.lancer@gmail.com>
To: Cai Huoqing <cai.huoqing@linux.dev>
Cc: Sergey.Semin@baikalelectronics.ru,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 0/4] dmaengine: dw-edma: Add support for native HDMA
Date: Thu, 16 Feb 2023 11:56:05 +0300 [thread overview]
Message-ID: <20230216085605.smffk2b3xig34eqr@mobilestation> (raw)
In-Reply-To: <Y+2QOAsk6qFm56E3@chq-MS-7D45>
Hi Cai
On Thu, Feb 16, 2023 at 10:08:56AM +0800, Cai Huoqing wrote:
> On 13 2月 23 21:24:05, Cai Huoqing wrote:
> > From: Cai huoqing <cai.huoqing@linux.dev>
> >
> > Add support for HDMA NATIVE, as long the IP design has set
> > the compatible register map parameter-HDMA_NATIVE,
> > which allows compatibility for native HDMA register configuration.
> >
> > The HDMA Hyper-DMA IP is an enhancement of the eDMA embedded-DMA IP.
> > And the native HDMA registers are different from eDMA,
> > so this patch add support for HDMA NATIVE mode.
> >
> > HDMA write and read channels operate independently to maximize
> > the performance of the HDMA read and write data transfer over
> > the link When you configure the HDMA with multiple read channels,
> > then it uses a round robin (RR) arbitration scheme to select
> > the next read channel to be serviced.
> > The same applies when you have multiple write channels.
> >
> > The native HDMA driver also supports a maximum of 16 independent
> > channels (8 write + 8 read), which can run simultaneously.
> > Both SAR (Source Address Register) and DAR (Destination Address Register)
> > are alignmented to byte.dmaengine: dw-edma: Add support for native HDMA
> >
> > Cai huoqing (4):
> > dmaengine: dw-edma: Rename dw_edma_core_ops structure to
> > dw_edma_plat_ops
> > dmaengine: dw-edma: Create a new dw_edma_core_ops structure to
> > abstract controller operation
> > dmaengine: dw-edma: Add support for native HDMA
> > dmaengine: dw-edma: Add HDMA DebugFS support
> >
> > v2->v3:
> > [1/4]
> > 1.Add more commit log to explain why use dw_edma_plat_ops.
> > 2.Update the structure name in the DW PCIe driver.
> > [2/4]
> > 3.Use the reverse xmas tree vars definition order.
> > 4.Add edma core ops wrapper.
> > 5.Add dw_edma_done_interrupt() and dw_edma_abort_interrupt()
> > global methods.
> > 6.Fix some indentation.
> > 7.Fix some typo
> > 8.Make use off dw_edma_core prefix instead of dw_xdma_core_.
> > [3/4]
> > 9.Remove unnecessary include: dw-edma-v0-regs.h and dw-edma-v0-regs.h
> > 10.HDMA supports the LL descriptors placed on the CPU memory.
> > [4/4]
> > 11.Split DebugFS to be a separate patch.
> > 12.Refactor HDMA DebugFS like the series in @Bjorn tree.
> >
> > v2 link:
> > https://lore.kernel.org/lkml/20220925173412.u2ez6rbmfc5fupdn@mobilestation/
> Hi Sergey,
>
> Could you please give some comments for this patch v3
The series has landed in my inbox. I'll give you some comments shortly
today or tomorrow.
-Serge(y)
>
> Thanks,
> Cai
> >
> > drivers/dma/dw-edma/Makefile | 8 +-
> > drivers/dma/dw-edma/dw-edma-core.c | 63 ++--
> > drivers/dma/dw-edma/dw-edma-core.h | 92 ++++++
> > drivers/dma/dw-edma/dw-edma-pcie.c | 4 +-
> > drivers/dma/dw-edma/dw-edma-v0-core.c | 88 ++++-
> > drivers/dma/dw-edma/dw-edma-v0-core.h | 14 +-
> > drivers/dma/dw-edma/dw-hdma-v0-core.c | 317 +++++++++++++++++++
> > drivers/dma/dw-edma/dw-hdma-v0-core.h | 17 +
> > drivers/dma/dw-edma/dw-hdma-v0-debugfs.c | 175 ++++++++++
> > drivers/dma/dw-edma/dw-hdma-v0-debugfs.h | 22 ++
> > drivers/dma/dw-edma/dw-hdma-v0-regs.h | 129 ++++++++
> > drivers/pci/controller/dwc/pcie-designware.c | 2 +-
> > include/linux/dma/edma.h | 7 +-
> > 13 files changed, 860 insertions(+), 78 deletions(-)
> > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-core.c
> > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-core.h
> > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-debugfs.c
> > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-debugfs.h
> > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-regs.h
> >
> > --
> > 2.34.1
> >
prev parent reply other threads:[~2023-02-16 8:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 13:24 [PATCH v3 0/4] dmaengine: dw-edma: Add support for native HDMA Cai Huoqing
2023-02-13 13:24 ` [PATCH v3 1/4] dmaengine: dw-edma: Rename dw_edma_core_ops structure to dw_edma_plat_ops Cai Huoqing
2023-02-16 13:41 ` Serge Semin
2023-02-13 13:24 ` [PATCH v3 2/4] dmaengine: dw-edma: Create a new dw_edma_core_ops structure to abstract controller operation Cai Huoqing
2023-02-16 16:17 ` Serge Semin
2023-02-20 6:01 ` Cai Huoqing
2023-02-20 10:52 ` Serge Semin
2023-02-16 16:25 ` Serge Semin
2023-02-13 13:24 ` [PATCH v3 3/4] dmaengine: dw-edma: Add support for native HDMA Cai Huoqing
2023-02-13 15:20 ` kernel test robot
2023-02-14 2:00 ` Cai Huoqing
2023-02-13 20:59 ` Bjorn Helgaas
2023-02-14 2:03 ` Cai Huoqing
2023-02-16 16:38 ` Serge Semin
2023-02-16 16:41 ` Serge Semin
2023-02-13 13:24 ` [PATCH v3 4/4] dmaengine: dw-edma: Add HDMA DebugFS support Cai Huoqing
2023-02-16 17:10 ` Serge Semin
2023-02-16 2:08 ` [PATCH v3 0/4] dmaengine: dw-edma: Add support for native HDMA Cai Huoqing
2023-02-16 8:56 ` Serge Semin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216085605.smffk2b3xig34eqr@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=bhelgaas@google.com \
--cc=cai.huoqing@linux.dev \
--cc=dmaengine@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).