From: Johan Hovold <johan+linaro@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>,
Lee Jones <lee@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 1/3] dt-bindings: nvmem: qcom,spmi-sdam: fix example 'reg' property
Date: Mon, 20 Mar 2023 14:57:08 +0100 [thread overview]
Message-ID: <20230320135710.1989-2-johan+linaro@kernel.org> (raw)
In-Reply-To: <20230320135710.1989-1-johan+linaro@kernel.org>
The SPMI PMIC register region width is fixed and should not be encoded
in the devicetree.
Amend the example with a parent pmic node with the expected
'#address-cells' and '#size-cells' and fix up the 'reg' property.
Fixes: 9664a6b54c57 ("dt-bindings: nvmem: add binding for QTI SPMI SDAM")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
.../bindings/nvmem/qcom,spmi-sdam.yaml | 31 +++++++++++--------
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml b/Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml
index e08504ef3b6e..4702f10ecca2 100644
--- a/Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml
+++ b/Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml
@@ -42,17 +42,22 @@ unevaluatedProperties: false
examples:
- |
- sdam_1: nvram@b000 {
- #address-cells = <1>;
- #size-cells = <1>;
- compatible = "qcom,spmi-sdam";
- reg = <0xb000 0x100>;
- ranges = <0 0xb000 0x100>;
-
- /* Data cells */
- restart_reason: restart@50 {
- reg = <0x50 0x1>;
- bits = <6 2>;
- };
- };
+ pmic {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ sdam_1: nvram@b000 {
+ compatible = "qcom,spmi-sdam";
+ reg = <0xb000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0xb000 0x100>;
+
+ /* Data cells */
+ restart_reason: restart@50 {
+ reg = <0x50 0x1>;
+ bits = <6 2>;
+ };
+ };
+ };
...
--
2.39.2
next prev parent reply other threads:[~2023-03-20 13:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 13:57 [PATCH 0/3] arm64: dts: qcom: sc8280xp-pmics: fix sdam 'reg' property Johan Hovold
2023-03-20 13:57 ` Johan Hovold [this message]
2023-03-20 14:12 ` [PATCH 1/3] dt-bindings: nvmem: qcom,spmi-sdam: fix example " Krzysztof Kozlowski
2023-03-20 14:40 ` Johan Hovold
2023-03-20 13:57 ` [PATCH 2/3] arm64: dts: qcom: sc8280xp-pmics: fix sdam " Johan Hovold
2023-03-20 14:05 ` Konrad Dybcio
2023-03-20 14:11 ` Krzysztof Kozlowski
2023-03-20 14:38 ` Johan Hovold
2023-03-20 14:37 ` Johan Hovold
2023-03-20 13:57 ` [PATCH 3/3] dt-bindings: mfd: qcom,spmi-pmic: add nvram function Johan Hovold
2023-03-20 14:13 ` Krzysztof Kozlowski
2023-03-21 13:17 ` Rob Herring
2023-03-21 13:20 ` Rob Herring
2023-03-21 13:38 ` Johan Hovold
2023-03-21 15:27 ` Rob Herring
2023-03-22 7:14 ` Johan Hovold
2023-03-21 13:28 ` Johan Hovold
2023-03-21 19:52 ` Rob Herring
2023-03-30 13:02 ` Lee Jones
2023-03-24 18:34 ` (subset) [PATCH 0/3] arm64: dts: qcom: sc8280xp-pmics: fix sdam 'reg' property Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320135710.1989-2-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).