From: Johan Hovold <johan@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
devicetree@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-arm-msm@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee@kernel.org>
Subject: Re: [PATCH 3/3] dt-bindings: mfd: qcom,spmi-pmic: add nvram function
Date: Wed, 22 Mar 2023 08:14:34 +0100 [thread overview]
Message-ID: <ZBqq2sIcjLenI/Az@hovoldconsulting.com> (raw)
In-Reply-To: <CAL_JsqKOSQJBVAaDVrAze6VZe9XHaY7AMs_pM=f3Pgto6UDDqA@mail.gmail.com>
On Tue, Mar 21, 2023 at 10:27:55AM -0500, Rob Herring wrote:
> On Tue, Mar 21, 2023 at 8:37 AM Johan Hovold <johan@kernel.org> wrote:
> > On Tue, Mar 21, 2023 at 08:20:55AM -0500, Rob Herring wrote:
> > > On Tue, Mar 21, 2023 at 8:17 AM Rob Herring <robh@kernel.org> wrote:
> > > > On Mon, 20 Mar 2023 14:57:10 +0100, Johan Hovold wrote:
> > > > > Add an 'nvram' pattern property and a reference to the corresponding
> > > > > SDAM DT schema.
> > > > >
> > > > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > > > > ---
> > > > > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++
> > > > > 1 file changed, 4 insertions(+)
> > > >
> > > > Running 'make dtbs_check' with the schema in this patch gives the
> > > > following warnings. Consider if they are expected or the schema is
> > > > incorrect. These may not be new warnings.
> > > >
> > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > > > This will change in the future.
> > > >
> > > > Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230320135710.1989-4-johan+linaro@kernel.org
> > > >
> > >
> > > This is a long list of warnings. Can you all fix some of them before
> > > adding on to this binding.
> >
> > Note that this patch is only making the list of warnings shorter so I
> > don't think addressing the remaining issues should block this one.
>
> How can you tell sorting thru the 100s of warnings? It sounded like a
> new feature to me, not a fix for something missing. Anyways, I've
> gotten 2 patches today for this binding and I don't see patches for
> fixes. Which is a bit surprising because you all generally are fixing
> warnings on the QCom stuff.
Indeed, it was not obvious and that's why I mentioned it.
The SDAM binding has been there since 2020 and 9664a6b54c57
("dt-bindings: nvmem: add binding for QTI SPMI SDAM") but updating the
"parent" pmic binding was apparently overlooked.
I'm generally not cleaning up DT checker warnings, but I want to avoid
adding new ones as I unknowingly did in this case when enabling the RTC
on the X13s.
> I didn't really mean to block this one, but I don't really want to see more.
Understood.
Johan
next prev parent reply other threads:[~2023-03-22 7:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 13:57 [PATCH 0/3] arm64: dts: qcom: sc8280xp-pmics: fix sdam 'reg' property Johan Hovold
2023-03-20 13:57 ` [PATCH 1/3] dt-bindings: nvmem: qcom,spmi-sdam: fix example " Johan Hovold
2023-03-20 14:12 ` Krzysztof Kozlowski
2023-03-20 14:40 ` Johan Hovold
2023-03-20 13:57 ` [PATCH 2/3] arm64: dts: qcom: sc8280xp-pmics: fix sdam " Johan Hovold
2023-03-20 14:05 ` Konrad Dybcio
2023-03-20 14:11 ` Krzysztof Kozlowski
2023-03-20 14:38 ` Johan Hovold
2023-03-20 14:37 ` Johan Hovold
2023-03-20 13:57 ` [PATCH 3/3] dt-bindings: mfd: qcom,spmi-pmic: add nvram function Johan Hovold
2023-03-20 14:13 ` Krzysztof Kozlowski
2023-03-21 13:17 ` Rob Herring
2023-03-21 13:20 ` Rob Herring
2023-03-21 13:38 ` Johan Hovold
2023-03-21 15:27 ` Rob Herring
2023-03-22 7:14 ` Johan Hovold [this message]
2023-03-21 13:28 ` Johan Hovold
2023-03-21 19:52 ` Rob Herring
2023-03-30 13:02 ` Lee Jones
2023-03-24 18:34 ` (subset) [PATCH 0/3] arm64: dts: qcom: sc8280xp-pmics: fix sdam 'reg' property Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBqq2sIcjLenI/Az@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).