From: Johan Hovold <johan@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Lee Jones <lee@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: nvmem: qcom,spmi-sdam: fix example 'reg' property
Date: Mon, 20 Mar 2023 15:40:58 +0100 [thread overview]
Message-ID: <ZBhwevJxxEz2I4i9@hovoldconsulting.com> (raw)
In-Reply-To: <136736ef-2502-0f09-1c09-02fbf155ae4e@linaro.org>
On Mon, Mar 20, 2023 at 03:12:41PM +0100, Krzysztof Kozlowski wrote:
> On 20/03/2023 14:57, Johan Hovold wrote:
> > The SPMI PMIC register region width is fixed and should not be encoded
> > in the devicetree.
> >
> > Amend the example with a parent pmic node with the expected
> > '#address-cells' and '#size-cells' and fix up the 'reg' property.
> >
> > Fixes: 9664a6b54c57 ("dt-bindings: nvmem: add binding for QTI SPMI SDAM")
>
> I would argue there is nothing to fix - the original example in that
> context was correct, because examples have size-cells=1.
But you'll never find these PMIC functions on a memory-mapped or other
bus with size-cells != 0 so I'd still say that the example is broken
(and it is definitely misleading as I found out the hard way).
Johan
next prev parent reply other threads:[~2023-03-20 14:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 13:57 [PATCH 0/3] arm64: dts: qcom: sc8280xp-pmics: fix sdam 'reg' property Johan Hovold
2023-03-20 13:57 ` [PATCH 1/3] dt-bindings: nvmem: qcom,spmi-sdam: fix example " Johan Hovold
2023-03-20 14:12 ` Krzysztof Kozlowski
2023-03-20 14:40 ` Johan Hovold [this message]
2023-03-20 13:57 ` [PATCH 2/3] arm64: dts: qcom: sc8280xp-pmics: fix sdam " Johan Hovold
2023-03-20 14:05 ` Konrad Dybcio
2023-03-20 14:11 ` Krzysztof Kozlowski
2023-03-20 14:38 ` Johan Hovold
2023-03-20 14:37 ` Johan Hovold
2023-03-20 13:57 ` [PATCH 3/3] dt-bindings: mfd: qcom,spmi-pmic: add nvram function Johan Hovold
2023-03-20 14:13 ` Krzysztof Kozlowski
2023-03-21 13:17 ` Rob Herring
2023-03-21 13:20 ` Rob Herring
2023-03-21 13:38 ` Johan Hovold
2023-03-21 15:27 ` Rob Herring
2023-03-22 7:14 ` Johan Hovold
2023-03-21 13:28 ` Johan Hovold
2023-03-21 19:52 ` Rob Herring
2023-03-30 13:02 ` Lee Jones
2023-03-24 18:34 ` (subset) [PATCH 0/3] arm64: dts: qcom: sc8280xp-pmics: fix sdam 'reg' property Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBhwevJxxEz2I4i9@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).